From: Wenwen Wang <wenwen@cs.uga.edu>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vkoul@kernel.org>, Enrico Weigelt <info@metux.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>,
"open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM"
<dmaengine@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Wenwen Wang <wenwen@cs.uga.edu>
Subject: Re: [PATCH] dmaengine: ti: Fix a memory leak bug
Date: Fri, 16 Aug 2019 02:45:29 -0400 [thread overview]
Message-ID: <CAAa=b7duUGPPKDKTn8yeX=8yVB99ftw_u6N_4j0K5DKj0vtxYQ@mail.gmail.com> (raw)
In-Reply-To: <f6ddbed6-581c-cf0b-515a-52f9fb4f4fa2@ti.com>
On Fri, Aug 16, 2019 at 2:42 AM Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
>
>
>
> On 16/08/2019 9.23, Wenwen Wang wrote:
> > In ti_dra7_xbar_probe(), 'rsv_events' is allocated through kcalloc(). Then
> > of_property_read_u32_array() is invoked to search for the property.
> > However, if this process fails, 'rsv_events' is not deallocated, leading to
> > a memory leak bug. To fix this issue, free 'rsv_events' before returning
> > the error.
>
> Can you change the subject to:
> "dmaengine: ti: dma-crossbar: Fix a memory leak bug" ?
No problem. I will rework the patch. Thanks for your suggestion!
Wenwen
>
> Otherwise: Thank you, and
> Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> >
> > Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
> > ---
> > drivers/dma/ti/dma-crossbar.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/dma/ti/dma-crossbar.c b/drivers/dma/ti/dma-crossbar.c
> > index ad2f0a4..f255056 100644
> > --- a/drivers/dma/ti/dma-crossbar.c
> > +++ b/drivers/dma/ti/dma-crossbar.c
> > @@ -391,8 +391,10 @@ static int ti_dra7_xbar_probe(struct platform_device *pdev)
> >
> > ret = of_property_read_u32_array(node, pname, (u32 *)rsv_events,
> > nelm * 2);
> > - if (ret)
> > + if (ret) {
> > + kfree(rsv_events);
> > return ret;
> > + }
> >
> > for (i = 0; i < nelm; i++) {
> > ti_dra7_xbar_reserve(rsv_events[i][0], rsv_events[i][1],
> >
>
> - Péter
>
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
prev parent reply other threads:[~2019-08-16 7:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 6:23 [PATCH] dmaengine: ti: Fix a memory leak bug Wenwen Wang
2019-08-16 6:43 ` Peter Ujfalusi
2019-08-16 6:45 ` Wenwen Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAa=b7duUGPPKDKTn8yeX=8yVB99ftw_u6N_4j0K5DKj0vtxYQ@mail.gmail.com' \
--to=wenwen@cs.uga.edu \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=tglx@linutronix.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).