From: Rob Herring <robh@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Vinod <vkoul@kernel.org>,
"open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM"
<dmaengine@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: dmaengine: dma-common: Change dma-channel-mask to uint32-array
Date: Wed, 18 Sep 2019 09:21:26 -0500 [thread overview]
Message-ID: <CAL_JsqLJn4dmnjU=7kVgiosAU=o+fSJNH6578D92fGbdOR8Zfw@mail.gmail.com> (raw)
In-Reply-To: <d76ffc38-8e68-656a-325b-37de9b01e015@ti.com>
On Wed, Sep 18, 2019 at 9:04 AM Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
>
>
>
> On 18/09/2019 16.28, Rob Herring wrote:
> > On Tue, Sep 10, 2019 at 02:45:57PM +0300, Peter Ujfalusi wrote:
> >> Make the dma-channel-mask to be usable for controllers with more than 32
> >> channels.
> >>
> >> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> >> ---
> >> Documentation/devicetree/bindings/dma/dma-common.yaml | 10 +++++++++-
> >> 1 file changed, 9 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/dma/dma-common.yaml b/Documentation/devicetree/bindings/dma/dma-common.yaml
> >> index ed0a49a6f020..41460946be64 100644
> >> --- a/Documentation/devicetree/bindings/dma/dma-common.yaml
> >> +++ b/Documentation/devicetree/bindings/dma/dma-common.yaml
> >> @@ -25,11 +25,19 @@ properties:
> >> Used to provide DMA controller specific information.
> >>
> >> dma-channel-mask:
> >> - $ref: /schemas/types.yaml#definitions/uint32
> >> description:
> >> Bitmask of available DMA channels in ascending order that are
> >> not reserved by firmware and are available to the
> >> kernel. i.e. first channel corresponds to LSB.
> >> + allOf:
> >> + - $ref: /schemas/types.yaml#/definitions/uint32-array
> >> + items:
> >> + minItems = 1
> >
> > '='? Just making up the syntax?
>
> Opps, sorry.
>
> >
> >> + maxItems = 255 # Should be enough
> >> + - description: Mask of channels 0-31
> >> + - description: Mask of channels 32-63
> >
> > You are mixing a schema and list here...
>
> Should I extend the description with something like this:
> "The first item in the array is for channels 0-31, the second is for
> channels 32-63, etc."
>
> To make sure that it is used in a correct and consistent manner.
Sure.
>
> >> + ...
> >
> > That's end of doc marker in YAML...
>
> I believe I need some reading to do for YAML..
>
> >
> >> + - description: Mask of chnanels X-(X+31)
> >
> > Obviously, this was not validated with 'make dt_binding_check'.
> make dt_bindings_check
> make: *** No rule to make target 'dt_bindings_check'. Stop.
Read Documentation/devicetree/writing-schema.md (or .rst in next).
Either your config doesn't have DTC enabled or you don't have
dt-schema installed.
>
> > What you want is:
> >
> > allOf:
> > - $ref: /schemas/types.yaml#/definitions/uint32-array
> > - minItems: 1
> > maxItems: 255 # Should be enough
>
> OK and thanks for the comments.
>
> - Péter
>
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2019-09-18 14:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 11:45 [PATCH v2 0/3] dmaengine: bindings/edma: dma-channel-mask to array Peter Ujfalusi
2019-09-10 11:45 ` [PATCH v2 1/3] dt-bindings: dmaengine: dma-common: Change dma-channel-mask to uint32-array Peter Ujfalusi
2019-09-18 13:28 ` Rob Herring
2019-09-18 14:04 ` Peter Ujfalusi
2019-09-18 14:21 ` Rob Herring [this message]
2019-09-19 8:42 ` Peter Ujfalusi
2019-09-10 11:45 ` [PATCH v2 2/3] dt-bindings: dma: ti-edma: Document dma-channel-mask for EDMA Peter Ujfalusi
2019-09-18 13:29 ` Rob Herring
2019-09-18 14:06 ` Peter Ujfalusi
2019-09-10 11:45 ` [PATCH v2 3/3] dmaengine: ti: edma: Add support for handling reserved channels Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqLJn4dmnjU=7kVgiosAU=o+fSJNH6578D92fGbdOR8Zfw@mail.gmail.com' \
--to=robh@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).