From: Leo Li <leoyang.li@nxp.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Zhang Wei <zw@zh-kernel.org>, Vinod Koul <vkoul@kernel.org>,
Dan Williams <dan.j.williams@intel.com>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] dmaengine: fsldma: Mark expected switch fall-through
Date: Mon, 12 Aug 2019 19:40:58 +0000 [thread overview]
Message-ID: <VE1PR04MB6687030F764BAAB24FDE80378FD30@VE1PR04MB6687.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20190812002159.GA26899@embeddedor>
> -----Original Message-----
> From: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Sent: Sunday, August 11, 2019 7:22 PM
> To: Leo Li <leoyang.li@nxp.com>; Zhang Wei <zw@zh-kernel.org>; Vinod
> Koul <vkoul@kernel.org>; Dan Williams <dan.j.williams@intel.com>
> Cc: linuxppc-dev@lists.ozlabs.org; dmaengine@vger.kernel.org; linux-
> kernel@vger.kernel.org; Gustavo A. R. Silva <gustavo@embeddedor.com>
> Subject: [PATCH] dmaengine: fsldma: Mark expected switch fall-through
>
> Mark switch cases where we are expecting to fall through.
>
> Fix the following warning (Building: powerpc-ppa8548_defconfig powerpc):
>
> drivers/dma/fsldma.c: In function ‘fsl_dma_chan_probe’:
> drivers/dma/fsldma.c:1165:26: warning: this statement may fall through [-
> Wimplicit-fallthrough=]
> chan->toggle_ext_pause = fsl_chan_toggle_ext_pause;
> ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/dma/fsldma.c:1166:2: note: here
> case FSL_DMA_IP_83XX:
> ^~~~
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Li Yang <leoyang.li@nxp.com>
> ---
> drivers/dma/fsldma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index
> 23e0a356f167..ad72b3f42ffa 100644
> --- a/drivers/dma/fsldma.c
> +++ b/drivers/dma/fsldma.c
> @@ -1163,6 +1163,7 @@ static int fsl_dma_chan_probe(struct
> fsldma_device *fdev,
> switch (chan->feature & FSL_DMA_IP_MASK) {
> case FSL_DMA_IP_85XX:
> chan->toggle_ext_pause = fsl_chan_toggle_ext_pause;
> + /* Fall through */
> case FSL_DMA_IP_83XX:
> chan->toggle_ext_start = fsl_chan_toggle_ext_start;
> chan->set_src_loop_size = fsl_chan_set_src_loop_size;
> --
> 2.22.0
next prev parent reply other threads:[~2019-08-12 19:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 0:22 [PATCH] dmaengine: fsldma: Mark expected switch fall-through Gustavo A. R. Silva
2019-08-12 19:40 ` Leo Li [this message]
2019-08-13 4:38 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR04MB6687030F764BAAB24FDE80378FD30@VE1PR04MB6687.eurprd04.prod.outlook.com \
--to=leoyang.li@nxp.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=vkoul@kernel.org \
--cc=zw@zh-kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).