From: Markus Elfring <Markus.Elfring@web.de>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>,
dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>,
Vinod Koul <vkoul@kernel.org>, Aditya Pakki <pakki001@umn.edu>,
Kangjie Lu <kjlu@umn.edu>, Navid Emamdoost <emamd001@umn.edu>,
Qiushi Wu <wu000273@umn.edu>
Subject: Re: [PATCH v4] dmaengine: tegra210-adma: Fix runtime PM imbalance on error
Date: Sun, 21 Jun 2020 12:50:28 +0200 [thread overview]
Message-ID: <d1872c79-7998-46cd-a7b6-6c5715391ca3@web.de> (raw)
I propose to combine two tags in the previous patch subject.
> pm_runtime_get_sync() increments the runtime PM usage counter even
> when it returns an error code. Thus a pairing decrement is needed on
> the error handling path to keep the counter balanced.
* Can an imperative wording be nicer for the change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=64677779e8962c20b580b471790fe42367750599#n151
* Would you like to add the tag “Fixes” to the commit message?
> ---
> drivers/dma/tegra210-adma.c | 5 ++++-
I find it nicer to replace the triple dashes before this diffstat
by a blank line.
Regards,
Markus
next reply other threads:[~2020-06-21 10:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-21 10:50 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-06-21 5:47 [PATCH] [v4] dmaengine: tegra210-adma: Fix runtime PM imbalance on error Dinghao Liu
2020-06-23 10:13 ` Jon Hunter
2020-06-23 12:08 ` Geert Uytterhoeven
2020-06-23 12:25 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1872c79-7998-46cd-a7b6-6c5715391ca3@web.de \
--to=markus.elfring@web.de \
--cc=dan.j.williams@intel.com \
--cc=dinghao.liu@zju.edu.cn \
--cc=dmaengine@vger.kernel.org \
--cc=emamd001@umn.edu \
--cc=jonathanh@nvidia.com \
--cc=kjlu@umn.edu \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pakki001@umn.edu \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).