From: Sinan Kaya <okaya@kernel.org>
To: Robin Murphy <robin.murphy@arm.com>,
Nishka Dasgupta <nishkadg.linux@gmail.com>,
agross@kernel.org, vkoul@kernel.org, dan.j.williams@intel.com,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH] dma: qcom: hidma_mgmt: Add of_node_put() before goto
Date: Tue, 23 Jul 2019 11:45:16 -0400 [thread overview]
Message-ID: <ecaf00a7-dbb2-679b-3670-b9d6619bf97c@kernel.org> (raw)
In-Reply-To: <b5b76ef6-c5f3-bab0-e981-cd47c7264959@arm.com>
On 7/23/2019 8:02 AM, Robin Murphy wrote:
> Why not just add it once at the "out" label itself? (Consider the
> conditions for the loop terminating naturally)
>
+1
>>
>> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
>> ---
>> drivers/dma/qcom/hidma_mgmt.c | 13 ++++++++++---
>> 1 file changed, 10 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/dma/qcom/hidma_mgmt.c
>> b/drivers/dma/qcom/hidma_mgmt.c
>> index 3022d66e7a33..209adc6ceabe 100644
>> --- a/drivers/dma/qcom/hidma_mgmt.c
>> +++ b/drivers/dma/qcom/hidma_mgmt.c
>> @@ -362,16 +362,22 @@ static int __init
>> hidma_mgmt_of_populate_channels(struct device_node *np)
>> struct platform_device *new_pdev;
>> ret = of_address_to_resource(child, 0, &res[0]);
>> - if (!ret)
>> + if (!ret) {
>> + of_node_put(child);
The spacing on this also looks weird.
>> goto out;
>> + }
next prev parent reply other threads:[~2019-07-23 15:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 10:35 [PATCH] dma: qcom: hidma_mgmt: Add of_node_put() before goto Nishka Dasgupta
2019-07-23 12:02 ` Robin Murphy
2019-07-23 15:45 ` Sinan Kaya [this message]
2019-07-24 8:05 ` Nishka Dasgupta
2019-07-24 10:10 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecaf00a7-dbb2-679b-3670-b9d6619bf97c@kernel.org \
--to=okaya@kernel.org \
--cc=agross@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=nishkadg.linux@gmail.com \
--cc=robin.murphy@arm.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).