Re: [dpdk-dev] [PATCH] eal: reorganize directories layout

From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, david.marchand@redhat.com,
	"Neil Horman" <nhorman@tuxdriver.com>,
	"John McNamara" <john.mcnamara@intel.com>,
	"Marko Kovacevic" <marko.kovacevic@intel.com>,
	"Hemant Agrawal" <hemant.agrawal@nxp.com>,
	"Sachin Saxena" <sachin.saxena@nxp.com>,
	"Matan Azrad" <matan@mellanox.com>,
	"Shahaf Shuler" <shahafs@mellanox.com>,
	"Viacheslav Ovsiienko" <viacheslavo@mellanox.com>,
	"Gagandeep Singh" <g.singh@nxp.com>,
	"Akhil Goyal" <akhil.goyal@nxp.com>,
	"Nipun Gupta" <nipun.gupta@nxp.com>,
	"Maxime Coquelin" <maxime.coquelin@redhat.com>,
	"Zhihong Wang" <zhihong.wang@intel.com>,
	"Xiaolong Ye" <xiaolong.ye@intel.com>,
	"Ferruh Yigit" <ferruh.yigit@intel.com>,
	"Cristian Dumitrescu" <cristian.dumitrescu@intel.com>,
	"Jan Viktorin" <viktorin@rehivetech.com>,
	"Gavin Hu" <gavin.hu@arm.com>, "Jerin Jacob" <jerinj@marvell.com>,
	"Harry van Haaren" <harry.van.haaren@intel.com>,
	"Anatoly Burakov" <anatoly.burakov@intel.com>,
	"Phil Yang" <phil.yang@arm.com>,
	"Joyce Kong" <joyce.kong@arm.com>,
	"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
	"David Christensen" <drc@linux.vnet.ibm.com>,
	"Harini Ramakrishnan" <harini.ramakrishnan@microsoft.com>,
	"Omar Cardona" <ocardona@microsoft.com>,
	"Pallavi Kadam" <pallavi.kadam@intel.com>,
	"Ranjit Menon" <ranjit.menon@intel.com>,
	"Konstantin Ananyev" <konstantin.ananyev@intel.com>,
	"Olivier Matz" <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] eal: reorganize directories layout
Date: Fri, 20 Mar 2020 12:46:26 +0100	[thread overview]
Message-ID: <1741544.tdWV9SEqCh@xps> (raw)
In-Reply-To: <20200320093418.GA1502@bricha3-MOBL.ger.corp.intel.com>

20/03/2020 10:34, Bruce Richardson:
> On Fri, Mar 20, 2020 at 01:12:18AM +0100, Thomas Monjalon wrote:
> > Some clean-up is done in EAL sub-directories.
> > The goal is to make organization easier to understand,
> > and to prepare moving some files from common to Unix-only place.
> > 
> > Since the kernel modules are moved to kernel/ directory,
> > there is no need anymore for the sub-directory eal/ in
> > linux/, freebsd/ and windows/.
> > 
> > The EAL API (with doxygen documentation) is moved from
> > common/include/ to include/, which makes more clear that
> > it is the global API for all environments and architectures.
> > Note that the arch-specific and os-specific include files are not
> > in this global include directory, but include/generic/ should
> > cover the doxygen documentation for them.
> > 
> > The arch-specific directories arm, ppc_64 and x86 in common/arch/
> > and in common/include/arch are moved at the same level as the
> > os-specific directories, adding an include/ sub-directory.
> > It makes more clear that EAL is covering a matrix combining OS and arch.
> > Note that ppc_64 is renamed to ppc.
> > 
> > These moves offer the opportunity to simplify the make and meson files.
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > 
> > ---
> > 
> > This change was proposed to the Technical Board in advance:
> > http://mails.dpdk.org/archives/dev/2020-January/156732.html
> > 
> > If required, the patch may be split:
> >    1/ remove FreeBSD kernel Makefile
> >    2/ move arch .c files
> >    3/ move arch .h files
> >    4/ move common and generic includes
> >    5/ move os/eal/ to os/
> > 
> 
> I've scanned through this patch and it is quite long. I like the idea of
> cleanup, but I do think splitting would make reviewing easier, since it's
> hard to track what is moving where all in one go.

OK, I'll prepare a v2, split in 5 patches.
Note: v1 is not compiling because I missed some "git add" in the include directory.