From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,URIBL_SBL,URIBL_SBL_A autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3946EC7618F for ; Wed, 17 Jul 2019 22:10:45 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id A1BCA21849 for ; Wed, 17 Jul 2019 22:10:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="lPcM7DAX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1BCA21849 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=networkplumber.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6AE782BAB; Thu, 18 Jul 2019 00:10:43 +0200 (CEST) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 4B9451D9E for ; Thu, 18 Jul 2019 00:10:42 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id p184so11516219pfp.7 for ; Wed, 17 Jul 2019 15:10:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nCuiLjfH8Rb6opu/aKhOqBPNjp2aC+2845UAFwwBndw=; b=lPcM7DAXXljFN4PDKqAU2aa9Pk7uKqOJ8LrN+scO249UaPAv+ZEXGeom7jMz7oeWJK oq6yvBHgQC7PHzRrTzbEmp5DhBupdiZbwE6Jui5RoZglzLMzFVqlxd5whgGBygeiK6IQ Btevlf0HytI4D0uPGPG/HqZeJRkNnFvOKjNUJTvbENIcmLmrius9dwAbQYm7JZCqQDjb LmtZFF8/gSoUgVMf+0LlphIRBCM4RY1v7zM+oOtmn4GZWdHe4SoVOdroI5ysmdDfsYJK ELFREuAzauwfBhRhvGzQgGBILEdqoJC6PSrHbLN6FJxcp6243wWNuZsAUd2yNODn/fmI +z8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nCuiLjfH8Rb6opu/aKhOqBPNjp2aC+2845UAFwwBndw=; b=blsZq6htX5OkoXfiLmt8PHQnsZ2SIy0vLDaYNxxrpeg5MHatO1VoxaOiiP/lTvY7C8 NKugZvGB094ujyabLMzN1vUb+Axoq3mB0a5rebH+OyVToQ/1JbOsyEYXJMWCHP+6PXxA iWCWae/XMrcJ8dbXrBMfHbtmxR+YxDzrTVthL7YzbVLfDzbZ2kOVPllLXM3k2iMUa0fk j9pQWbdnSqHyIu3lkLcQRHj52Z1EMUMBkiXqiIhI4MJwg4nsIpTilPmQOtv6uVYVptNY /HlTdXJRYq6DnazzONVnQsy+wq9esJcNFhlpBeF3N/W/CNA+L2nckAlhlRQn4PWZeOFI 7jEQ== X-Gm-Message-State: APjAAAXOV/xRU+dm0SF0FS80D7dJWXd6jnC2aXCSPhqJRQJavm1v5FnS va8C4GFkSU9/tGuMsZCNjDw= X-Google-Smtp-Source: APXvYqy6qnc+AvhPulfaxV3pei/ykaTtzFR/6dhiK8mDlVohXuL6htdDXu7QUeGtFebo+1cF4sC+1A== X-Received: by 2002:a63:6bc5:: with SMTP id g188mr12840283pgc.225.1563401441240; Wed, 17 Jul 2019 15:10:41 -0700 (PDT) Received: from xps13 ([67.23.203.6]) by smtp.gmail.com with ESMTPSA id j15sm33508868pfn.150.2019.07.17.15.10.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Jul 2019 15:10:41 -0700 (PDT) Date: Wed, 17 Jul 2019 15:10:38 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: dev@dpdk.org, cristian.dumitrescu@intel.com, david.marchand@redhat.com, bruce.richardson@intel.com Message-ID: <20190717151038.2c658430@xps13> In-Reply-To: <1785181.DCrEJ4CubZ@xps> References: <20190716172741.21399-1-stephen@networkplumber.org> <20190716172741.21399-3-stephen@networkplumber.org> <1785181.DCrEJ4CubZ@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/3] cfgfile: use RTE_LOG for errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 17 Jul 2019 23:01:00 +0200 Thomas Monjalon wrote: > 16/07/2019 19:27, Stephen Hemminger: > > In general, DPDK libraries to not print error messages to > > stdout because that is often redirected to /dev/null for daemons. > > This patch changes cfgfile library to use RTE_LOG with its > > own type. > > > > Signed-off-by: Stephen Hemminger > > --- > > --- a/lib/librte_eal/common/include/rte_log.h > > +++ b/lib/librte_eal/common/include/rte_log.h > > @@ -62,6 +62,7 @@ extern struct rte_logs rte_logs; > > #define RTE_LOGTYPE_EFD 18 /**< Log related to EFD. */ > > #define RTE_LOGTYPE_EVENTDEV 19 /**< Log related to eventdev. */ > > #define RTE_LOGTYPE_GSO 20 /**< Log related to GSO. */ > > +#define RTE_LOGTYPE_CFGFILE 21 /**< Log related to cfgfile. */ > > As you know, we are supposed to use dynamic logging now. > Let's stop to add new static log types here. > Better, we should plan to completely drop these types. > > Ok, but rte_cfgfile can be used before eal init.