From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68025C76191 for ; Thu, 18 Jul 2019 14:35:12 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id ED47320873 for ; Thu, 18 Jul 2019 14:35:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="N9TQB6Dp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED47320873 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=networkplumber.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 744211B53; Thu, 18 Jul 2019 16:35:10 +0200 (CEST) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 1CB601041 for ; Thu, 18 Jul 2019 16:35:08 +0200 (CEST) Received: by mail-pf1-f194.google.com with SMTP id b13so12727934pfo.1 for ; Thu, 18 Jul 2019 07:35:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SqQChFJtgj2s77XpH+gaNeF1EKa0lLt20xLzeHmooO4=; b=N9TQB6DpH4CZO+SFxmXh+JjrEvw6RiMyoSegt5dVJSi1jEmUGTIUeqKCGiEoOPAlbm FDfJNSpnnvADM+t759vAOtmAJdKUwEt1Xziv32qE5l6mtfqEe+gYp2r2S2R2w/s2eRkX Gd2mQ2vB1TvrDs+IVAz9muEq/jYJ2YZvggrwaxl5G8e2mrmlOyt9EHJoHunhugXXdC8Y cQV1ENRlRsTwy6s5+yJQz1xATrbAzxex/qYYH6KyFhmLHrN77N88WFOsSIRxfxN8/+lg zRV1Dk0K2XkNlYlT6dwzz8NHFY2PPPm6Mpr9i9gZ108xhDPe7BZ499kM1KGOWWzY8ZoL wOZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SqQChFJtgj2s77XpH+gaNeF1EKa0lLt20xLzeHmooO4=; b=Vsfsm0jIw7v7qPxiOj9sMEQ3nB+wEUH1CabqfQ1EqV1wLjtOzYcsyfuN/dfeD6tUCY lW/SIuXscjG5ieBsF4FbJW9f3VgeEcPwoe+Sb2HPZ94iKGb7vO0FcI9rNgfm8kRSJiVz 3sR99laWU0wGw2oSgHJjeAneDgvC4O6xuoRMLm+RUHDZVftBJ+it9r4286Gv/+sxQ2rL SwR76K6oUliDAWYjzG58oHG8MLZuNFYMH37T/vRmnEbYIR7+Okb6R0JDg6yebBSzru5m d5j3GMq1/gySTe7r4YGAqWgHRtUa5enQU57AWCsDIKissnfh+3OZB+xv4EklL4wm+p53 i3lw== X-Gm-Message-State: APjAAAW7icTvWk+AKEvru0aroxVe7x79ULjTlpLqh5uM8eTi/6llq3d2 AzUp3nBE7puv2qYmdijRZew= X-Google-Smtp-Source: APXvYqwHtn27Ovag4OwQglMSG5XdCXci3UqykqkLPvfhub1lH7XvEixW61QR1M9vaggVUFoHZIfn9g== X-Received: by 2002:a63:a346:: with SMTP id v6mr2040340pgn.57.1563460507059; Thu, 18 Jul 2019 07:35:07 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id j12sm17579310pff.4.2019.07.18.07.35.06 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 18 Jul 2019 07:35:06 -0700 (PDT) Date: Thu, 18 Jul 2019 07:34:59 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: dev@dpdk.org Message-ID: <20190718073459.3004bb39@hermes.lan> In-Reply-To: <20190718083111.GA1325@bricha3-MOBL.ger.corp.intel.com> References: <20190716172741.21399-1-stephen@networkplumber.org> <20190718004822.25431-1-stephen@networkplumber.org> <20190718004822.25431-3-stephen@networkplumber.org> <20190718083111.GA1325@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 2/3] cfgfile: use RTE_LOG for errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 18 Jul 2019 09:31:11 +0100 Bruce Richardson wrote: > On Wed, Jul 17, 2019 at 05:48:21PM -0700, Stephen Hemminger wrote: > > In general, DPDK libraries to not print error messages to > > stdout because that is often redirected to /dev/null for daemons. > > This patch changes cfgfile library to use RTE_LOG with its > > own type. > > > > Signed-off-by: Stephen Hemminger > > --- > > lib/librte_cfgfile/Makefile | 1 + > > lib/librte_cfgfile/rte_cfgfile.c | 38 +++++++++++++++++++++++--------- > > 2 files changed, 29 insertions(+), 10 deletions(-) > > > > diff --git a/lib/librte_cfgfile/Makefile b/lib/librte_cfgfile/Makefile > > index d9512565e559..4fc711778699 100644 > > --- a/lib/librte_cfgfile/Makefile > > +++ b/lib/librte_cfgfile/Makefile > > @@ -11,6 +11,7 @@ LIB = librte_cfgfile.a > > CFLAGS += -O3 > > CFLAGS += $(WERROR_FLAGS) > > CFLAGS += -I$(SRCDIR)/../librte_eal/common/include > > +LDFLAGS += -lrte_log > > > Where does this come from, there is no separate log library in DPDK? I saw a build failure with previous patch about rte_log not being present.