From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 060BAC3A589 for ; Tue, 20 Aug 2019 05:16:40 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 94F632087E for ; Tue, 20 Aug 2019 05:16:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94F632087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2D8C51BEA7; Tue, 20 Aug 2019 07:16:38 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 807821BEA6 for ; Tue, 20 Aug 2019 07:16:36 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Aug 2019 22:16:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,407,1559545200"; d="scan'208";a="202560371" Received: from dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.71]) by fmsmga004.fm.intel.com with ESMTP; 19 Aug 2019 22:16:34 -0700 Date: Tue, 20 Aug 2019 13:14:18 +0800 From: Tiwei Bie To: Jim Harris Cc: dev@dpdk.org, maxime.coquelin@redhat.com, zhihong.wang@intel.com Message-ID: <20190820051417.GA12986@___> References: <156621948797.9571.17549862831374094643.stgit@jrharri1-skx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <156621948797.9571.17549862831374094643.stgit@jrharri1-skx> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] vhost: remove rte_vhost_va_from_guest_pa from map file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Aug 19, 2019 at 05:58:08AM -0700, Jim Harris wrote: > This function is declared __rte_always_inline so it > seems unnecessary to include it in the map file. In > addition, it was included in the EXPERIMENTAL section > even though the function itself is not marked > __rte_experimental. > > Found by check-experimental-syms.sh when trying to compile > DPDK with -finstrument-functions. > > Signed-off-by: Jim Harris > --- > lib/librte_vhost/rte_vhost_version.map | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_version.map > index 5f1d4a75c..4908b9b21 100644 > --- a/lib/librte_vhost/rte_vhost_version.map > +++ b/lib/librte_vhost/rte_vhost_version.map > @@ -82,7 +82,6 @@ EXPERIMENTAL { > rte_vhost_crypto_fetch_requests; > rte_vhost_crypto_finalize_requests; > rte_vhost_crypto_set_zero_copy; > - rte_vhost_va_from_guest_pa; > rte_vhost_host_notifier_ctrl; > rte_vdpa_relay_vring_used; > rte_vhost_extern_callback_register; > It might be better to mark this function with __rte_experimental to fix the build with -finstrument-functions, as in this way we can also get warned when using it with ALLOW_EXPERIMENTAL_API undefined. And we can have another patch to promote it to stable. Thanks, Tiwei