From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 300B3CA9EAE for ; Tue, 29 Oct 2019 16:42:46 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 4813320874 for ; Tue, 29 Oct 2019 16:42:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="f3wrL7jF"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="ihOwvZ+z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4813320874 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 21F411BF2F; Tue, 29 Oct 2019 17:42:44 +0100 (CET) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id CFB8B1BEF7 for ; Tue, 29 Oct 2019 17:42:42 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id DAEAE5AA7; Tue, 29 Oct 2019 12:42:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 29 Oct 2019 12:42:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=dzH0H80PcEjRQwh30MX1Pt01T2Rs8x05806BJmq2BPk=; b=f3wrL7jFnllC tl6AwoLQRbna6PQPsbwAd3+NCqUl+eHupNnrzSUoTU/epbXGpge0/NfgVZVC2OlD zRGWV09jpk8Jfi4JExAKQbX9gq5JDfSK7kNOdCfgjw2NZn0yDjd3yJx/jz4/Tq8N rhNUSTDAM/HlPg6SemT7OLvK+z5fWHQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=dzH0H80PcEjRQwh30MX1Pt01T2Rs8x05806BJmq2B Pk=; b=ihOwvZ+zZeEx+cks9PKuMASdOQH+07YKwDRy/1AtPMPFeTgNmcRa91jhw Fe1ACVX6sUQmQwPkUVY2vqf3M1QFO7BK1jPkLOXoZzahYRl4Exb3K5CR3LWqDQm0 oheXvUM8zhLYlMH5q4JeNx/2z+9hq6B4cOIyt0roXEEaf3rnkKcbpUL27dhmOBNa BCRl7MLXlmMdDuBvN2UFbCmMUPUkqU3xEQjUfAq6O2LrQIQs6k0KeVzFV7ZK93AX vDMBRuseGEnl0JV2KGJVZX1IOr4vfDvdKdcnqmXiwqGded13nxs6Ny1ymAKaw+3E rn9y9OeIYpzNfPfA9uPa3io69lX1w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedruddtuddgledtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtne cuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D032080063; Tue, 29 Oct 2019 12:42:38 -0400 (EDT) From: Thomas Monjalon To: Joyce Kong Cc: dev@dpdk.org, nd@arm.com, jerinj@marvell.com, stephen@networkplumber.org, mb@smartsharesystems.com, honnappa.nagarahalli@arm.com, gavin.hu@arm.com, ravi1.kumar@amd.com, rmody@marvell.com, shshaikh@marvell.com, xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com, adrien.mazarguil@6wind.com Date: Tue, 29 Oct 2019 17:42:37 +0100 Message-ID: <2670371.SxHcXEKB0j@xps> In-Reply-To: <1571799298-18873-1-git-send-email-joyce.kong@arm.com> References: <1571125801-45773-1-git-send-email-joyce.kong@arm.com> <1571799298-18873-1-git-send-email-joyce.kong@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 0/6] implement common rte bit operation APIs in PMDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/10/2019 04:54, Joyce Kong: > There are a lot functions of bit operations scattered in PMDs, > consolidate them into a common API family and applied in different > PMDs to reduce code duplication. Please, could you look at what Adrien did in the Mellanox PMD? http://code.dpdk.org/dpdk/latest/source/drivers/net/mlx5/mlx5_utils.h#L28