From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "A.McLoughlin" <aideen.mcloughlin@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, tero.aho@coriant.com
Subject: Re: [dpdk-dev] [PATCH] net/pcap: fix issue with unnecessary mbufs freeing
Date: Tue, 16 Jul 2019 18:17:57 +0100 [thread overview]
Message-ID: <66d189ec-eb34-f4da-2c11-9a945329e032@intel.com> (raw)
In-Reply-To: <68e988c6-907d-4f59-22b1-2e9d6e825638@intel.com>
On 7/11/2019 3:15 PM, Ferruh Yigit wrote:
> On 7/11/2019 2:59 PM, A.McLoughlin wrote:
>> In the eth_pcap_tx() and eth_pcap_tx_dumper() functions mbufs were freed
>> without incrementing num_tx. To fix the issue, the mbuf freeing was
>> removed as it was not of any benefit.
>>
>> Fixes: 6db141c91e1f ("pcap: support jumbo frames")
>> Cc: stable@dpdk.org
>> Cc: tero.aho@coriant.com
>>
>> Signed-off-by: A.McLoughlin <aideen.mcloughlin@intel.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> (It may be good to mention PMD was freeing the mbuf without notifying the app,
> which may lead double freeing of the mbuf (crash) or app using invalid mbuf.
> I will add while merging.)
>
Applied to dpdk-next-net/master, thanks.
next prev parent reply other threads:[~2019-07-16 17:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 13:59 [dpdk-dev] [PATCH] net/pcap: fix issue with unnecessary mbufs freeing A.McLoughlin
2019-07-11 14:15 ` Ferruh Yigit
2019-07-16 17:17 ` Ferruh Yigit [this message]
2019-07-24 7:15 ` [dpdk-dev] [dpdk-stable] " David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66d189ec-eb34-f4da-2c11-9a945329e032@intel.com \
--to=ferruh.yigit@intel.com \
--cc=aideen.mcloughlin@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=tero.aho@coriant.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).