From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Shreyansh Jain <shreyansh.jain@nxp.com>, ferruh.yigit@intel.com
Cc: dev@dpdk.org, hemant.agrawal@nxp.com, nipun.gupta@nxp.com,
akhil.goyal@nxp.com
Subject: Re: [RESEND v2 2/7] mempool/dpaa2: change to dynamic logging
Date: Wed, 21 Mar 2018 11:57:58 +0530 [thread overview]
Message-ID: <75a5309c-a3ff-135f-7756-b50220b4c74e@nxp.com> (raw)
In-Reply-To: <20180313054431.19556-3-shreyansh.jain@nxp.com>
Hi Shreyansh,
On 3/13/2018 11:14 AM, Shreyansh Jain wrote:
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> ---
> drivers/mempool/dpaa2/Makefile | 6 ---
> drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 60 +++++++++++++++++----------
> drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h | 38 +++++++++++++++++
> 3 files changed, 75 insertions(+), 29 deletions(-)
> create mode 100644 drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h
>
> <snip> ..
diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
> index 1a618ae1b..6e8b7068e 100644
> --- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
> +++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
> @@ -27,10 +27,14 @@
> #include <portal/dpaa2_hw_pvt.h>
> #include <portal/dpaa2_hw_dpio.h>
> #include "dpaa2_hw_mempool.h"
> +#include "dpaa2_hw_mempool_logs.h"
>
> struct dpaa2_bp_info rte_dpaa2_bpid_info[MAX_BPID];
> static struct dpaa2_bp_list *h_bp_list;
>
> +/* Dynamic logging identified for mempool */
> +int dpaa2_logtype_mempool;
> +
> static int
> rte_hw_mbuf_create_pool(struct rte_mempool *mp)
> {
> @@ -44,30 +48,30 @@ rte_hw_mbuf_create_pool(struct rte_mempool *mp)
> avail_dpbp = dpaa2_alloc_dpbp_dev();
>
> if (!avail_dpbp) {
> - PMD_DRV_LOG(ERR, "DPAA2 resources not available");
> + DPAA2_MEMPOOL_ERR("DPAA2 resources not available");
Can you change it to "DPAA2 pool not available ..."
> <snip> ..
>
> @@ -280,8 +284,8 @@ rte_dpaa2_mbuf_alloc_bulk(struct rte_mempool *pool,
> * in pool, qbman_swp_acquire returns 0
> */
> if (ret <= 0) {
> - PMD_TX_LOG(ERR, "Buffer acquire failed with"
> - " err code: %d", ret);
> + DPAA2_MEMPOOL_ERR("Buffer acquire failed with"
> + " err code: %d", ret);
> /* The API expect the exact number of requested bufs */
> /* Releasing all buffers allocated */
> rte_dpaa2_mbuf_release(pool, obj_table, bpid,
> @@ -293,7 +297,8 @@ rte_dpaa2_mbuf_alloc_bulk(struct rte_mempool *pool,
> DPAA2_MODIFY_IOVA_TO_VADDR(bufs[i], size_t);
> obj_table[n] = (struct rte_mbuf *)
> (bufs[i] - bp_info->meta_data_size);
> - PMD_TX_LOG(DEBUG, "Acquired %p address %p from BMAN",
> + DPAA2_MEMPOOL_DP_DEBUG(
> + "Acquired %p address %p from BMAN\n",
> (void *)bufs[i], (void *)obj_table[n]);
> n++;
> }
> @@ -301,8 +306,8 @@ rte_dpaa2_mbuf_alloc_bulk(struct rte_mempool *pool,
>
> #ifdef RTE_LIBRTE_DPAA2_DEBUG_DRIVER
you have maintained "RTE_LIBRTE_DPAA2_DEBUG_DRIVER" flag here, but you
are removing it in next patch from config?
next prev parent reply other threads:[~2018-03-21 6:28 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 9:25 [PATCH 0/7] Change DPAA2 to dynamic logging Shreyansh Jain
2018-03-12 9:25 ` [PATCH 1/7] bus/fslmc: change " Shreyansh Jain
2018-03-12 9:25 ` [PATCH 2/7] mempool/dpaa2: " Shreyansh Jain
2018-03-12 9:25 ` [PATCH 3/7] net/dpaa2: change into " Shreyansh Jain
2018-03-12 11:04 ` Ferruh Yigit
2018-03-12 12:01 ` Shreyansh Jain
2018-03-12 9:25 ` [PATCH 4/7] event/dpaa2: change to " Shreyansh Jain
2018-03-12 9:25 ` [PATCH 5/7] bus/fslmc: remove unused debug macros Shreyansh Jain
2018-03-12 9:25 ` [PATCH 6/7] crypto/dpaa2_sec: fix incorrect debugging prints Shreyansh Jain
2018-03-12 9:25 ` [PATCH 7/7] crypto/dpaa2_sec: change to dynamic logging Shreyansh Jain
2018-03-12 12:10 ` [PATCH 0/7] Change DPAA2 " Hemant Agrawal
2018-03-12 12:37 ` Shreyansh Jain
2018-03-13 5:44 ` [RESEND v2 " Shreyansh Jain
2018-03-13 5:44 ` [RESEND v2 1/7] bus/fslmc: change " Shreyansh Jain
2018-03-21 6:24 ` Hemant Agrawal
2018-03-13 5:44 ` [RESEND v2 2/7] mempool/dpaa2: " Shreyansh Jain
2018-03-21 6:27 ` Hemant Agrawal [this message]
2018-03-13 5:44 ` [RESEND v2 3/7] net/dpaa2: change into " Shreyansh Jain
2018-03-21 6:31 ` Hemant Agrawal
2018-03-23 7:19 ` Shreyansh Jain
2018-03-13 5:44 ` [RESEND v2 4/7] event/dpaa2: change to " Shreyansh Jain
2018-03-14 4:01 ` Nipun Gupta
2018-03-13 5:44 ` [RESEND v2 5/7] bus/fslmc: remove unused debug macros Shreyansh Jain
2018-03-21 6:13 ` Hemant Agrawal
2018-03-13 5:44 ` [RESEND v2 6/7] crypto/dpaa2_sec: fix incorrect debugging prints Shreyansh Jain
2018-03-21 6:12 ` Hemant Agrawal
2018-03-13 5:44 ` [RESEND v2 7/7] crypto/dpaa2_sec: change to dynamic logging Shreyansh Jain
2018-03-21 6:18 ` Hemant Agrawal
2018-03-23 12:04 ` [PATCH v3 0/7] Change DPAA2 " Shreyansh Jain
2018-03-23 12:04 ` [PATCH v3 1/7] bus/fslmc: change " Shreyansh Jain
2018-03-23 12:04 ` [PATCH v3 2/7] mempool/dpaa2: " Shreyansh Jain
2018-03-26 8:48 ` Hemant Agrawal
2018-03-23 12:04 ` [PATCH v3 3/7] net/dpaa2: change into " Shreyansh Jain
2018-03-26 8:48 ` Hemant Agrawal
2018-03-29 15:26 ` Thomas Monjalon
2018-03-29 18:01 ` Shreyansh Jain
2018-03-23 12:04 ` [PATCH v3 4/7] event/dpaa2: change to " Shreyansh Jain
2018-03-23 12:04 ` [PATCH v3 5/7] bus/fslmc: remove unused debug macros Shreyansh Jain
2018-03-23 12:04 ` [PATCH v3 6/7] crypto/dpaa2_sec: fix incorrect debugging prints Shreyansh Jain
2018-03-23 12:04 ` [PATCH v3 7/7] crypto/dpaa2_sec: change to dynamic logging Shreyansh Jain
2018-04-02 14:05 ` [PATCH v4 0/7] Change DPAA2 " Shreyansh Jain
2018-04-02 14:05 ` [PATCH v4 1/7] bus/fslmc: change " Shreyansh Jain
2019-12-03 15:35 ` [dpdk-dev] " Ferruh Yigit
2018-04-02 14:05 ` [PATCH v4 2/7] mempool/dpaa2: " Shreyansh Jain
2018-04-02 14:05 ` [PATCH v4 3/7] net/dpaa2: change into " Shreyansh Jain
2018-04-02 14:05 ` [PATCH v4 4/7] event/dpaa2: change to " Shreyansh Jain
2018-04-02 14:05 ` [PATCH v4 5/7] bus/fslmc: remove unused debug macros Shreyansh Jain
2018-04-02 14:06 ` [PATCH v4 6/7] crypto/dpaa2_sec: fix incorrect debugging prints Shreyansh Jain
2018-04-02 14:06 ` [PATCH v4 7/7] crypto/dpaa2_sec: change to dynamic logging Shreyansh Jain
2018-04-02 22:03 ` [PATCH v4 0/7] Change DPAA2 " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75a5309c-a3ff-135f-7756-b50220b4c74e@nxp.com \
--to=hemant.agrawal@nxp.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=nipun.gupta@nxp.com \
--cc=shreyansh.jain@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).