dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"viveksharma@marvell.com" <viveksharma@marvell.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "intoviveksharma@gmail.com" <intoviveksharma@gmail.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip offload
Date: Tue, 23 Jul 2019 09:07:43 +0000	[thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C260DD342E@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <dc3ef1a1-e01f-43f1-d361-2dd5e18bb191@intel.com>

Hi Ferruh,

<snip>

> >> Duplication is bad, it is bad to have two different ways to do same thing.
> >> I am not sure if Vivek is aware of duplicated functions but
> >> explicitly prefers to update old versions.
> >> I suggest lets stop improving these ones and get rid of them asap.
> >
> > Testpmd is widely used so removing commands without notice will
> probably not go down too well with the community.
> 
> We can make sure release notes is updated for removed commands and
> what is replacing them, also can have same thing in the commit log, these can
> help user.
> 
> But I am dubious to follow deprecation process for testpmd commands.

<snip>

More opinions are probably needed on removing testpmd commands.

Regards,

Bernard

      reply	other threads:[~2019-07-23  9:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-17  7:45 [dpdk-dev] [PATCH] app/testpmd: support QinQ strip offload viveksharma
2019-07-17 13:49 ` Iremonger, Bernard
2019-07-19 16:53 ` Ferruh Yigit
2019-07-22 12:04   ` Iremonger, Bernard
2019-07-22 14:26     ` Ferruh Yigit
2019-07-22 14:55       ` Iremonger, Bernard
2019-07-22 15:40         ` Ferruh Yigit
2019-07-22 17:03           ` Iremonger, Bernard
2019-07-22 17:16             ` Ferruh Yigit
2019-07-23  9:07               ` Iremonger, Bernard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CEF83825BEC744B83065625E567D7C260DD342E@IRSMSX108.ger.corp.intel.com \
    --to=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=intoviveksharma@gmail.com \
    --cc=viveksharma@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).