From: Rasesh Mody <rmody@marvell.com>
To: David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
Shahed Shaikh <shshaikh@marvell.com>
Subject: Re: [dpdk-dev] [EXT] [PATCH] net/qede: remove interrupt reconfigure in handler
Date: Tue, 25 Jun 2019 22:50:29 +0000 [thread overview]
Message-ID: <BYAPR18MB2838082331F405138B954784B5E30@BYAPR18MB2838.namprd18.prod.outlook.com> (raw)
In-Reply-To: <1561469937-16077-1-git-send-email-david.marchand@redhat.com>
>From: David Marchand <david.marchand@redhat.com>
>Sent: Tuesday, June 25, 2019 6:39 AM
>
>----------------------------------------------------------------------
>rte_intr_enable/rte_intr_disable configure the interrupt context on the
>kernel side (either uio or vfio).
>In VFIO case, calling it from the interrupt handlers triggers an unneeded
>interrupt handlers reconfiguration.
>During this reconfiguration window, the device can trigger interrupts which
>are left unserviced.
>
>Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1654824
>Fixes: 245aec289338 ("net/qede: fix legacy interrupt mode")
>Fixes: 2ea6f76aff40 ("qede: add core driver")
>Cc: stable@dpdk.org
>
>Signed-off-by: David Marchand <david.marchand@redhat.com>
>---
Change looks good, thanks.
Acked-by: Rasesh Mody <rmody@marvell.com>
> drivers/net/qede/qede_ethdev.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
>diff --git a/drivers/net/qede/qede_ethdev.c
>b/drivers/net/qede/qede_ethdev.c index 82363e6..807016a 100644
>--- a/drivers/net/qede/qede_ethdev.c
>+++ b/drivers/net/qede/qede_ethdev.c
>@@ -245,12 +245,8 @@ static void qede_interrupt_action(struct ecore_hwfn
>*p_hwfn)
>
> /* Check if our device actually raised an interrupt */
> status =
>ecore_int_igu_read_sisr_reg(ECORE_LEADING_HWFN(edev));
>- if (status & 0x1) {
>+ if (status & 0x1)
> qede_interrupt_action(ECORE_LEADING_HWFN(edev));
>-
>- if (rte_intr_enable(eth_dev->intr_handle))
>- DP_ERR(edev, "rte_intr_enable failed\n");
>- }
> }
>
> static void
>@@ -261,8 +257,6 @@ static void qede_interrupt_action(struct ecore_hwfn
>*p_hwfn)
> struct ecore_dev *edev = &qdev->edev;
>
> qede_interrupt_action(ECORE_LEADING_HWFN(edev));
>- if (rte_intr_enable(eth_dev->intr_handle))
>- DP_ERR(edev, "rte_intr_enable failed\n");
> }
>
> static void
>--
>1.8.3.1
next prev parent reply other threads:[~2019-06-25 22:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 13:38 [dpdk-dev] [PATCH] net/qede: remove interrupt reconfigure in handler David Marchand
2019-06-25 22:50 ` Rasesh Mody [this message]
2019-06-26 7:37 ` [dpdk-dev] [EXT] " David Marchand
2019-07-01 9:15 ` Shahed Shaikh
2019-07-01 9:24 ` [dpdk-dev] [dpdk-stable] " David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR18MB2838082331F405138B954784B5E30@BYAPR18MB2838.namprd18.prod.outlook.com \
--to=rmody@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=shshaikh@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).