From: David Marchand <david.marchand@redhat.com>
To: Arnon Warshavsky <arnon@qwilt.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
Stephen Hemminger <stephen@networkplumber.org>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4] eal: remove non-thread panic calls from init sequence
Date: Thu, 6 Jun 2019 10:03:13 +0200 [thread overview]
Message-ID: <CAJFAV8xCwqx5Po0cnpUsPTh7VFaR4jMZ3VFoVQC7Pd6uYwq5UQ@mail.gmail.com> (raw)
In-Reply-To: <CAKy9EB0Mx1LH-PpPkWQTCmwowCTz_qgQthbJZrsCb80LAxwtiQ@mail.gmail.com>
On Wed, Jun 5, 2019 at 5:44 PM Arnon Warshavsky <arnon@qwilt.com> wrote:
> On Wed, Jun 5, 2019 at 10:50 AM David Marchand <david.marchand@redhat.com>
wrote:
>> On Tue, Jun 4, 2019 at 5:45 PM Arnon Warshavsky <arnon@qwilt.com> wrote:
>>> This patch changes some void functions to return a value,
>>> so that the init sequence may tear down orderly
>>> instead of calling panic.
>>
>> All we care about in this patch are the panics wrt the shared
configuration init.
>> Can the commit title and description refer to this ?
>
> Will remove the non-thread from the title.
> Can you be more specific/ offer your view per the description?
Looking at the git history, how about:
eal: do not panic on shared memory init
--
David Marchand
next prev parent reply other threads:[~2019-06-06 8:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-02 16:54 [dpdk-dev] [PATCH] eal: remove non-thread panic calls from init sequence Arnon Warshavsky
2019-06-03 4:23 ` [dpdk-dev] [PATCH v2] " Arnon Warshavsky
2019-06-03 7:19 ` [dpdk-dev] [PATCH v3] " Arnon Warshavsky
2019-06-03 8:14 ` David Marchand
2019-06-03 14:05 ` Arnon Warshavsky
2019-06-04 15:25 ` [dpdk-dev] [PATCH v4] " Arnon Warshavsky
2019-06-05 7:50 ` David Marchand
2019-06-05 15:43 ` Arnon Warshavsky
2019-06-06 8:03 ` David Marchand [this message]
2019-06-10 7:08 ` [dpdk-dev] [PATCH v5] eal: do not panic on shared memory init Arnon Warshavsky
2019-06-11 8:07 ` David Marchand
2019-06-26 15:08 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xCwqx5Po0cnpUsPTh7VFaR4jMZ3VFoVQC7Pd6uYwq5UQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=arnon@qwilt.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).