From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97A8AC3A589 for ; Tue, 20 Aug 2019 13:08:33 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 240292054F for ; Tue, 20 Aug 2019 13:08:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 240292054F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 78F991BEB5; Tue, 20 Aug 2019 15:08:31 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 6A9201BEB4 for ; Tue, 20 Aug 2019 15:08:30 +0200 (CEST) Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5AC3CC08EC25 for ; Tue, 20 Aug 2019 13:08:29 +0000 (UTC) Received: by mail-vk1-f197.google.com with SMTP id r17so2932672vkd.23 for ; Tue, 20 Aug 2019 06:08:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kqrwDXT/m5fAYSEffAzDTuLcXp70Lf2y8iDtCE9igTc=; b=nqs+6SAp8YmF+qH4ZMI/CvPdDDlEuSxKoFWF4VCGqXYwYmR23qekgf2fjuxXbFxmJI wWasbZFOfPQq1GVWPsDtDZ8hAEL1nljk62ZCWAG53q2bmAghDXSx4jzopPtz9AThbOTx pEWdROJo/eI8kMHAvhgjwzDMBvnr2ImOU6+26I0GxKcEwu70mg23O00qKmIBSG3GqnOD QZCGa+rAhwTBomxK9IunLhdRXk6AqYWcQqx/hVNW92dms+uX1uxjK5PTMMlYJnmh/QUw GkXN6Z4j8OOBiBFKftrVngI6zm9T2Lge4vY0T+nMaCRXloo0UlS0kiKmfGJmx72UnKgz j+YA== X-Gm-Message-State: APjAAAUHjqGyyKNDSGZrT20xFZb1YYkAU6j4abulCN8gsxMqafSknNsA UbFOUREtIM0VoWR+mXfuHsp7TpMVmkVQJF9csQtUq29KyuNDrv5CnJseNXgB+qDH7bsz8Nxzbgs OFQELs/j6+lkMaajTSWs= X-Received: by 2002:a9f:2230:: with SMTP id 45mr16449873uad.87.1566306508499; Tue, 20 Aug 2019 06:08:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqxdhY6xlE2l84pjrm2tHPW473M1iXwEnEfULupVlCBHu7CRwUlJi+4W6nTIycyD/BXeBMPnHqFIqjgLiCwquLs= X-Received: by 2002:a9f:2230:: with SMTP id 45mr16449846uad.87.1566306508012; Tue, 20 Aug 2019 06:08:28 -0700 (PDT) MIME-Version: 1.0 References: <156621948797.9571.17549862831374094643.stgit@jrharri1-skx> <20190820051417.GA12986@___> In-Reply-To: <20190820051417.GA12986@___> From: David Marchand Date: Tue, 20 Aug 2019 15:08:17 +0200 Message-ID: To: Tiwei Bie Cc: Jim Harris , dev , Maxime Coquelin , Zhihong Wang Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] vhost: remove rte_vhost_va_from_guest_pa from map file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Aug 20, 2019 at 7:16 AM Tiwei Bie wrote: > > On Mon, Aug 19, 2019 at 05:58:08AM -0700, Jim Harris wrote: > > This function is declared __rte_always_inline so it > > seems unnecessary to include it in the map file. In > > addition, it was included in the EXPERIMENTAL section > > even though the function itself is not marked > > __rte_experimental. > > > > Found by check-experimental-syms.sh when trying to compile > > DPDK with -finstrument-functions. > > > > Signed-off-by: Jim Harris > > --- > > lib/librte_vhost/rte_vhost_version.map | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_version.map > > index 5f1d4a75c..4908b9b21 100644 > > --- a/lib/librte_vhost/rte_vhost_version.map > > +++ b/lib/librte_vhost/rte_vhost_version.map > > @@ -82,7 +82,6 @@ EXPERIMENTAL { > > rte_vhost_crypto_fetch_requests; > > rte_vhost_crypto_finalize_requests; > > rte_vhost_crypto_set_zero_copy; > > - rte_vhost_va_from_guest_pa; > > rte_vhost_host_notifier_ctrl; > > rte_vdpa_relay_vring_used; > > rte_vhost_extern_callback_register; > > > > It might be better to mark this function with __rte_experimental > to fix the build with -finstrument-functions, as in this way we can > also get warned when using it with ALLOW_EXPERIMENTAL_API undefined. > And we can have another patch to promote it to stable. +1. -- David Marchand