From: "Michel Dänzer" <michel@daenzer.net>
To: Tomasz Figa <tfiga@chromium.org>,
Boris Brezillon <boris.brezillon@collabora.com>
Cc: "Stéphane Marchesin" <marcheu@google.com>,
"Sean Paul" <seanpaul@google.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"Helen Koike" <helen.koike@collabora.com>,
"list@263.net:IOMMU DRIVERS" <iommu@lists.linux-foundation.org>,
kernel@collabora.com, nicholas.kazlauskas@amd.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/5] drm/rockchip: fix fb references in async update
Date: Wed, 13 Mar 2019 10:58:25 +0100 [thread overview]
Message-ID: <05750143-708b-b84e-af67-82ec6815bd89@daenzer.net> (raw)
In-Reply-To: <CAAFQd5CCEDaxLbw0E9NJJ-tEcHd8-Lidvcvt8qfPAnKu7uuj8w@mail.gmail.com>
On 2019-03-13 4:42 a.m., Tomasz Figa wrote:
> On Wed, Mar 13, 2019 at 12:52 AM Boris Brezillon
> <boris.brezillon@collabora.com> wrote:
>>
>> On Tue, 12 Mar 2019 12:34:45 -0300
>> Helen Koike <helen.koike@collabora.com> wrote:
>>
>>> On 3/12/19 3:34 AM, Boris Brezillon wrote:
>>>> On Mon, 11 Mar 2019 23:21:59 -0300
>>>> Helen Koike <helen.koike@collabora.com> wrote:
>>>>
>>>>> In the case of async update, modifications are done in place, i.e. in the
>>>>> current plane state, so the new_state is prepared and the new_state is
>>>>> cleanup up (instead of the old_state, diferrently on what happen in a
>>>>
>>>> ^ cleaned up ^ differently (but maybe
>>>> "unlike what happens" is more appropriate here).
>>>>
>>>>> normal sync update).
>>>>> To cleanup the old_fb properly, it needs to be placed in the new_state
>>>>> in the end of async_update, so cleanup call will unreference the old_fb
>>>>> correctly.
>>>>>
>>>>> Also, the previous code had a:
>>>>>
>>>>> plane_state = plane->funcs->atomic_duplicate_state(plane);
>>>>> ...
>>>>> swap(plane_state, plane->state);
>>>>>
>>>>> if (plane->state->fb && plane->state->fb != new_state->fb) {
>>>>> ...
>>>>> }
>>>>>
>>>>> Which was wrong, as the fb were just assigned to be equal, so this if
>>>>> statement nevers evaluates to true.
>>>>>
>>>>> Another details is that the function drm_crtc_vblank_get() can only be
>>>>> called when vop->is_enabled is true, otherwise it has no effect and
>>>>> trows a WARN_ON().
>>>>>
>>>>> Calling drm_atomic_set_fb_for_plane() (which get a referent of the new
>>>>> fb and pus the old fb) is not required, as it is taken care by
>>>>> drm_mode_cursor_universal() when calling
>>>>> drm_atomic_helper_update_plane().
>>>>>
>>>>> Signed-off-by: Helen Koike <helen.koike@collabora.com>
>>>>>
>>>>> ---
>>>>> Hello,
>>>>>
>>>>> I tested on the rockchip ficus v1.1 using igt plane_cursor_legacy and
>>>>> kms_cursor_legacy and I didn't see any regressions.
>>>>>
>>>>> Changes in v2: None
>>>>>
>>>>> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 42 ++++++++++++---------
>>>>> 1 file changed, 24 insertions(+), 18 deletions(-)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
>>>>> index c7d4c6073ea5..a1ee8c156a7b 100644
>>>>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
>>>>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
>>>>> @@ -912,30 +912,31 @@ static void vop_plane_atomic_async_update(struct drm_plane *plane,
>>>>> struct drm_plane_state *new_state)
>>>>> {
>>>>> struct vop *vop = to_vop(plane->state->crtc);
>>>>> - struct drm_plane_state *plane_state;
>>>>> + struct drm_framebuffer *old_fb = plane->state->fb;
>>>>>
>>>>> - plane_state = plane->funcs->atomic_duplicate_state(plane);
>>>>> - plane_state->crtc_x = new_state->crtc_x;
>>>>> - plane_state->crtc_y = new_state->crtc_y;
>>>>> - plane_state->crtc_h = new_state->crtc_h;
>>>>> - plane_state->crtc_w = new_state->crtc_w;
>>>>> - plane_state->src_x = new_state->src_x;
>>>>> - plane_state->src_y = new_state->src_y;
>>>>> - plane_state->src_h = new_state->src_h;
>>>>> - plane_state->src_w = new_state->src_w;
>>>>> -
>>>>> - if (plane_state->fb != new_state->fb)
>>>>> - drm_atomic_set_fb_for_plane(plane_state, new_state->fb);
>>>>> -
>>>>> - swap(plane_state, plane->state);
>>>>> -
>>>>> - if (plane->state->fb && plane->state->fb != new_state->fb) {
>>>>> + /*
>>>>> + * A scanout can still be occurring, so we can't drop the reference to
>>>>> + * the old framebuffer. To solve this we get a reference to old_fb and
>>>>> + * set a worker to release it later.
>>>>
>>>> Hm, doesn't look like an async update to me if we have to wait for the
>>>> next VBLANK to happen to get the new content on the screen. Maybe we
>>>> should reject async updates when old_fb != new_fb in the rk
>>>> ->async_check() hook.
>>>
>>> Unless I am misunderstanding this, we don't wait here, we just grab a
>>> reference to the fb in case it is being still used by the hw, so it
>>> doesn't get released prematurely.
>>
>> I was just reacting to the comment that says the new FB should stay
>> around until the next VBLANK event happens. If the FB must stay around
>> that probably means the HW is still using, which made me wonder if this
>> HW actually supports async update (where async means "update now and
>> don't care about about tearing"). Or maybe it takes some time to switch
>> to the new FB and waiting for the next VBLANK to release the old FB was
>> an easy solution to not wait for the flip to actually happen in
>> ->async_update() (which is kind of a combination of async+non-blocking).
>
> The hardware switches framebuffers on vblank, so whatever framebuffer
> is currently being scanned out from needs to stay there until the
> hardware switches to the new one in shadow registers. If that doesn't
> happen, you get IOMMU faults and the display controller stops working
> since we don't have any fault handling currently, just printing a
> message.
Sounds like your hardware doesn't actually support async flips. It's
probably better for the driver not to pretend otherwise.
--
Earthling Michel Dänzer | https://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-03-13 9:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 2:21 [PATCH v2 0/5] drm: Fix fb changes for async updates Helen Koike
2019-03-12 2:21 ` [PATCH v2 1/5] drm/rockchip: fix fb references in async update Helen Koike
2019-03-12 6:34 ` Boris Brezillon
2019-03-12 11:04 ` Daniel Vetter
2019-03-12 15:34 ` Helen Koike
2019-03-12 15:52 ` Boris Brezillon
2019-03-13 3:42 ` Tomasz Figa
2019-03-13 9:58 ` Michel Dänzer [this message]
2019-03-13 18:08 ` Helen Koike
[not found] ` <ed44e1f4-07da-b1cb-b5cb-d34d29758502-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-03-14 9:15 ` Michel Dänzer
2019-03-14 17:51 ` Helen Koike
2019-03-15 10:11 ` Michel Dänzer
2019-03-15 10:25 ` Boris Brezillon
2019-03-15 11:29 ` Michel Dänzer
2019-03-15 16:54 ` Helen Koike
[not found] ` <20190312022204.2775-1-helen.koike-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-03-12 2:22 ` [PATCH v2 2/5] drm/amd: " Helen Koike
2019-03-12 2:22 ` [PATCH v2 3/5] drm/msm: " Helen Koike
2019-03-12 2:22 ` [PATCH v2 4/5] drm/vc4: " Helen Koike
2019-03-25 0:38 ` Sasha Levin
2019-03-12 2:22 ` [PATCH v2 5/5] drm: don't block fb changes for async plane updates Helen Koike
2019-03-12 6:44 ` Boris Brezillon
2019-03-12 12:49 ` Kazlauskas, Nicholas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05750143-708b-b84e-af67-82ec6815bd89@daenzer.net \
--to=michel@daenzer.net \
--cc=airlied@linux.ie \
--cc=boris.brezillon@collabora.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=helen.koike@collabora.com \
--cc=iommu@lists.linux-foundation.org \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=marcheu@google.com \
--cc=nicholas.kazlauskas@amd.com \
--cc=seanpaul@google.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).