From: Neil Armstrong <narmstrong@baylibre.com>
To: daniel@ffwll.ch, dri-devel@lists.freedesktop.org
Cc: mjourdan@baylibre.com, linux-kernel@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 6/7] drm/meson: overlay: setup overlay for Amlogic FBC Memory Saving mode
Date: Tue, 24 Mar 2020 15:24:17 +0100 [thread overview]
Message-ID: <1bb8c27c-7dcf-8833-ee13-f7227336179b@baylibre.com> (raw)
In-Reply-To: <20200324142016.31824-7-narmstrong@baylibre.com>
On 24/03/2020 15:20, Neil Armstrong wrote:
> Setup the Amlogic FBC decoder for the VD1 video overlay plane to use
> a different superblock size for the Memory Saving mode.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> drivers/gpu/drm/meson/meson_overlay.c | 14 ++++++++++++--
> include/uapi/drm/drm_fourcc.h | 16 +++++++++++++++-
> 2 files changed, 27 insertions(+), 3 deletions(-)
>
[...]
> --- a/include/uapi/drm/drm_fourcc.h
> +++ b/include/uapi/drm/drm_fourcc.h
> @@ -840,6 +840,19 @@ extern "C" {
> */
> #define DRM_FORMAT_MOD_AMLOGIC_FBC_LAYOUT_BASIC (1ULL << 0)
>
> +/*
> + * Amlogic FBC Scatter Memory layout
> + *
> + * Indicates the header contains IOMMU references to the compressed
> + * frames content to optimize memory access and layout.
> + *
> + * In this mode, only the header memory address is needed, thus the
> + * content memory organization is tied to the current producer
> + * execution and cannot be saved/dumped neither transferrable between
> + * Amlogic SoCs supporting this modifier.
> + */
> +#define DRM_FORMAT_MOD_AMLOGIC_FBC_LAYOUT_SCATTER (2ULL << 0)
> +
> /*
> * Amlogic FBC Layout Options
> */
> @@ -852,7 +865,8 @@ extern "C" {
> * memory.
> *
> * This mode reduces body layout to 3072 bytes per 64x32 superblock with
> - * the basic layout.
> + * the basic layout and 3200 bytes per 64x32 superblock combined with
> + * the scatter layout.
> */
> #define DRM_FORMAT_MOD_AMLOGIC_FBC_MEM_SAVING (1ULL << 8)
>
>
Oops a commit got lost in the process... this change should be independent.
Neil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-24 14:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 14:20 [PATCH v3 0/7] drm/meson: add support for Amlogic Video FBC Neil Armstrong
2020-03-24 14:20 ` [PATCH v3 1/7] drm/fourcc: Add modifier definitions for describing Amlogic Video Framebuffer Compression Neil Armstrong
2020-03-24 14:20 ` [PATCH v3 2/7] drm/meson: add Amlogic Video FBC registers Neil Armstrong
2020-03-24 14:20 ` [PATCH v3 3/7] drm/meson: overlay: setup overlay for Amlogic FBC Neil Armstrong
2020-03-24 14:20 ` [PATCH v3 4/7] drm/meson: crtc: handle commit of Amlogic FBC frames Neil Armstrong
2020-03-24 14:20 ` [PATCH v3 5/7] drm/fourcc: amlogic: Add modifier definitions for Memory Saving option Neil Armstrong
2020-03-24 14:20 ` [PATCH v3 6/7] drm/meson: overlay: setup overlay for Amlogic FBC Memory Saving mode Neil Armstrong
2020-03-24 14:24 ` Neil Armstrong [this message]
2020-03-24 14:20 ` [PATCH v3 7/7] drm/meson: overlay: setup overlay for Amlogic FBC Scatter Memory layout Neil Armstrong
2020-03-24 22:07 ` [PATCH v3 0/7] drm/meson: add support for Amlogic Video FBC Kevin Hilman
2020-03-25 8:50 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bb8c27c-7dcf-8833-ee13-f7227336179b@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjourdan@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).