From: Daniel Vetter <daniel@ffwll.ch>
To: Archit Taneja <architt@codeaurora.org>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 00/25] drm: fb emulation: Step 1: Create new drm_fb_helper wrapper funcs
Date: Wed, 22 Jul 2015 09:41:04 +0200 [thread overview]
Message-ID: <20150722074104.GU16722@phenom.ffwll.local> (raw)
In-Reply-To: <1437548401-10125-1-git-send-email-architt@codeaurora.org>
On Wed, Jul 22, 2015 at 12:29:36PM +0530, Archit Taneja wrote:
> DRM drivers using drm_fb_helpers still call some fbdev core functions.
> This makes the driver depend on CONFIG_FB, resulting in complicated
> Kconfig options, and preventing us from creating a top level drm config
> option to enable/disable FBDEV emulation.
>
> Create new drm_fb_helper functions that replace these fbdev functions.
>
> In most cases, the new helper funcs simply wrap around the original fbdev
> functions. For a few (like framebufer_alloc), we actually do some work
> that is currently redundant across multiple drivers.
>
> With these patches, the drivers don't call any fbdev functions directly.
> They are now called through functions in drm_fb_helper.c. We will later
> create a fbdev emulation config option to stub out the fb helpers.
>
> The only exception is vmwgfx driver. This doesn't use drm_fb_helper. It
> creates a fb device how a driver in drivers/video/fbdev would. Maybe this
> needs to be converted to use drm_fb_helpers.
>
> For more info, have a look at the threads:
> http://lists.freedesktop.org/archives/dri-devel/2015-March/078729.html
> http://lists.freedesktop.org/archives/dri-devel/2015-March/078975.html
>
> v2:
> - Remove if (info) checks in fb_sys functions
> - Use 'if (fb_helper && fb_helper->fbdev)' checks where appropriate
> - Add kerneldocs for the new helper funcs
> - Follow drm way of aligning of arguments in func definitions
> - Fixed build error in drm/virtio
> - Fixed error cleanup path in drm/tegra
> - Fixed build error in drm/rockchip
> - Fixed return issue in drm/amdgpu
> - Fixed 'unused variable' warnings in bochs, ast, udl and radeon
> - Fixed stray goto labels in cirrus, exynos, mgag
When resending patches please also have changelogs per-patch, not just in
the cover letter. Otherwise you have to constantly jump back&forth.
Also I'd drop the compile tested only from patches, just adds noise.
-Daniel
>
> Archit Taneja (25):
> drm/fb_helper: Add drm_fb_helper functions to manage fb_info creation
> drm/fb_helper: Create a wrapper for unlink_framebuffer
> drm/fb_helper: Create wrappers for fb_sys_read/write funcs
> drm/fb_helper: Create wrappers for blit, copyarea and fillrect funcs
> drm/fb_helper: Create a wrapper for fb_set_suspend
> drm/fb_helper: Create a wrapper for remove_conflicting_framebuffers
> drm/cirrus: Use new drm_fb_helper functions
> drm/rockchip: Use new drm_fb_helper functions
> drm/armada: Use new drm_fb_helper functions
> drm/ast: Use new drm_fb_helper functions
> drm/omap: Use new drm_fb_helper functions
> drm/tegra: Use new drm_fb_helper functions
> drm/msm: Use new drm_fb_helper functions
> drm/exynos: Use new drm_fb_helper functions
> drm/gma500: Use new drm_fb_helper functions
> drm/mgag200: Use new drm_fb_helper functions
> drm/radeon: Use new drm_fb_helper functions
> drm/qxl: Use new drm_fb_helper functions
> drm/i915: Use new drm_fb_helper functions
> drm/nouveau: Use new drm_fb_helper functions
> drm/udl: Use new drm_fb_helper functions
> drm/bochs: Use new drm_fb_helper functions
> drm/amdgpu: Use new drm_fb_helper functions
> drm/virtio: Use new drm_fb_helper functions
> drm/fb_cma_helper: Use new drm_fb_helper functions
>
> drivers/gpu/drm/Kconfig | 7 +
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 45 ++----
> drivers/gpu/drm/armada/armada_fbdev.c | 33 ++--
> drivers/gpu/drm/ast/ast_fb.c | 48 ++----
> drivers/gpu/drm/bochs/bochs_drv.c | 6 +-
> drivers/gpu/drm/bochs/bochs_fbdev.c | 36 ++---
> drivers/gpu/drm/cirrus/cirrus_drv.c | 7 +-
> drivers/gpu/drm/cirrus/cirrus_fbdev.c | 41 +----
> drivers/gpu/drm/drm_fb_cma_helper.c | 45 ++----
> drivers/gpu/drm/drm_fb_helper.c | 225 ++++++++++++++++++++++++++
> drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 47 ++----
> drivers/gpu/drm/gma500/accel_2d.c | 6 +-
> drivers/gpu/drm/gma500/framebuffer.c | 48 ++----
> drivers/gpu/drm/i915/i915_dma.c | 3 +-
> drivers/gpu/drm/i915/intel_fbdev.c | 40 ++---
> drivers/gpu/drm/mgag200/mgag200_drv.c | 3 +-
> drivers/gpu/drm/mgag200/mgag200_fb.c | 39 +----
> drivers/gpu/drm/mgag200/mgag200_main.c | 2 +-
> drivers/gpu/drm/msm/msm_fbdev.c | 34 ++--
> drivers/gpu/drm/nouveau/nouveau_drm.c | 3 +-
> drivers/gpu/drm/nouveau/nouveau_fbcon.c | 39 ++---
> drivers/gpu/drm/omapdrm/omap_fbdev.c | 34 ++--
> drivers/gpu/drm/qxl/qxl_fb.c | 40 ++---
> drivers/gpu/drm/radeon/radeon_drv.c | 4 +-
> drivers/gpu/drm/radeon/radeon_fb.c | 42 ++---
> drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 47 ++----
> drivers/gpu/drm/tegra/fb.c | 35 ++--
> drivers/gpu/drm/udl/udl_fb.c | 41 ++---
> drivers/gpu/drm/virtio/virtgpu_drm_bus.c | 3 +-
> drivers/gpu/drm/virtio/virtgpu_drv.h | 1 +
> drivers/gpu/drm/virtio/virtgpu_fb.c | 32 ++--
> include/drm/drm_fb_helper.h | 31 ++++
> 33 files changed, 508 insertions(+), 563 deletions(-)
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-07-22 7:38 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 6:37 [PATCH 00/25] drm: fb emulation: Step 1: Create new drm_fb_helper wrapper funcs Archit Taneja
2015-07-13 6:37 ` [PATCH 01/25] drm/fb_helper: Add drm_fb_helper functions to manage fb_info creation Archit Taneja
2015-07-13 6:37 ` [PATCH 02/25] drm/fb_helper: Create a wrapper for unlink_framebuffer Archit Taneja
2015-07-13 7:30 ` Daniel Vetter
2015-07-13 6:37 ` [PATCH 03/25] drm/fb_helper: Create wrappers for fb_sys_read/write funcs Archit Taneja
2015-07-13 7:31 ` Daniel Vetter
2015-07-13 9:59 ` Archit Taneja
2015-07-13 7:39 ` Daniel Vetter
2015-07-13 6:38 ` [PATCH 04/25] drm/fb_helper: Create wrappers for blit, copyarea and fillrect funcs Archit Taneja
2015-07-13 7:40 ` Daniel Vetter
2015-07-13 6:38 ` [PATCH 05/25] drm/fb_helper: Create a wrapper for fb_set_suspend Archit Taneja
2015-07-13 6:38 ` [PATCH 06/25] drm/fb_helper: Create a wrapper for remove_conflicting_framebuffers Archit Taneja
2015-07-13 6:38 ` [PATCH 07/25] drm/cirrus: Use new drm_fb_helper functions Archit Taneja
2015-07-13 6:38 ` [PATCH 08/25] drm/rockchip: " Archit Taneja
2015-07-13 6:38 ` [PATCH 09/25] drm/armada: " Archit Taneja
2015-07-13 6:38 ` [PATCH 10/25] drm/ast: " Archit Taneja
2015-07-13 6:38 ` [PATCH 11/25] drm/omap: " Archit Taneja
2015-07-13 6:38 ` [PATCH 12/25] drm/tegra: " Archit Taneja
2015-07-14 8:50 ` Thierry Reding
2015-07-14 9:11 ` Archit Taneja
2015-07-13 6:38 ` [PATCH 13/25] drm/msm: " Archit Taneja
2015-07-13 6:38 ` [PATCH 14/25] drm/exynos: " Archit Taneja
2015-08-11 9:04 ` Inki Dae
2015-08-11 9:11 ` Inki Dae
2015-07-13 6:38 ` [PATCH 15/25] drm/gma500: " Archit Taneja
2015-07-13 6:38 ` [PATCH 16/25] drm/mgag200: " Archit Taneja
2015-07-13 6:38 ` [PATCH 17/25] drm/radeon: " Archit Taneja
2015-07-13 6:38 ` [PATCH 18/25] drm/qxl: " Archit Taneja
2015-07-13 6:38 ` [PATCH 19/25] drm/i915: " Archit Taneja
2015-07-13 6:38 ` [PATCH 20/25] drm/nouveau: " Archit Taneja
2015-07-13 6:38 ` [PATCH 21/25] drm/udl: " Archit Taneja
2015-07-13 6:38 ` [PATCH 22/25] drm/boschs: " Archit Taneja
2015-07-13 6:38 ` [PATCH 23/25] drm/amdgpu: " Archit Taneja
2015-07-13 6:38 ` [PATCH 24/25] drm/virtio: " Archit Taneja
2015-07-13 6:38 ` [PATCH 25/25] drm/fb_cma_helper: " Archit Taneja
2015-07-13 8:07 ` [PATCH 00/25] drm: fb emulation: Step 1: Create new drm_fb_helper wrapper funcs Daniel Vetter
2015-07-13 10:29 ` Archit Taneja
2015-07-13 14:11 ` Daniel Vetter
2015-07-13 15:25 ` Alex Deucher
2015-07-22 6:59 ` [PATCH v2 " Archit Taneja
2015-07-22 6:59 ` [PATCH v2 01/25] drm/fb_helper: Add drm_fb_helper functions to manage fb_info creation Archit Taneja
2015-07-22 6:59 ` [PATCH v2 02/25] drm/fb_helper: Create a wrapper for unlink_framebuffer Archit Taneja
2015-07-22 6:59 ` [PATCH v2 03/25] drm/fb_helper: Create wrappers for fb_sys_read/write funcs Archit Taneja
2015-07-22 6:59 ` [PATCH v2 04/25] drm/fb_helper: Create wrappers for blit, copyarea and fillrect funcs Archit Taneja
2015-07-22 6:59 ` [PATCH v2 05/25] drm/fb_helper: Create a wrapper for fb_set_suspend Archit Taneja
2015-07-22 6:59 ` [PATCH v2 06/25] drm/fb_helper: Create a wrapper for remove_conflicting_framebuffers Archit Taneja
2015-07-22 6:59 ` [PATCH v2 07/25] drm/cirrus: Use new drm_fb_helper functions Archit Taneja
2015-07-22 6:59 ` [PATCH v2 08/25] drm/rockchip: " Archit Taneja
2015-07-22 6:59 ` [PATCH v2 09/25] drm/armada: " Archit Taneja
2015-07-22 6:59 ` [PATCH v2 10/25] drm/ast: " Archit Taneja
2015-07-22 6:59 ` [PATCH v2 11/25] drm/omap: " Archit Taneja
2015-07-22 6:59 ` [PATCH v2 12/25] drm/tegra: " Archit Taneja
2015-07-22 6:59 ` [PATCH v2 13/25] drm/msm: " Archit Taneja
2015-07-22 6:59 ` [PATCH v2 14/25] drm/exynos: " Archit Taneja
2015-08-11 12:27 ` Inki Dae
2015-07-22 6:59 ` [PATCH v2 15/25] drm/gma500: " Archit Taneja
2015-07-22 6:59 ` [PATCH v2 16/25] drm/mgag200: " Archit Taneja
2015-07-22 6:59 ` [PATCH v2 17/25] drm/radeon: " Archit Taneja
2015-07-22 6:59 ` [PATCH v2 18/25] drm/qxl: " Archit Taneja
2015-07-22 6:59 ` [PATCH v2 19/25] drm/i915: " Archit Taneja
2015-07-22 6:59 ` [PATCH v2 20/25] drm/nouveau: " Archit Taneja
2015-07-22 6:59 ` [PATCH v2 21/25] drm/udl: " Archit Taneja
2015-07-22 6:59 ` [PATCH v2 22/25] drm/bochs: " Archit Taneja
2015-07-22 6:59 ` [PATCH v2 23/25] drm/amdgpu: " Archit Taneja
2015-07-22 7:00 ` [PATCH v2 24/25] drm/virtio: " Archit Taneja
2015-07-22 7:00 ` [PATCH v2 25/25] drm/fb_cma_helper: " Archit Taneja
2015-07-22 7:41 ` Daniel Vetter [this message]
2015-07-22 8:34 ` [PATCH v2 00/25] drm: fb emulation: Step 1: Create new drm_fb_helper wrapper funcs Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150722074104.GU16722@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=architt@codeaurora.org \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).