From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: rcar-du: Fix build error
Date: Tue, 22 Jan 2019 22:33:25 +0200 [thread overview]
Message-ID: <20190122203325.GC3264@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20190118172125.32504-1-natechancellor@gmail.com>
Hi Nathan,
Thank you for the patch.
On Fri, Jan 18, 2019 at 10:21:25AM -0700, Nathan Chancellor wrote:
> On arm{32,64} allyesconfig builds:
>
> drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c:40:1: error: incomplete result type 'enum drm_mode_status' in function definition
> drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c:47:10: error: incomplete definition of type 'struct drm_display_mode'
> drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c:48:10: error: use of undeclared identifier 'MODE_CLOCK_HIGH'
> drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c:50:9: error: use of undeclared identifier 'MODE_OK'
>
> After the removal of drmP.h from this file and its removal from
> bridge/dw_hdmi.h, these types are not defined anymore, as they
> were implicitly coming into that file through drm_crtc.h.
>
> Fixes: 428747ae5cca ("drm: remove include of drmP.h from bridge/dw_hdmi.h")
> Fixes: 9a47db8e7a9d ("drm: rcar-du: Remove inclusion of drmP.h")
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
This was included by Dave in merge commit f164a94c2c87 ("Merge tag
'drm-misc-next-2019-01-16' of git://anongit.freedesktop.org/drm/drm-misc
into drm-next").
> ---
> drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c b/drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c
> index 0fb25113f19c..452461dc96f2 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c
> @@ -12,6 +12,7 @@
> #include <linux/platform_device.h>
>
> #include <drm/bridge/dw_hdmi.h>
> +#include <drm/drm_modes.h>
>
> #define RCAR_HDMI_PHY_OPMODE_PLLCFG 0x06 /* Mode of operation and PLL dividers */
> #define RCAR_HDMI_PHY_PLLCURRGMPCTRL 0x10 /* PLL current and Gmp (conductance) */
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2019-01-22 20:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 17:21 [PATCH] drm: rcar-du: Fix build error Nathan Chancellor
2019-01-22 20:33 ` Laurent Pinchart [this message]
2020-05-18 20:16 Daniel Gomez
2020-05-19 20:22 ` Emil Velikov
2020-05-22 9:43 ` Kieran Bingham
2020-05-22 10:36 ` Daniel G
2020-05-22 20:23 ` Laurent Pinchart
2020-05-23 9:38 ` Daniel G
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122203325.GC3264@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=natechancellor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).