From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: linux-kernel@vger.kernel.org
Cc: preid@electromag.com.au, nishadkamdar@gmail.com,
bhanusreemahesh@gmail.com, leobras.c@gmail.com,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
devel@driverdev.osuosl.org
Subject: [PATCH] Staging: fbtft: Fix wrong check in fbtft_write_wmem16_bus8()
Date: Mon, 15 Jul 2019 16:30:02 +0200 [thread overview]
Message-ID: <20190715143003.12819-1-nsaenzjulienne@suse.de> (raw)
We actually want to set the gpio pin if it's avilable, not the other way
around.
Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface")
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
---
drivers/staging/fbtft/fbtft-bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
index 2ea814d0dca5..63c65dd67b17 100644
--- a/drivers/staging/fbtft/fbtft-bus.c
+++ b/drivers/staging/fbtft/fbtft-bus.c
@@ -135,7 +135,7 @@ int fbtft_write_vmem16_bus8(struct fbtft_par *par, size_t offset, size_t len)
remain = len / 2;
vmem16 = (u16 *)(par->info->screen_buffer + offset);
- if (!par->gpio.dc)
+ if (par->gpio.dc)
gpiod_set_value(par->gpio.dc, 1);
/* non buffered write */
--
2.22.0
next reply other threads:[~2019-07-15 14:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 14:30 Nicolas Saenz Julienne [this message]
[not found] ` <7b8242ab-cc0c-d90b-60af-ff1c53789e44@opensynergy.com>
2019-07-15 14:58 ` [PATCH] Staging: fbtft: Fix wrong check in,fbtft_write_wmem16_bus8() Jan Sebastian Götte
2019-07-15 15:04 ` [PATCH] Staging: fbtft: Fix GPIO handling Jan Sebastian Götte
2019-07-15 15:14 ` Nicolas Saenz Julienne
2019-07-17 14:41 ` [PATCH v2] " Jan Sebastian Götte
2019-07-25 7:21 ` Greg KH
2019-07-25 7:23 ` Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715143003.12819-1-nsaenzjulienne@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=bhanusreemahesh@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=leobras.c@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nishadkamdar@gmail.com \
--cc=preid@electromag.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).