From: Zhenyu Wang <zhenyuw@linux.intel.com>
To: Julian Stecklina <julian.stecklina@cyberus-technology.de>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
hang.yuan@intel.com, zhiyuan.lv@intel.com,
intel-gvt-dev@lists.freedesktop.org
Subject: Re: [RFC PATCH 2/4] drm/i915/gvt: remove unused vblank_done completion
Date: Mon, 20 Jan 2020 14:23:30 +0800 [thread overview]
Message-ID: <20200120062330.GB14597@zhen-hp.sh.intel.com> (raw)
In-Reply-To: <20200109171357.115936-3-julian.stecklina@cyberus-technology.de>
[-- Attachment #1.1: Type: text/plain, Size: 1748 bytes --]
On 2020.01.09 19:13:55 +0200, Julian Stecklina wrote:
> This variable is used nowhere, so remove it.
>
> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
>
> Signed-off-by: Julian Stecklina <julian.stecklina@cyberus-technology.de>
> ---
Thanks for catching this.
Acked-by: Zhenyu Wang <zhenyuw@linux.intel.com>
> drivers/gpu/drm/i915/gvt/gvt.h | 2 --
> drivers/gpu/drm/i915/gvt/kvmgt.c | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/gvt.h b/drivers/gpu/drm/i915/gvt/gvt.h
> index 2604739e5680..8cf292a8d6bd 100644
> --- a/drivers/gpu/drm/i915/gvt/gvt.h
> +++ b/drivers/gpu/drm/i915/gvt/gvt.h
> @@ -203,8 +203,6 @@ struct intel_vgpu {
> struct mutex dmabuf_lock;
> struct idr object_idr;
>
> - struct completion vblank_done;
> -
> u32 scan_nonprivbb;
> };
>
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index d725a4fb94b9..9a435bc1a2f0 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -1817,8 +1817,6 @@ static int kvmgt_guest_init(struct mdev_device *mdev)
> kvmgt_protect_table_init(info);
> gvt_cache_init(vgpu);
>
> - init_completion(&vgpu->vblank_done);
> -
> info->track_node.track_write = kvmgt_page_track_write;
> info->track_node.track_flush_slot = kvmgt_page_track_flush_slot;
> kvm_page_track_register_notifier(kvm, &info->track_node);
> --
> 2.24.1
>
> _______________________________________________
> intel-gvt-dev mailing list
> intel-gvt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-20 6:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4079ce7c26a2d2a3c7e0828ed1ea6008d6e2c805.camel@cyberus-technology.de>
2020-01-09 17:13 ` [RFC PATCH 0/4] Support for out-of-tree hypervisor modules in i915/gvt Julian Stecklina
2020-01-09 17:13 ` [RFC PATCH 1/4] drm/i915/gvt: make gvt oblivious of kvmgt data structures Julian Stecklina
2020-01-20 6:22 ` Zhenyu Wang
2020-01-20 6:33 ` Zhenyu Wang
2020-01-20 17:25 ` [PATCH] " Julian Stecklina
2020-01-20 17:28 ` [RFC PATCH 1/4] " Julian Stecklina
2020-01-09 17:13 ` [RFC PATCH 2/4] drm/i915/gvt: remove unused vblank_done completion Julian Stecklina
2020-01-20 6:23 ` Zhenyu Wang [this message]
2020-01-09 17:13 ` [RFC PATCH 3/4] drm/i915/gvt: define a public interface to gvt Julian Stecklina
2020-01-09 17:13 ` [RFC PATCH 4/4] drm/i915/gvt: move public gvt headers out into global include Julian Stecklina
2020-01-15 15:22 ` Greg KH
2020-01-16 14:13 ` Julian Stecklina
2020-01-16 14:23 ` Greg KH
2020-01-16 15:05 ` Julian Stecklina
2020-01-16 19:48 ` Greg KH
2020-01-17 2:15 ` Zhenyu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120062330.GB14597@zhen-hp.sh.intel.com \
--to=zhenyuw@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hang.yuan@intel.com \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=julian.stecklina@cyberus-technology.de \
--cc=linux-kernel@vger.kernel.org \
--cc=zhiyuan.lv@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).