From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Wanpeng Li <wanpengli@tencent.com>,
kvm list <kvm@vger.kernel.org>, Joerg Roedel <joro@8bytes.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
Gurchetan Singh <gurchetansingh@chromium.org>,
Gerd Hoffmann <kraxel@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Jim Mattson <jmattson@google.com>
Subject: Re: [RFC PATCH 0/3] KVM: x86: honor guest memory type
Date: Tue, 18 Feb 2020 14:58:09 -0800 [thread overview]
Message-ID: <20200218225809.GL28156@linux.intel.com> (raw)
In-Reply-To: <d3a6fac6-3831-3b8e-09b6-bfff4592f235@redhat.com>
On Tue, Feb 18, 2020 at 05:28:51PM +0100, Paolo Bonzini wrote:
> On 14/02/20 23:03, Sean Christopherson wrote:
> >> On Fri, Feb 14, 2020 at 1:47 PM Chia-I Wu <olvaffe@gmail.com> wrote:
> >>> AFAICT, it is currently allowed on ARM (verified) and AMD (not
> >>> verified, but svm_get_mt_mask returns 0 which supposedly means the NPT
> >>> does not restrict what the guest PAT can do). This diff would do the
> >>> trick for Intel without needing any uapi change:
> >> I would be concerned about Intel CPU errata such as SKX40 and SKX59.
> > The part KVM cares about, #MC, is already addressed by forcing UC for MMIO.
> > The data corruption issue is on the guest kernel to correctly use WC
> > and/or non-temporal writes.
>
> What about coherency across live migration? The userspace process would
> use cached accesses, and also a WBINVD could potentially corrupt guest
> memory.
Haven't given it an iota of thought. My comments were purely in the
context of the SKX40 and SKX59 errata, which are silly bugs that no real
world software will ever hit, e.g. no sane software is going to split a
MASKMOV instruction across address spaces. Hitting SKX59 would further
require the kernel to map MMIO as WB directly adjacent to RAM, which is
beyond crazy.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-18 22:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 21:30 [RFC PATCH 0/3] KVM: x86: honor guest memory type Chia-I Wu
2020-02-13 21:30 ` [RFC PATCH 1/3] KVM: vmx: rewrite the comment in vmx_get_mt_mask Chia-I Wu
2020-02-14 9:36 ` Paolo Bonzini
2020-02-13 21:30 ` [RFC PATCH 2/3] RFC: KVM: add KVM_MEM_DMA Chia-I Wu
2020-02-13 21:30 ` [RFC PATCH 3/3] RFC: KVM: x86: support KVM_CAP_DMA_MEM Chia-I Wu
2020-02-13 21:41 ` [RFC PATCH 0/3] KVM: x86: honor guest memory type Paolo Bonzini
2020-02-13 22:18 ` Chia-I Wu
2020-02-14 10:26 ` Paolo Bonzini
2020-02-14 19:52 ` Sean Christopherson
2020-02-14 21:47 ` Chia-I Wu
2020-02-14 21:56 ` Jim Mattson
2020-02-14 22:03 ` Sean Christopherson
2020-02-18 16:28 ` Paolo Bonzini
2020-02-18 22:58 ` Sean Christopherson [this message]
2020-02-19 9:52 ` Tian, Kevin
2020-02-19 19:36 ` Chia-I Wu
2020-02-20 2:04 ` Tian, Kevin
2020-02-20 2:38 ` Tian, Kevin
2020-02-20 22:23 ` Chia-I Wu
2020-02-21 0:23 ` Tian, Kevin
2020-02-21 4:45 ` Chia-I Wu
2020-02-21 4:51 ` Chia-I Wu
2020-02-21 5:39 ` Tian, Kevin
2020-02-21 15:59 ` Sean Christopherson
2020-02-21 18:21 ` Chia-I Wu
2020-02-25 1:29 ` Tian, Kevin
2020-02-14 21:15 ` Chia-I Wu
2020-02-19 10:00 ` Tian, Kevin
2020-02-19 19:18 ` Chia-I Wu
2020-02-20 2:13 ` Tian, Kevin
2020-02-20 23:02 ` Chia-I Wu
2020-02-24 10:57 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218225809.GL28156@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gurchetansingh@chromium.org \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).