From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72426C38BF9 for ; Mon, 24 Feb 2020 22:34:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 426EE2176D for ; Mon, 24 Feb 2020 22:34:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Dv9ULSM0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 426EE2176D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7A84A6E9AE; Mon, 24 Feb 2020 22:34:25 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 744986E9AE for ; Mon, 24 Feb 2020 22:34:24 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 74EA310CA; Mon, 24 Feb 2020 23:34:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1582583663; bh=Lz6gfaLcR4zUsewQHWvaxEutcbYD0+HKXxn05yO4svE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dv9ULSM0lv7dd9u3oAQbXhFggbQcrl5iBUadpIc0CcEMEZwd2a3YWPS4GPTCQdy+p B/t+8CvhxxDxva+8YP85zyIPsv+wdI913q7hZDZXU5t1wJ1CAgJ9ifbDdmRkp9J8g3 nTag4T2MLDKr3rG+qeMayBw0hfdFb4pK6T5kNgUk= Date: Tue, 25 Feb 2020 00:34:00 +0200 From: Laurent Pinchart To: Boris Brezillon Subject: Re: [PATCH v10 10/12] drm/bridge: panel: Propage bus format/flags Message-ID: <20200224223400.GB29578@pendragon.ideasonboard.com> References: <20200128135514.108171-1-boris.brezillon@collabora.com> <20200128135514.108171-11-boris.brezillon@collabora.com> <20200131182505.51366470@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200131182505.51366470@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nikita Yushchenko , Mark Rutland , Jernej Skrabec , Neil Armstrong , Andrey Smirnov , Jonas Karlman , dri-devel@lists.freedesktop.org, Andrzej Hajda , devicetree@vger.kernel.org, Rob Herring , Thierry Reding , intel-gfx-trybot@lists.freedesktop.org, kernel@collabora.com, Sam Ravnborg , Chris Healy Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Boris, Thank you for the patch. On Fri, Jan 31, 2020 at 06:25:05PM +0100, Boris Brezillon wrote: > And the typo (Propage -> Propagate) is still there :-(. Fixing it right > now so I don't forget. > > On Tue, 28 Jan 2020 14:55:12 +0100 Boris Brezillon wrote: > > So that the previous bridge element in the chain knows which input > > format the panel bridge expects. I've been told multiple times by Tomi that the commit message should be readable by itself, not just as a continuation of the subject line. I was annoyed in the beginning, as I had to change my habits, but I think it's an actual improvement. You may want to pay attention to that too in the future. > > v10: > > * Add changelog to the commit message > > > > v8 -> v9: > > * No changes > > > > v7: > > * Set atomic state hooks explicitly > > > > v4 -> v6: > > * Not part of the series > > > > v3: > > * Adjust things to match the new bus-format negotiation approach > > * Use drm_atomic_helper_bridge_propagate_bus_fmt > > * Don't implement ->atomic_check() (the core now takes care of bus > > flags propagation) > > > > v2: > > * Adjust things to match the new bus-format negotiation approach > > > > Signed-off-by: Boris Brezillon With the typo fixed, Reviewed-by: Laurent Pinchart > > --- > > drivers/gpu/drm/bridge/panel.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c > > index f66777e24968..dcc72bd7df30 100644 > > --- a/drivers/gpu/drm/bridge/panel.c > > +++ b/drivers/gpu/drm/bridge/panel.c > > @@ -127,6 +127,10 @@ static const struct drm_bridge_funcs panel_bridge_bridge_funcs = { > > .enable = panel_bridge_enable, > > .disable = panel_bridge_disable, > > .post_disable = panel_bridge_post_disable, > > + .atomic_reset = drm_atomic_helper_bridge_reset, > > + .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, > > + .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, > > + .atomic_get_input_bus_fmts = drm_atomic_helper_bridge_propagate_bus_fmt, > > }; > > > > /** -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel