From: kbuild test robot <lkp@intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: kbuild-all@lists.01.org,
Francesco Lavra <francescolavra.fl@gmail.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
m.felsch@pengutronix.de,
DRI Development <dri-devel@lists.freedesktop.org>,
Sandy Huang <hjc@rock-chips.com>,
linux-rockchip@lists.infradead.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Daniel Vetter <daniel.vetter@intel.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 37/51] drm/rockchip: Drop explicit drm_mode_config_cleanup call
Date: Sat, 29 Feb 2020 05:19:17 +0800 [thread overview]
Message-ID: <202002290524.w5E4ezpR%lkp@intel.com> (raw)
In-Reply-To: <20200227181522.2711142-38-daniel.vetter@ffwll.ch>
[-- Attachment #1: Type: text/plain, Size: 7186 bytes --]
Hi Daniel,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-tip/drm-tip]
[also build test ERROR on next-20200228]
[cannot apply to drm-intel/for-linux-next linus/master pinchartl-media/drm/du/next v5.6-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-managed-resources-v3/20200229-005817
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/rockchip/rockchip_drm_drv.c: In function 'rockchip_drm_bind':
>> drivers/gpu/drm/rockchip/rockchip_drm_drv.c:147:3: error: label 'err_mode_config_cleanup' used but not defined
goto err_mode_config_cleanup;
^~~~
vim +/err_mode_config_cleanup +147 drivers/gpu/drm/rockchip/rockchip_drm_drv.c
2048e3286f347db Mark Yao 2014-08-22 110
f706974a69b6e2b Tomeu Vizoso 2016-06-10 111 static int rockchip_drm_bind(struct device *dev)
2048e3286f347db Mark Yao 2014-08-22 112 {
f706974a69b6e2b Tomeu Vizoso 2016-06-10 113 struct drm_device *drm_dev;
2048e3286f347db Mark Yao 2014-08-22 114 struct rockchip_drm_private *private;
2048e3286f347db Mark Yao 2014-08-22 115 int ret;
2048e3286f347db Mark Yao 2014-08-22 116
f706974a69b6e2b Tomeu Vizoso 2016-06-10 117 drm_dev = drm_dev_alloc(&rockchip_drm_driver, dev);
0f2886057be322d Tom Gundersen 2016-09-21 118 if (IS_ERR(drm_dev))
0f2886057be322d Tom Gundersen 2016-09-21 119 return PTR_ERR(drm_dev);
2048e3286f347db Mark Yao 2014-08-22 120
f706974a69b6e2b Tomeu Vizoso 2016-06-10 121 dev_set_drvdata(dev, drm_dev);
f706974a69b6e2b Tomeu Vizoso 2016-06-10 122
f706974a69b6e2b Tomeu Vizoso 2016-06-10 123 private = devm_kzalloc(drm_dev->dev, sizeof(*private), GFP_KERNEL);
f706974a69b6e2b Tomeu Vizoso 2016-06-10 124 if (!private) {
f706974a69b6e2b Tomeu Vizoso 2016-06-10 125 ret = -ENOMEM;
9127f99c4801f32 Tomasz Figa 2016-06-21 126 goto err_free;
f706974a69b6e2b Tomeu Vizoso 2016-06-10 127 }
f706974a69b6e2b Tomeu Vizoso 2016-06-10 128
2048e3286f347db Mark Yao 2014-08-22 129 drm_dev->dev_private = private;
2048e3286f347db Mark Yao 2014-08-22 130
5182c1a556d7ff7 Yakir Yang 2016-07-24 131 INIT_LIST_HEAD(&private->psr_list);
60beeccc72cabef Sean Paul 2018-03-05 132 mutex_init(&private->psr_list_lock);
5182c1a556d7ff7 Yakir Yang 2016-07-24 133
ccea91998c8f140 Jeffy Chen 2017-04-06 134 ret = rockchip_drm_init_iommu(drm_dev);
ccea91998c8f140 Jeffy Chen 2017-04-06 135 if (ret)
ccea91998c8f140 Jeffy Chen 2017-04-06 136 goto err_free;
ccea91998c8f140 Jeffy Chen 2017-04-06 137
7db42e97bb41bd5 Daniel Vetter 2020-02-27 138 ret = drm_mode_config_init(drm_dev);
7db42e97bb41bd5 Daniel Vetter 2020-02-27 139 if (ret)
7db42e97bb41bd5 Daniel Vetter 2020-02-27 140 goto err_iommu_cleanup;
2048e3286f347db Mark Yao 2014-08-22 141
2048e3286f347db Mark Yao 2014-08-22 142 rockchip_drm_mode_config_init(drm_dev);
2048e3286f347db Mark Yao 2014-08-22 143
2048e3286f347db Mark Yao 2014-08-22 144 /* Try to bind all sub drivers. */
2048e3286f347db Mark Yao 2014-08-22 145 ret = component_bind_all(dev, drm_dev);
2048e3286f347db Mark Yao 2014-08-22 146 if (ret)
ccea91998c8f140 Jeffy Chen 2017-04-06 @147 goto err_mode_config_cleanup;
2048e3286f347db Mark Yao 2014-08-22 148
ccea91998c8f140 Jeffy Chen 2017-04-06 149 ret = drm_vblank_init(drm_dev, drm_dev->mode_config.num_crtc);
ccea91998c8f140 Jeffy Chen 2017-04-06 150 if (ret)
ccea91998c8f140 Jeffy Chen 2017-04-06 151 goto err_unbind_all;
ccea91998c8f140 Jeffy Chen 2017-04-06 152
ccea91998c8f140 Jeffy Chen 2017-04-06 153 drm_mode_config_reset(drm_dev);
2048e3286f347db Mark Yao 2014-08-22 154
2048e3286f347db Mark Yao 2014-08-22 155 /*
2048e3286f347db Mark Yao 2014-08-22 156 * enable drm irq mode.
2048e3286f347db Mark Yao 2014-08-22 157 * - with irq_enabled = true, we can use the vblank feature.
2048e3286f347db Mark Yao 2014-08-22 158 */
2048e3286f347db Mark Yao 2014-08-22 159 drm_dev->irq_enabled = true;
2048e3286f347db Mark Yao 2014-08-22 160
2048e3286f347db Mark Yao 2014-08-22 161 ret = rockchip_drm_fbdev_init(drm_dev);
2048e3286f347db Mark Yao 2014-08-22 162 if (ret)
8415ab565da966b Mark Yao 2017-08-01 163 goto err_unbind_all;
8415ab565da966b Mark Yao 2017-08-01 164
8415ab565da966b Mark Yao 2017-08-01 165 /* init kms poll for handling hpd */
8415ab565da966b Mark Yao 2017-08-01 166 drm_kms_helper_poll_init(drm_dev);
2048e3286f347db Mark Yao 2014-08-22 167
9127f99c4801f32 Tomasz Figa 2016-06-21 168 ret = drm_dev_register(drm_dev, 0);
9127f99c4801f32 Tomasz Figa 2016-06-21 169 if (ret)
8415ab565da966b Mark Yao 2017-08-01 170 goto err_kms_helper_poll_fini;
9127f99c4801f32 Tomasz Figa 2016-06-21 171
2048e3286f347db Mark Yao 2014-08-22 172 return 0;
2048e3286f347db Mark Yao 2014-08-22 173 err_kms_helper_poll_fini:
2048e3286f347db Mark Yao 2014-08-22 174 drm_kms_helper_poll_fini(drm_dev);
8415ab565da966b Mark Yao 2017-08-01 175 rockchip_drm_fbdev_fini(drm_dev);
ccea91998c8f140 Jeffy Chen 2017-04-06 176 err_unbind_all:
2048e3286f347db Mark Yao 2014-08-22 177 component_unbind_all(dev, drm_dev);
7db42e97bb41bd5 Daniel Vetter 2020-02-27 178 err_iommu_cleanup:
ccea91998c8f140 Jeffy Chen 2017-04-06 179 rockchip_iommu_cleanup(drm_dev);
f706974a69b6e2b Tomeu Vizoso 2016-06-10 180 err_free:
574e0fbfc95e7fc Thomas Zimmermann 2018-07-17 181 drm_dev_put(drm_dev);
2048e3286f347db Mark Yao 2014-08-22 182 return ret;
2048e3286f347db Mark Yao 2014-08-22 183 }
2048e3286f347db Mark Yao 2014-08-22 184
:::::: The code at line 147 was first introduced by commit
:::::: ccea91998c8f140bc3e324bbb3c3fb7148e72d31 drm/rockchip: Reorder drm bind/unbind sequence
:::::: TO: Jeffy Chen <jeffy.chen@rock-chips.com>
:::::: CC: Sean Paul <seanpaul@chromium.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 47162 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-28 21:19 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 18:14 [PATCH 00/51] drm managed resources, v3 Daniel Vetter
2020-02-27 18:14 ` [PATCH 01/51] mm/sl[uo]b: export __kmalloc_track(_node)_caller Daniel Vetter
2020-02-27 18:14 ` [PATCH 02/51] drm/i915: Don't clear drvdata in ->release Daniel Vetter
2020-02-27 18:14 ` [PATCH 03/51] drm: add managed resources tied to drm_device Daniel Vetter
2020-02-28 22:45 ` Sam Ravnborg
2020-02-28 23:14 ` Daniel Vetter
2020-02-29 11:17 ` Sam Ravnborg
2020-02-29 11:28 ` Daniel Vetter
2020-03-02 9:22 ` Jani Nikula
2020-03-02 9:36 ` Daniel Vetter
2020-03-02 9:39 ` Daniel Vetter
2020-03-02 16:34 ` Sam Ravnborg
2020-02-27 18:14 ` [PATCH 04/51] drm: Set final_kfree in drm_dev_alloc Daniel Vetter
2020-02-27 18:14 ` [PATCH 05/51] drm/mipi_dbi: Use drmm_add_final_kfree in all drivers Daniel Vetter
2020-02-27 20:55 ` Sam Ravnborg
2020-02-27 18:14 ` [PATCH 06/51] drm/udl: Use drmm_add_final_kfree Daniel Vetter
2020-02-27 20:57 ` Sam Ravnborg
2020-02-27 18:14 ` [PATCH 07/51] drm/qxl: " Daniel Vetter
2020-02-27 18:14 ` [PATCH 08/51] drm/i915: " Daniel Vetter
2020-02-27 18:14 ` [PATCH 09/51] drm/cirrus: " Daniel Vetter
2020-02-27 21:01 ` Sam Ravnborg
2020-02-27 18:14 ` [PATCH 10/51] drm/v3d: " Daniel Vetter
2020-02-27 18:14 ` [PATCH 11/51] drm/tidss: " Daniel Vetter
2020-02-27 18:14 ` [PATCH 12/51] drm/mcde: " Daniel Vetter
2020-02-27 18:14 ` [PATCH 13/51] drm/vgem: " Daniel Vetter
2020-02-27 21:02 ` Sam Ravnborg
2020-02-27 18:14 ` [PATCH 14/51] drm/vkms: " Daniel Vetter
2020-02-27 18:59 ` Rodrigo Siqueira
2020-02-27 18:14 ` [PATCH 15/51] drm/repaper: " Daniel Vetter
2020-02-27 18:14 ` [PATCH 16/51] drm/inigenic: " Daniel Vetter
2020-03-02 20:12 ` Paul Cercueil
2020-02-27 18:14 ` [PATCH 17/51] drm/gm12u320: " Daniel Vetter
2020-02-27 18:14 ` [PATCH 18/51] drm/<drivers>: " Daniel Vetter
2020-02-27 18:35 ` Liviu Dudau
2020-02-27 18:14 ` [PATCH 19/51] drm: Cleanups after drmm_add_final_kfree rollout Daniel Vetter
2020-02-27 18:14 ` [PATCH 20/51] drm: Handle dev->unique with drmm_ Daniel Vetter
2020-02-27 18:14 ` [PATCH 21/51] drm: Use drmm_ for drm_dev_init cleanup Daniel Vetter
2020-02-27 18:14 ` [PATCH 22/51] drm: manage drm_minor cleanup with drmm_ Daniel Vetter
2020-02-27 18:14 ` [PATCH 23/51] drm: Manage drm_gem_init " Daniel Vetter
2020-02-27 18:14 ` [PATCH 24/51] drm: Manage drm_vblank_cleanup " Daniel Vetter
2020-02-27 18:14 ` [PATCH 25/51] drm: Garbage collect drm_dev_fini Daniel Vetter
2020-02-27 18:14 ` [PATCH 26/51] drm: Manage drm_mode_config_init with drmm_ Daniel Vetter
2020-02-28 7:30 ` Thomas Zimmermann
2020-02-28 8:43 ` Daniel Vetter
2020-02-28 9:56 ` Thomas Zimmermann
2020-02-28 20:26 ` Sam Ravnborg
2020-02-28 23:11 ` Daniel Vetter
2020-02-29 10:59 ` Sam Ravnborg
2020-03-02 14:09 ` Daniel Vetter
2020-02-27 18:14 ` [PATCH 27/51] drm/bochs: Remove leftover drm_atomic_helper_shutdown Daniel Vetter
2020-02-27 18:14 ` [PATCH 28/51] drm/bochs: Drop explicit drm_mode_config_cleanup Daniel Vetter
2020-02-27 18:15 ` [PATCH 29/51] drm/cirrus: Drop explicit drm_mode_config_cleanup call Daniel Vetter
2020-02-28 20:32 ` Sam Ravnborg
2020-02-27 18:15 ` [PATCH 30/51] drm/cirrus: Fully embrace devm_ Daniel Vetter
2020-02-27 18:15 ` [PATCH 31/51] drm/ingenic: Drop explicit drm_mode_config_cleanup call Daniel Vetter
2020-03-02 20:13 ` Paul Cercueil
2020-02-27 18:15 ` [PATCH 32/51] drm/mcde: " Daniel Vetter
2020-02-27 18:15 ` [PATCH 33/51] drm/mcde: More devm_drm_dev_init Daniel Vetter
2020-02-27 18:15 ` [PATCH 34/51] drm/meson: Drop explicit drm_mode_config_cleanup call Daniel Vetter
2020-02-27 18:15 ` [PATCH 35/51] drm/pl111: " Daniel Vetter
2020-02-27 18:15 ` [PATCH 36/51] drm/rcar-du: " Daniel Vetter
2020-02-27 18:15 ` [PATCH 37/51] drm/rockchip: " Daniel Vetter
2020-02-28 21:19 ` kbuild test robot [this message]
2020-02-28 23:34 ` Daniel Vetter
2020-02-29 1:53 ` kbuild test robot
2020-02-27 18:15 ` [PATCH 38/51] drm/stm: " Daniel Vetter
2020-02-27 18:15 ` [PATCH 39/51] drm/shmob: " Daniel Vetter
2020-02-27 18:15 ` [PATCH 40/51] drm/mtk: " Daniel Vetter
2020-02-27 18:15 ` [PATCH 41/51] drm/tidss: " Daniel Vetter
2020-02-27 18:15 ` [PATCH 42/51] drm/gm12u320: More drmm_ Daniel Vetter
2020-02-27 18:15 ` [PATCH 43/51] drm/gm12u320: Use devm_drm_dev_init Daniel Vetter
2020-02-27 18:15 ` [PATCH 44/51] drm/gm12u320: Use helpers for shutdown/suspend/resume Daniel Vetter
2020-02-27 18:15 ` [PATCH 45/51] drm/gm12u320: Simplify upload work Daniel Vetter
2020-02-27 19:04 ` Hans de Goede
2020-02-27 18:15 ` [PATCH 46/51] drm/repaper: Drop explicit drm_mode_config_cleanup call Daniel Vetter
2020-02-27 18:15 ` [PATCH 47/51] drm/mipi-dbi: Move drm_mode_config_init into mipi library Daniel Vetter
2020-02-28 20:34 ` Sam Ravnborg
2020-02-27 18:15 ` [PATCH 48/51] drm/mipi-dbi: Drop explicit drm_mode_config_cleanup call Daniel Vetter
2020-02-28 20:36 ` Sam Ravnborg
2020-02-27 18:15 ` [PATCH 49/51] drm/udl: " Daniel Vetter
2020-02-28 20:37 ` Sam Ravnborg
2020-02-27 18:15 ` [PATCH 50/51] drm/udl: drop drm_driver.release hook Daniel Vetter
2020-02-28 7:43 ` Thomas Zimmermann
2020-02-28 8:40 ` Daniel Vetter
2020-02-28 11:46 ` Thomas Zimmermann
2020-02-28 17:43 ` Daniel Vetter
2020-03-02 8:14 ` Thomas Zimmermann
2020-03-02 9:01 ` Daniel Vetter
2020-02-27 18:15 ` [PATCH 51/51] drm: Add docs for managed resources Daniel Vetter
2020-02-27 20:53 ` Sam Ravnborg
-- strict thread matches above, loose matches on Subject: below --
2020-03-23 14:48 [PATCH 00/51] drm_device managed resources, v5 Daniel Vetter
2020-03-23 14:49 ` [PATCH 37/51] drm/rockchip: Drop explicit drm_mode_config_cleanup call Daniel Vetter
2020-03-02 22:25 [PATCH 00/51] drm_device managed resources, v4 Daniel Vetter
2020-03-02 22:26 ` [PATCH 37/51] drm/rockchip: Drop explicit drm_mode_config_cleanup call Daniel Vetter
2020-03-07 8:38 ` Sam Ravnborg
2020-02-21 21:02 [PATCH 00/51] drm managed resources, v2 Daniel Vetter
2020-02-21 21:03 ` [PATCH 37/51] drm/rockchip: Drop explicit drm_mode_config_cleanup call Daniel Vetter
2020-02-24 19:13 ` Francesco Lavra
2020-02-24 20:37 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202002290524.w5E4ezpR%lkp@intel.com \
--to=lkp@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=francescolavra.fl@gmail.com \
--cc=hjc@rock-chips.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kbuild-all@lists.01.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).