From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76BFDC3F2CD for ; Tue, 3 Mar 2020 14:50:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DF042083E for ; Tue, 3 Mar 2020 14:50:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DF042083E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B465D6EA7D; Tue, 3 Mar 2020 14:50:42 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5BD896EA7D for ; Tue, 3 Mar 2020 14:50:41 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Mar 2020 06:50:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,511,1574150400"; d="scan'208";a="233771567" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by fmsmga008.fm.intel.com with SMTP; 03 Mar 2020 06:50:39 -0800 Received: by stinkbox (sSMTP sendmail emulation); Tue, 03 Mar 2020 16:50:38 +0200 Date: Tue, 3 Mar 2020 16:50:38 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Sam Ravnborg Subject: Re: [PATCH 00/33] drm/panel: Fix dotclocks Message-ID: <20200303145038.GV13686@intel.com> References: <20200302203452.17977-1-ville.syrjala@linux.intel.com> <20200302214713.GA948@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200302214713.GA948@ravnborg.org> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Mar 02, 2020 at 10:47:13PM +0100, Sam Ravnborg wrote: > Hi Ville. > = > On Mon, Mar 02, 2020 at 10:34:19PM +0200, Ville Syrjala wrote: > > From: Ville Syrj=E4l=E4 > > = > > A lot of the panel drivers put bogus looking values into > > mode.clock. This series replaces the bogus values with > > mode.vrefresh*mode.htotal*mode.vtotal. > = > I think you got it wrong.... > The few I sampled I would rather say that the clock > specified was the one that was possible with the present > HW and the refresh rate was then set to what was attempted. > = > Example: > chunghwa_claa101wb01_mode > = > clock is 69300 - which looks like a value you could configure > in HW. It not not a nive round value. > refresh is 60, which looks like the refresh value that was attempted. > = > So unless there is a big difference between the > calcualted refresh (based on the specifed clock), > and the specified clock it should be assumed that clock is OK. > And it is OK to drop refresh. > = > This is my take on it - but you based your patches on refresh. > So maybe you have a better rationale to do so? No. I just blindly converted everything and posted the patches so people can tell me which way to go. -- = Ville Syrj=E4l=E4 Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel