From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D7B1C3F2CD for ; Tue, 3 Mar 2020 14:52:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7960620828 for ; Tue, 3 Mar 2020 14:52:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7960620828 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0971E6EA83; Tue, 3 Mar 2020 14:52:56 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5415E6EA83 for ; Tue, 3 Mar 2020 14:52:55 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Mar 2020 06:52:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,511,1574150400"; d="scan'208";a="351853186" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by fmsmga001.fm.intel.com with SMTP; 03 Mar 2020 06:52:51 -0800 Received: by stinkbox (sSMTP sendmail emulation); Tue, 03 Mar 2020 16:52:51 +0200 Date: Tue, 3 Mar 2020 16:52:51 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Marco Felsch Subject: Re: [PATCH 15/33] drm/panel-simple: Fix dotclock for EDT ET035012DM6 Message-ID: <20200303145251.GX13686@intel.com> References: <20200302203452.17977-1-ville.syrjala@linux.intel.com> <20200302203452.17977-16-ville.syrjala@linux.intel.com> <20200303073320.2udpokcs2ync4hpy@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200303073320.2udpokcs2ync4hpy@pengutronix.de> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thierry Reding , Andreas Pretzsch , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Mar 03, 2020 at 08:33:20AM +0100, Marco Felsch wrote: > Hi Ville, > = > On 20-03-02 22:34, Ville Syrjala wrote: > > From: Ville Syrj=E4l=E4 > > = > > The currently listed dotclock disagrees with the currently > > listed vrefresh rate. Change the dotclock to match the vrefresh. > > = > > Someone tell me which (if either) of the dotclock or vreresh is > > correct? > = > Pls, check the datasheet which is linked within the comment. We hit the > vrefresh exactly if we are in SYNC MODE. It's too much work to start hunting datasheets for all these and figuring out what's going on in each case. Pls just inform me which way is correct if you know the details. > = > Regards, > Marco > = > > Cc: Andreas Pretzsch > > Cc: Marco Felsch > > Cc: Thierry Reding > > Signed-off-by: Ville Syrj=E4l=E4 > > --- > > drivers/gpu/drm/panel/panel-simple.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > = > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/pan= el/panel-simple.c > > index 93e5bc32fb59..35750229189f 100644 > > --- a/drivers/gpu/drm/panel/panel-simple.c > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > @@ -1342,7 +1342,7 @@ static const struct panel_desc dlc_dlc1010gig =3D= { > > }; > > = > > static const struct drm_display_mode edt_et035012dm6_mode =3D { > > - .clock =3D 6500, > > + .clock =3D 6414, > > .hdisplay =3D 320, > > .hsync_start =3D 320 + 20, > > .hsync_end =3D 320 + 20 + 30, > > -- = > > 2.24.1 > > = > > = > = > -- = > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- = Ville Syrj=E4l=E4 Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel