Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on next-20200305] [also build test ERROR on v5.6-rc4] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Convert-drivers-to-drm_simple_encoder_init/20200306-045931 base: 47466dcf84ee66a973ea7d2fca7e582fe9328932 config: arm64-defconfig (attached as .config) compiler: clang version 11.0.0 (git://gitmirror/llvm_project a0cd413426479abb207381bdbab862f3dfb3ce7d) reproduce: # FIXME the reproduce steps for clang is not ready yet If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): >> drivers/gpu//drm/hisilicon/kirin/dw_drm_dsi.c:713:8: error: implicit declaration of function 'drm_simple_encoder_init' [-Werror,-Wimplicit-function-declaration] ret = drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_DSI); ^ drivers/gpu//drm/hisilicon/kirin/dw_drm_dsi.c:713:8: note: did you mean 'drm_i2c_encoder_init'? include/drm/drm_encoder_slave.h:104:5: note: 'drm_i2c_encoder_init' declared here int drm_i2c_encoder_init(struct drm_device *dev, ^ 1 error generated. vim +/drm_simple_encoder_init +713 drivers/gpu//drm/hisilicon/kirin/dw_drm_dsi.c 699 700 static int dw_drm_encoder_init(struct device *dev, 701 struct drm_device *drm_dev, 702 struct drm_encoder *encoder) 703 { 704 int ret; 705 u32 crtc_mask = drm_of_find_possible_crtcs(drm_dev, dev->of_node); 706 707 if (!crtc_mask) { 708 DRM_ERROR("failed to find crtc mask\n"); 709 return -EINVAL; 710 } 711 712 encoder->possible_crtcs = crtc_mask; > 713 ret = drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_DSI); 714 if (ret) { 715 DRM_ERROR("failed to init dsi encoder\n"); 716 return ret; 717 } 718 719 drm_encoder_helper_add(encoder, &dw_encoder_helper_funcs); 720 721 return 0; 722 } 723 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org