From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76474C10F27 for ; Mon, 9 Mar 2020 21:47:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56CB324649 for ; Mon, 9 Mar 2020 21:47:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56CB324649 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9026A6E5A2; Mon, 9 Mar 2020 21:47:47 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 911236E5A2 for ; Mon, 9 Mar 2020 21:47:45 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 8915A20021; Mon, 9 Mar 2020 22:47:40 +0100 (CET) Date: Mon, 9 Mar 2020 22:47:39 +0100 From: Sam Ravnborg To: "Lad, Prabhakar" Subject: Re: [RESEND PATCH v7] dt-bindings: display: Add idk-2121wr binding Message-ID: <20200309214739.GA11495@ravnborg.org> References: <20200306152031.14212-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20200309203242.GA14486@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=VwQbUJbxAAAA:8 a=yC-0_ovQAAAA:8 a=NcFk6D9gAAAA:8 a=S6n1fyGeoZp7psgl2-IA:9 a=CjuIK1q_8ugA:10 a=gDps05xe3HUA:10 a=-FEs8UIgK8oA:10 a=CojVow1nldcA:10 a=NWVoK91CQyQA:10 a=AjGcO6oz07-iQ99wixmX:22 a=QsnFDINu91a9xkgZirup:22 a=dT0RXAwTRpxWjiziVLXF:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Chris Paterson , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , David Airlie , LKML , dri-devel@lists.freedesktop.org, Lad Prabhakar , Thierry Reding , Geert Uytterhoeven , Laurent Pinchart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Prabhakar On Mon, Mar 09, 2020 at 09:23:24PM +0000, Lad, Prabhakar wrote: > Hi Rob, > > On Mon, Mar 9, 2020 at 8:32 PM Rob Herring wrote: > > > > On Fri, 6 Mar 2020 15:20:31 +0000, Lad Prabhakar wrote: > > > From: Fabrizio Castro > > > > > > Add binding for the idk-2121wr LVDS panel from Advantech. > > > > > > Some panel-specific documentation can be found here: > > > https://buy.advantech.eu/Displays/Embedded-LCD-Kits-High-Brightness/model-IDK-2121WR-K2FHA2E.htm > > > > > > Signed-off-by: Fabrizio Castro > > > Signed-off-by: Lad Prabhakar > > > --- > > > Apologies for flooding in I missed to add the ML email-ids for the earlier > > > version so resending it. > > > > > > Hi All, > > > > > > This patch is part of series [1] ("Add dual-LVDS panel support to EK874), > > > all the patches have been accepted from it except this one. I have fixed > > > Rob's comments in this version of the patch. > > > > > > [1] https://patchwork.kernel.org/cover/11297589/ > > > > > > v6->7 > > > * Added reference to lvds.yaml > > > * Changed maintainer to myself > > > * Switched to dual license > > > * Dropped required properties except for ports as rest are already listed > > > in lvds.panel > > > * Dropped Reviewed-by tag of Laurent, due to the changes made it might not > > > be valid. > > > > > > v5->v6: > > > * No change > > > > > > v4->v5: > > > * No change > > > > > > v3->v4: > > > * Absorbed patch "dt-bindings: display: Add bindings for LVDS > > > bus-timings" > > > * Big restructuring after Rob's and Laurent's comments > > > > > > v2->v3: > > > * New patch > > > > > > .../display/panel/advantech,idk-2121wr.yaml | 120 +++++++++++++++++++++ > > > 1 file changed, 120 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.yaml > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.example.dt.yaml: panel-lvds: 'port' is a required property > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.example.dt.yaml: panel-lvds: 'port' is a required property > > > This panel is a dual channel LVDS, as a result the root port is called as > ports instead of port and the child node port@0 and port@1 are used for > even and odd pixels, hence binding has required property as ports instead > of port. What goes wrong is that you have a ref to lvds.yaml - and thus you get also required from that file. So basically - I think this binding should not have a ref to lvds.yaml - as the binding needs to be different. Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel