Re: [PATCH v1 06/36] dt-bindings: display: convert ilitek, ili9322 to DT Schema

From: Sam Ravnborg <sam@ravnborg.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
	Nikolaus Schaller <hns@goldelico.com>,
	Jonathan Bakker <xc-racer2@live.ca>,
	Sandeep Panda <spanda@codeaurora.org>,
	"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
	Paul Cercueil <paul@crapouillou.net>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Chris Zhong <zyw@rock-chips.com>,
	Marco Franchi <marco.franchi@nxp.com>,
	Stefan Mavrodiev <stefan@olimex.com>,
	Jerry Han <hanxu5@huaqin.corp-partner.google.com>,
	Hoegeun Kwon <hoegeun.kwon@samsung.com>,
	Tony Lindgren <tony@atomide.com>,
	Nickey Yang <nickey.yang@rock-chips.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Robert Chiras <robert.chiras@nxp.com>,
	Vinay Simha BN <simhavcs@gmail.com>,
	Marek Belisko <marek@goldelico.com>, Heiko Schocher <hs@denx.de>,
	Guido Gunther <agx@sigxcpu.org>,
	Brian Masney <masneyb@onstation.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>, Mark Brown <broonie@kernel.org>,
	Alexandre Courbot <acourbot@nvidia.com>,
	Werner Johansson <werner.johansson@sonymobile.com>,
	Purism Kernel Team <kernel@puri.sm>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Lin Huang <hl@rock-chips.com>,
	Douglas Anderson <dianders@chromium.org>,
	linux-spi <linux-spi@vger.kernel.org>,
	Peter Rosin <peda@axentia.se>
Subject: Re: [PATCH v1 06/36] dt-bindings: display: convert ilitek, ili9322 to DT Schema
Date: Sun, 15 Mar 2020 20:24:52 +0100	[thread overview]
Message-ID: <20200315192452.GA29182@ravnborg.org> (raw)
In-Reply-To: <CACRpkdYVrTBKxuHSGpd9=03oD4=JVxzJf8fOcQ8uu5eRt9PgAg@mail.gmail.com>

Hi Linus.

On Sun, Mar 15, 2020 at 07:54:38PM +0100, Linus Walleij wrote:
> On Sun, Mar 15, 2020 at 2:44 PM Sam Ravnborg <sam@ravnborg.org> wrote:
> 
> > The .txt binding explains:
> >
> > "
> >     The following optional properties only apply to
> >     RGB and YUV input modes and
> >     can be omitted for BT.656 input modes:
> > "
> >
> > This constraint is not implmented in the DT Schema.
> >
> > The original binding from the .txt file referenced
> > properties that is included in panel-timing.yaml.
> > These properties are kept here as we want as close to a 1:1
> > conversion as we can. If the properties should be dropped
> > from the binding then this is a follow-up patch.
> >
> > The properties in question are:
> >   - pixelclk-active
> >   - de-active
> >   - hsync-active
> >   - vsync-active
> 
> Sorry about that. They should be dropped, but certainly it
> is fine to do with a follow up patch.

I changed my mind - lets try to avoid too many patches.
So if you do not mind I will do it in this patch - and note it in the
changelog.

	Sam

> 
> >
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Yours,
> Linus Walleij
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel