From: Sam Ravnborg <sam@ravnborg.org>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Arnd Bergmann <arnd@arndb.de>,
Neil Armstrong <narmstrong@baylibre.com>,
David Airlie <airlied@linux.ie>,
Sascha Hauer <s.hauer@pengutronix.de>,
Jonas Karlman <jonas@kwiboo.se>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Andrzej Hajda <a.hajda@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Robert Chiras <robert.chiras@nxp.com>,
Lee Jones <lee.jones@linaro.org>, Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v10 2/2] drm/bridge: Add NWL MIPI DSI host controller support
Date: Thu, 9 Apr 2020 13:36:33 +0200 [thread overview]
Message-ID: <20200409113633.GA4330@ravnborg.org> (raw)
In-Reply-To: <20200409104314.GB104945@bogon.m.sigxcpu.org>
Hi Guido.
> > > +
> > > +/* i.MX8 NWL quirks */
> > > +/* i.MX8MQ errata E11418 */
> > > +#define E11418_HS_MODE_QUIRK BIT(0)
> > > +
> > > +#define NWL_DSI_MIPI_FIFO_TIMEOUT msecs_to_jiffies(500)
> > Should the defines be moved to the header file?
>
> I've used this rules: register layout (that is chip properties)
> go to the header file while defines specific to this very driver
> go into the .c file. Hope that makes sense.
Makes good sense, thanks for the explanation.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-09 11:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 18:49 [PATCH v10 0/2] drm: bridge: Add NWL MIPI DSI host controller support Guido Günther
2020-03-20 18:49 ` [PATCH v10 1/2] dt-bindings: display/bridge: Add binding for NWL mipi dsi host controller Guido Günther
2020-03-24 19:34 ` Fabio Estevam
2020-04-08 17:32 ` Sam Ravnborg
2020-04-09 10:42 ` Guido Günther
2020-03-20 18:49 ` [PATCH v10 2/2] drm/bridge: Add NWL MIPI DSI host controller support Guido Günther
2020-03-24 19:34 ` Fabio Estevam
2020-04-08 17:52 ` Sam Ravnborg
2020-04-09 10:43 ` Guido Günther
2020-04-09 11:36 ` Sam Ravnborg [this message]
2020-04-08 17:12 ` [PATCH v10 0/2] drm: bridge: " Guido Günther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409113633.GA4330@ravnborg.org \
--to=sam@ravnborg.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=agx@sigxcpu.org \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=narmstrong@baylibre.com \
--cc=robert.chiras@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).