From: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org, jani.nikula@intel.com,
dri-devel@lists.freedesktop.org, uma.shankar@intel.com,
laurent.pinchart@ideasonboard.com
Subject: [PATCH v10 10/14] drm/i915: Fix enabled infoframe states of lspcon
Date: Fri, 17 Apr 2020 15:00:36 +0300 [thread overview]
Message-ID: <20200417120040.3432332-11-gwan-gyeong.mun@intel.com> (raw)
In-Reply-To: <20200417120040.3432332-1-gwan-gyeong.mun@intel.com>
Compared to implementation of DP and HDMI's encoder->infoframes_enabled,
the lspcon's implementation returns its active state. (we expect enabled
infoframe states of HW.) It leads to pipe state mismatch error
when ddi_get_config is called.
Because the current implementation of lspcon is not ready to support
readout infoframes, we need to return 0 here.
In order to support readout to lspcon, we need to implement read_infoframe
and infoframes_enabled. And set_infoframes also have to set an appropriate
bit on crtc_state->infoframes.enable
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
---
drivers/gpu/drm/i915/display/intel_lspcon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c
index d807c5648c87..6ff7b226f0a1 100644
--- a/drivers/gpu/drm/i915/display/intel_lspcon.c
+++ b/drivers/gpu/drm/i915/display/intel_lspcon.c
@@ -522,7 +522,7 @@ u32 lspcon_infoframes_enabled(struct intel_encoder *encoder,
const struct intel_crtc_state *pipe_config)
{
/* FIXME actually read this from the hw */
- return enc_to_intel_lspcon(encoder)->active;
+ return 0;
}
void lspcon_resume(struct intel_lspcon *lspcon)
--
2.25.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-17 11:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 12:00 [PATCH v10 00/14] In order to readout DP SDPs, refactors the handling of DP SDPs Gwan-gyeong Mun
2020-04-17 12:00 ` [PATCH v10 01/14] video/hdmi: Add Unpack only function for DRM infoframe Gwan-gyeong Mun
2020-04-17 12:00 ` [PATCH v10 02/14] drm/i915/dp: Read out DP SDPs Gwan-gyeong Mun
2020-04-17 12:00 ` [PATCH v10 03/14] drm: Add logging function for DP VSC SDP Gwan-gyeong Mun
2020-04-17 12:00 ` [PATCH v10 04/14] drm/i915: Include HDMI DRM infoframe in the crtc state dump Gwan-gyeong Mun
2020-04-17 12:00 ` [PATCH v10 05/14] drm/i915: Include DP HDR Metadata Infoframe SDP " Gwan-gyeong Mun
2020-04-17 12:00 ` [PATCH v10 06/14] drm/i915: Include DP VSC " Gwan-gyeong Mun
2020-04-17 12:00 ` [PATCH v10 07/14] drm/i915: Program DP SDPs with computed configs Gwan-gyeong Mun
2020-04-17 12:00 ` [PATCH v10 08/14] drm/i915: Add state readout for DP HDR Metadata Infoframe SDP Gwan-gyeong Mun
2020-04-17 12:00 ` [PATCH v10 09/14] drm/i915: Add state readout for DP VSC SDP Gwan-gyeong Mun
2020-04-17 12:00 ` Gwan-gyeong Mun [this message]
2020-04-17 12:00 ` [PATCH v10 11/14] drm/i915: Program DP SDPs on pipe updates Gwan-gyeong Mun
2020-04-17 12:00 ` [PATCH v10 12/14] drm/i915: Stop sending DP SDPs on ddi disable Gwan-gyeong Mun
2020-04-17 12:00 ` [PATCH v10 13/14] drm/i915/dp: Add compute routine for DP PSR VSC SDP Gwan-gyeong Mun
2020-04-17 12:00 ` [PATCH v10 14/14] drm/i915/psr: Use new DP VSC SDP compute routine on PSR Gwan-gyeong Mun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200417120040.3432332-11-gwan-gyeong.mun@intel.com \
--to=gwan-gyeong.mun@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=uma.shankar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).