From: Matthias Kaehlcke <mka@chromium.org>
To: Sharat Masetty <smasetty@codeaurora.org>
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@freedesktop.org,
freedreno@lists.freedesktop.org, georgi.djakov@linaro.org
Subject: Re: [PATCH 1/6] arm64: dts: qcom: sc7180: Add interconnect bindings for GPU
Date: Thu, 14 May 2020 16:37:59 -0700 [thread overview]
Message-ID: <20200514233759.GR4525@google.com> (raw)
In-Reply-To: <1589453659-27581-2-git-send-email-smasetty@codeaurora.org>
Hi Sharat,
On Thu, May 14, 2020 at 04:24:14PM +0530, Sharat Masetty wrote:
> Subject: arm64: dts: qcom: sc7180: Add interconnect bindings for GPU
>
> This patch adds the interconnect bindings to the GPU node. This enables
> the GPU->DDR path bandwidth voting.
This patch doesn't add any bindings, it adds the interconnects/interconnect
configuration for the GPU
The order of the patches in this series is a bit odd. Typically you would
start with the binding changes ("dt-bindings: drm/msm/gpu: Document gpu
opp table" in this case), then the code needed to support these changes,
and finally the DT bits for the specific devices/platforms making use
of the new 'feature'.
It doesn't really matter once the series has landed since the end result
is exactly the same, however it's the logical order in which most
reviewers read your patches, and typically also the order in which the
patches land (especially when multiple trees are involved).
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-14 23:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 10:54 [PATCH 0/6] Add support for GPU DDR BW scaling Sharat Masetty
2020-05-14 10:54 ` [PATCH 1/6] arm64: dts: qcom: sc7180: Add interconnect bindings for GPU Sharat Masetty
2020-05-14 23:37 ` Matthias Kaehlcke [this message]
2020-05-14 10:54 ` [PATCH 2/6] arm64: dts: qcom: sc7180: Add opp-peak-kBps to GPU opp Sharat Masetty
2020-05-14 23:45 ` Matthias Kaehlcke
2020-05-14 10:54 ` [PATCH 3/6] OPP: Add and export helper to set bandwidth Sharat Masetty
2020-05-15 0:32 ` Matthias Kaehlcke
2020-05-14 10:54 ` [PATCH 4/6] drm: msm: a6xx: send opp instead of a frequency Sharat Masetty
2020-05-15 0:39 ` Matthias Kaehlcke
2020-05-15 0:58 ` Matthias Kaehlcke
2020-05-14 10:54 ` [PATCH 5/6] drm: msm: a6xx: use dev_pm_opp_set_bw to set DDR bandwidth Sharat Masetty
2020-05-15 1:05 ` Matthias Kaehlcke
2020-05-18 14:23 ` Jordan Crouse
2020-05-18 16:25 ` [Freedreno] " Rob Clark
2020-05-27 8:47 ` Sharat Masetty
2020-05-27 15:38 ` Rob Clark
2020-05-27 17:31 ` Saravana Kannan
2020-05-27 20:41 ` Sibi Sankar
2020-05-27 20:51 ` Jordan Crouse
2020-05-28 11:02 ` Sharat Masetty
2020-05-14 10:54 ` [PATCH 6/6] dt-bindings: drm/msm/gpu: Document gpu opp table Sharat Masetty
2020-05-28 15:14 ` Rob Herring
2020-05-14 23:56 ` [PATCH 0/6] Add support for GPU DDR BW scaling Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514233759.GR4525@google.com \
--to=mka@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smasetty@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).