From: Sam Ravnborg <sam@ravnborg.org>
To: dri-devel@lists.freedesktop.org,
Jingoo Han <jingoohan1@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>
Cc: linux-pwm@vger.kernel.org,
Support Opensource <support.opensource@diasemi.com>,
Michael Hennerich <michael.hennerich@analog.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Jonathan Corbet <corbet@lwn.net>,
Emil Velikov <emil.l.velikov@gmail.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Andy Gross <agross@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
linux-arm-msm@vger.kernel.org,
Uwe Kleine-Konig <u.kleine-koenig@pengutronix.de>,
Sam Ravnborg <sam@ravnborg.org>,
patches@opensource.cirrus.com
Subject: [PATCH v3 01/13] backlight: refactor fb_notifier_callback()
Date: Mon, 1 Jun 2020 08:51:55 +0200 [thread overview]
Message-ID: <20200601065207.492614-2-sam@ravnborg.org> (raw)
In-Reply-To: <20200601065207.492614-1-sam@ravnborg.org>
Increase readability of fb_notifier_callback() by removing
a few indent levels.
No functional change.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Jingoo Han <jingoohan1@gmail.com>
---
drivers/video/backlight/backlight.c | 43 +++++++++++++++--------------
1 file changed, 22 insertions(+), 21 deletions(-)
diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c
index cac3e35d7630..17f04cff50ab 100644
--- a/drivers/video/backlight/backlight.c
+++ b/drivers/video/backlight/backlight.c
@@ -58,28 +58,29 @@ static int fb_notifier_callback(struct notifier_block *self,
bd = container_of(self, struct backlight_device, fb_notif);
mutex_lock(&bd->ops_lock);
- if (bd->ops)
- if (!bd->ops->check_fb ||
- bd->ops->check_fb(bd, evdata->info)) {
- fb_blank = *(int *)evdata->data;
- if (fb_blank == FB_BLANK_UNBLANK &&
- !bd->fb_bl_on[node]) {
- bd->fb_bl_on[node] = true;
- if (!bd->use_count++) {
- bd->props.state &= ~BL_CORE_FBBLANK;
- bd->props.fb_blank = FB_BLANK_UNBLANK;
- backlight_update_status(bd);
- }
- } else if (fb_blank != FB_BLANK_UNBLANK &&
- bd->fb_bl_on[node]) {
- bd->fb_bl_on[node] = false;
- if (!(--bd->use_count)) {
- bd->props.state |= BL_CORE_FBBLANK;
- bd->props.fb_blank = fb_blank;
- backlight_update_status(bd);
- }
- }
+
+ if (!bd->ops)
+ goto out;
+ if (bd->ops->check_fb && !bd->ops->check_fb(bd, evdata->info))
+ goto out;
+
+ fb_blank = *(int *)evdata->data;
+ if (fb_blank == FB_BLANK_UNBLANK && !bd->fb_bl_on[node]) {
+ bd->fb_bl_on[node] = true;
+ if (!bd->use_count++) {
+ bd->props.state &= ~BL_CORE_FBBLANK;
+ bd->props.fb_blank = FB_BLANK_UNBLANK;
+ backlight_update_status(bd);
+ }
+ } else if (fb_blank != FB_BLANK_UNBLANK && bd->fb_bl_on[node]) {
+ bd->fb_bl_on[node] = false;
+ if (!(--bd->use_count)) {
+ bd->props.state |= BL_CORE_FBBLANK;
+ bd->props.fb_blank = fb_blank;
+ backlight_update_status(bd);
}
+ }
+out:
mutex_unlock(&bd->ops_lock);
return 0;
}
--
2.25.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-06-01 6:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 6:51 [PATCH v3 0/16] backlight updates Sam Ravnborg
2020-06-01 6:51 ` Sam Ravnborg [this message]
2020-06-01 6:51 ` [PATCH v3 02/13] backlight: add backlight_is_blank() Sam Ravnborg
2020-06-01 12:27 ` Peter Ujfalusi
2020-06-01 6:51 ` [PATCH v3 03/13] backlight: improve backlight_ops documentation Sam Ravnborg
2020-06-01 6:51 ` [PATCH v3 04/13] backlight: improve backlight_properties documentation Sam Ravnborg
2020-06-01 10:10 ` Daniel Thompson
2020-06-01 6:51 ` [PATCH v3 05/13] backlight: improve backlight_device documentation Sam Ravnborg
2020-06-01 10:23 ` Daniel Thompson
2020-06-01 6:52 ` [PATCH v3 06/13] backlight: document inline functions in backlight.h Sam Ravnborg
2020-06-01 6:52 ` [PATCH v3 07/13] backlight: document enums " Sam Ravnborg
2020-06-01 6:52 ` [PATCH v3 08/13] backlight: remove the unused backlight_bl driver Sam Ravnborg
2020-06-01 6:52 ` [PATCH v3 09/13] backlight: drop extern from prototypes Sam Ravnborg
2020-06-01 6:52 ` [PATCH v3 10/13] backlight: add overview and update existing doc Sam Ravnborg
2020-06-01 10:34 ` Daniel Thompson
2020-06-01 6:52 ` [PATCH v3 11/13] backlight: wire up kernel-doc documentation Sam Ravnborg
2020-06-01 6:52 ` [PATCH v3 12/13] backlight: as3711_bl: introduce backlight_is_blank() Sam Ravnborg
2020-06-01 10:35 ` Daniel Thompson
2020-06-01 6:52 ` [PATCH v3 13/13] backlight: use backlight_is_blank() in all backlight drivers Sam Ravnborg
2020-06-01 12:28 ` Peter Ujfalusi
2020-06-01 12:39 ` Sam Ravnborg
2020-06-02 14:04 ` [PATCH v3 0/16] backlight updates Emil Velikov
2020-07-02 8:01 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200601065207.492614-2-sam@ravnborg.org \
--to=sam@ravnborg.org \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=b.zolnierkie@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=corbet@lwn.net \
--cc=daniel.thompson@linaro.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=patches@opensource.cirrus.com \
--cc=peter.ujfalusi@ti.com \
--cc=support.opensource@diasemi.com \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).