On Fri, Aug 14, 2020 at 03:59:16PM +0200, Karol Herbst wrote:
> On Fri, Aug 14, 2020 at 3:57 PM Thierry Reding <thierry.reding@gmail.com> wrote:
> >
> > On Thu, Aug 13, 2020 at 07:48:39PM +0200, Karol Herbst wrote:
> > > On Thu, Aug 13, 2020 at 7:45 PM James Jones <jajones@nvidia.com> wrote:
> > > >
> > > > I'll defer to Thierry, but I think that may be by design.  Tegra format
> > > > modifiers were added to get things like this working in the first place,
> > > > right?  It's not a regression, is it?
> > > >
> > >
> > > That would be slightly annoying as this would mean by design it's
> > > broken by default :/ Also, we have no Xorg release supporting
> > > modifiers anyway and it does seem to work with X 1.20.8 (which doesn't
> > > enable modifier support). And I talked with Jonas (working on mutter)
> > > about it and there were no plans to turn on modifier support by
> > > default at this point.
> >
> > I thought you said earlier that 1.20.8 didn't work and was hitting the
> > assertion?
> >
> 
> uhm, I forgot to mention that it works with the patch I wrote:
> https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6300

Okay, good to know. Like I said in another subthread, I think we need to
make sure that this doesn't break other use-cases. I vaguely recall that
there was one specific configuration that broke without that and I think
it was when glamor was disabled because that caused X to allocate
buffers without modifiers set. Let me try if I can reproduce such a
build somehow and check if that fails again with the revert.

Thierry