From: Maxime Ripard <maxime@cerno.tech>
To: Pekka Paalanen <ppaalanen@gmail.com>
Cc: "Deucher, Alexander" <alexander.deucher@amd.com>,
intel-gfx@lists.freedesktop.org,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
amd-gfx list <amd-gfx@lists.freedesktop.org>,
Werner Sembach <wse@tuxedocomputers.com>
Subject: Re: New uAPI for color management proposal and feedback request
Date: Wed, 16 Jun 2021 09:27:36 +0200 [thread overview]
Message-ID: <20210616072736.7lc7kiahfz7o2kod@gilmour> (raw)
In-Reply-To: <20210607110632.6ec38e38@eldfell>
Hi Pekka,
On Mon, Jun 07, 2021 at 11:06:32AM +0300, Pekka Paalanen wrote:
> On Mon, 7 Jun 2021 09:48:05 +0200
> Maxime Ripard <maxime@cerno.tech> wrote:
>
> > I've started to implement this for the raspberrypi some time ago.
> >
> > https://github.com/raspberrypi/linux/pull/4201
> >
> > It's basically two properties: a bitmask of the available output pixel
> > encoding to report both what the display and the controller supports,
> > and one to actually set what the userspace wants to get enforced (and
> > that would return the active one when read).
>
> Hi Maxime,
>
> I would like to point out that I think it is a bad design to create a
> read/write property that returns not what was written to it. It can
> cause headaches to userspace that wants to save and restore property
> values it does not understand. Userspace would want to do that to
> mitigate damage from switching to another KMS client and then back. The
> other KMS client could change properties the first KMS client does not
> understand, causing the first KMS client to show incorrectly after
> switching back.
>
> Please, consider whether this use-case will work before designing a
> property where read-back may not necessarily return the written value.
Thanks for bringing that up. I guess the work being done currently by
Werner and his active color format property addresses that concern :)
Maxime
prev parent reply other threads:[~2021-06-16 7:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 12:06 New uAPI for color management proposal and feedback request Werner Sembach
2021-05-12 13:04 ` Ville Syrjälä
2021-05-12 13:09 ` Simon Ser
2021-05-12 17:59 ` Alex Deucher
2021-05-31 17:46 ` Werner Sembach
2021-05-19 9:34 ` Pekka Paalanen
2021-05-19 13:49 ` Ville Syrjälä
2021-05-20 7:58 ` Pekka Paalanen
2021-05-31 17:55 ` Werner Sembach
2021-06-22 17:06 ` Werner Sembach
2021-06-23 7:29 ` Pekka Paalanen
2021-05-12 14:53 ` Werner Sembach
2021-05-17 14:28 ` Werner Sembach
2021-06-07 7:48 ` Maxime Ripard
2021-06-07 8:06 ` Pekka Paalanen
2021-06-16 7:27 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210616072736.7lc7kiahfz7o2kod@gilmour \
--to=maxime@cerno.tech \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ppaalanen@gmail.com \
--cc=wse@tuxedocomputers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).