From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>
Cc: "Daniel Vetter" <daniel.vetter@intel.com>,
"Christian König" <christian.koenig@amd.com>,
"Chris Wilson" <chris@chris-wilson.co.uk>
Subject: Re: [PATCH] drm/syncobj: Tune down unordered timeline DRM_ERROR
Date: Sat, 1 Aug 2020 17:39:50 +0300 [thread overview]
Message-ID: <6c320fd4-81d4-1a96-e83e-ecbdedfbd7f8@intel.com> (raw)
In-Reply-To: <20200801092625.1107609-1-daniel.vetter@ffwll.ch>
On 01/08/2020 12:26, Daniel Vetter wrote:
> Userspace can provoke this, we generally don't allow userspace to spam
> dmesg. Tune it down to debug. Unfortunately we don't have easy access
> to the drm_device here (not at all without changing a few things), so
> leave it as old style dmesg output for now.
>
> References: https://patchwork.freedesktop.org/series/80146/
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/drm_syncobj.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
> index 3bf73971daf3..6e74e6745eca 100644
> --- a/drivers/gpu/drm/drm_syncobj.c
> +++ b/drivers/gpu/drm/drm_syncobj.c
> @@ -297,7 +297,7 @@ void drm_syncobj_add_point(struct drm_syncobj *syncobj,
> prev = drm_syncobj_fence_get(syncobj);
> /* You are adding an unorder point to timeline, which could cause payload returned from query_ioctl is 0! */
> if (prev && prev->seqno >= point)
> - DRM_ERROR("You are adding an unorder point to timeline!\n");
> + DRM_DEBUG("You are adding an unorder point to timeline!\n");
> dma_fence_chain_init(chain, prev, fence, point);
> rcu_assign_pointer(syncobj->fence, &chain->base);
>
Thanks,
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-08-01 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-01 9:26 [PATCH] drm/syncobj: Tune down unordered timeline DRM_ERROR Daniel Vetter
2020-08-01 14:39 ` Lionel Landwerlin [this message]
2020-08-01 19:19 ` daniel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c320fd4-81d4-1a96-e83e-ecbdedfbd7f8@intel.com \
--to=lionel.g.landwerlin@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).