From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
jernej.skrabec@siol.net, narmstrong@baylibre.com,
airlied@linux.ie, jonas@kwiboo.se, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com,
Laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH 1/2] dt-bindings: display: bridge: Add documentation for Toshiba tc358768
Date: Tue, 14 Jan 2020 13:55:17 +0200 [thread overview]
Message-ID: <7a7067ef-3c1c-ea20-8322-6d90c2c4c680@ti.com> (raw)
In-Reply-To: <20191226222449.GA8816@bogus>
On 27/12/2019 0.24, Rob Herring wrote:
> On Tue, Dec 17, 2019 at 12:15:05PM +0200, Peter Ujfalusi wrote:
>> TC358768/TC358778 is a Parallel RGB to MIPI DSI bridge.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> ---
>> .../display/bridge/toshiba,tc358768.yaml | 158 ++++++++++++++++++
>> 1 file changed, 158 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
>> new file mode 100644
>> index 000000000000..8f96867caca0
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
>> @@ -0,0 +1,158 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/bridge/toshiba,tc358768.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Toschiba TC358768/TC358778 Parallel RGB to MIPI DSI bridge
>> +
>> +maintainers:
>> + - Peter Ujfalusi <peter.ujfalusi@ti.com>
>> +
>> +description: |
>> + The TC358768/TC358778 is bridge device which converts RGB to DSI.
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - toshiba,tc358768
>> + - toshiba,tc358778
>> +
>> + reg:
>> + maxItems: 1
>> + description: base I2C address of the device
>> +
>> + reset-gpios:
>> + maxItems: 1
>> + description: GPIO connected to active low RESX pin
>> +
>> + vddc-supply:
>> + maxItems: 1
>
> Drop this. Not an array. *-supply doesn't need further constraints.
OK.
>
>> + description: Regulator for 1.2V internal core power.
>> +
>> + vddmipi-supply:
>> + maxItems: 1
>> + description: Regulator for 1.2V for the MIPI.
>> +
>> + vddio-supply:
>> + maxItems: 1
>> + description: Regulator for 1.8V - 3.3V IO power.
>
> Blank line here.
Oops, I'll fix it.
>
>> + clocks:
>> + maxItems: 1
>> +
>> + clock-names:
>> + const: refclk
>> +
>> + ports:
>> + type: object
>> +
>> + properties:
>> + "#address-cells":
>> + const: 1
>> +
>> + "#size-cells":
>> + const: 0
>> +
>> + port@0:
>> + type: object
>> + additionalProperties: false
>> +
>> + description: |
>> + Video port for RGB input
>> +
>> + properties:
>> + reg:
>> + const: 0
>> +
>> + patternProperties:
>> + endpoint:
>> + type: object
>> + additionalProperties: false
>> +
>> + properties:
>> + data-lines:
>> + enum: [ 16, 18, 24 ]
>> +
>> + remote-endpoint: true
>> +
>> + required:
>> + - reg
>> +
>> + port@1:
>> + type: object
>> + description: |
>> + Video port for DSI output (panel or connector).
>> +
>> + properties:
>> + reg:
>> + const: 1
>> +
>> + patternProperties:
>> + endpoint:
>> + type: object
>> + additionalProperties: false
>> +
>> + properties:
>> + remote-endpoint: true
>> +
>> + required:
>> + - reg
>
> No additionalProperties on this one?
Correct, I have missed the additionalProperties: false
I'll update the binding documents when I get comments for the driver.
Thank you,
- Péter
>
>> +
>> + required:
>> + - "#address-cells"
>> + - "#size-cells"
>> + - port@0
>> + - port@1
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - vddc-supply
>> + - vddmipi-supply
>> + - vddio-supply
>> + - ports
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + i2c1 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + dsi_bridge: tc358768@0e {
>> + compatible = "toshiba,tc358768";
>> + reg = <0x0e>;
>> +
>> + clocks = <&tc358768_refclk>;
>> + clock-names = "refclk";
>> +
>> + /* GPIO line is inverted before going to the bridge */
>> + reset-gpios = <&pcf_display_board 0 1 /* GPIO_ACTIVE_LOW */>;
>> +
>> + vddc-supply = <&v1_2d>;
>> + vddmipi-supply = <&v1_2d>;
>> + vddio-supply = <&v3_3d>;
>> +
>> + dsi_bridge_ports: ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@0 {
>> + reg = <0>;
>> + rgb_in: endpoint {
>> + remote-endpoint = <&dpi_out>;
>> + data-lines = <24>;
>> + };
>> + };
>> +
>> + port@1 {
>> + reg = <1>;
>> + dsi_out: endpoint {
>> + remote-endpoint = <&lcd_in>;
>> + };
>> + };
>> + };
>> + };
>> + };
>> +
>> --
>> Peter
>>
>> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
>> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>>
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-14 11:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 10:15 [PATCH 0/2] drm/bridge: Support for Toshiba tc358768 RGB to DSI bridge Peter Ujfalusi
2019-12-17 10:15 ` [PATCH 1/2] dt-bindings: display: bridge: Add documentation for Toshiba tc358768 Peter Ujfalusi
2019-12-26 22:24 ` Rob Herring
2020-01-14 11:55 ` Peter Ujfalusi [this message]
2019-12-17 10:15 ` [PATCH 2/2] drm/bridge: Add tc358768 driver Peter Ujfalusi
2020-01-16 14:35 ` Andrzej Hajda
2020-01-21 15:11 ` Peter Ujfalusi
2020-01-22 8:46 ` Andrzej Hajda
2020-01-22 9:16 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a7067ef-3c1c-ea20-8322-6d90c2c4c680@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=narmstrong@baylibre.com \
--cc=robh@kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).