From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06A8FC433E0 for ; Mon, 25 May 2020 12:49:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D4781206D5 for ; Mon, 25 May 2020 12:49:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4781206D5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4DE6E6E079; Mon, 25 May 2020 12:49:54 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8D45F6E079 for ; Mon, 25 May 2020 12:49:53 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id AE802AB89; Mon, 25 May 2020 12:49:53 +0000 (UTC) Subject: Re: [PATCH 15/21] drm/rcar-du: Use GEM CMA object functions To: Laurent Pinchart References: <20200522135246.10134-1-tzimmermann@suse.de> <20200522135246.10134-16-tzimmermann@suse.de> <20200522201240.GE5824@pendragon.ideasonboard.com> From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= mQENBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAG0J1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPokBVAQTAQgAPhYh BHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJbOdLgAhsDBQkDwmcABQsJCAcCBhUKCQgLAgQWAgMB Ah4BAheAAAoJEGgNwR1TC3ojR80H/jH+vYavwQ+TvO8ksXL9JQWc3IFSiGpuSVXLCdg62AmR irxW+qCwNncNQyb9rd30gzdectSkPWL3KSqEResBe24IbA5/jSkPweJasgXtfhuyoeCJ6PXo clQQGKIoFIAEv1s8l0ggPZswvCinegl1diyJXUXmdEJRTWYAtxn/atut1o6Giv6D2qmYbXN7 mneMC5MzlLaJKUtoH7U/IjVw1sx2qtxAZGKVm4RZxPnMCp9E1MAr5t4dP5gJCIiqsdrVqI6i KupZstMxstPU//azmz7ZWWxT0JzgJqZSvPYx/SATeexTYBP47YFyri4jnsty2ErS91E6H8os Bv6pnSn7eAq5AQ0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRH UE9eosYbT6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgT RjP+qbU63Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+R dhgATnWWGKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zb ehDda8lvhFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r 12+lqdsAEQEAAYkBPAQYAQgAJhYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJbOdLgAhsMBQkD wmcAAAoJEGgNwR1TC3ojpfcIAInwP5OlcEKokTnHCiDTz4Ony4GnHRP2fXATQZCKxmu4AJY2 h9ifw9Nf2TjCZ6AMvC3thAN0rFDj55N9l4s1CpaDo4J+0fkrHuyNacnT206CeJV1E7NYntxU n+LSiRrOdywn6erjxRi9EYTVLCHcDhBEjKmFZfg4AM4GZMWX1lg0+eHbd5oL1as28WvvI/uI aMyV8RbyXot1r/8QLlWldU3NrTF5p7TMU2y3ZH2mf5suSKHAMtbE4jKJ8ZHFOo3GhLgjVrBW HE9JXO08xKkgD+w6v83+nomsEuf6C6LYrqY/tsZvyEX6zN8CtirPdPWu/VXNRYAl/lat7lSI 3H26qrE= Message-ID: <816a8a0e-bb98-ea6c-5016-94b18e045fb5@suse.de> Date: Mon, 25 May 2020 14:49:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200522201240.GE5824@pendragon.ideasonboard.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, linux-aspeed@lists.ozlabs.org, narmstrong@baylibre.com, airlied@linux.ie, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, nicolas.ferre@microchip.com, paul@crapouillou.net, mihail.atanassov@arm.com, sam@ravnborg.org, marex@denx.de, khilman@baylibre.com, abrodkin@synopsys.com, kong.kongxinwei@hisilicon.com, xinliang.liu@linaro.org, ludovic.desroches@microchip.com, tomi.valkeinen@ti.com, james.qian.wang@arm.com, joel@jms.id.au, linux-imx@nxp.com, alexandre.torgue@st.com, puck.chen@hisilicon.com, s.hauer@pengutronix.de, alison.wang@nxp.com, jsarha@ti.com, wens@csie.org, vincent.abriou@st.com, linux-arm-kernel@lists.infradead.org, mcoquelin.stm32@gmail.com, bbrezillon@kernel.org, andrew@aj.id.au, philippe.cornu@st.com, yannick.fertre@st.com, kieran.bingham+renesas@ideasonboard.com, kernel@pengutronix.de, zourongrong@gmail.com, shawnguo@kernel.org Content-Type: multipart/mixed; boundary="===============0303630793==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0303630793== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zWmtLOD2c6I7VXia1IXBS6p6v0gzUt5ej" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --zWmtLOD2c6I7VXia1IXBS6p6v0gzUt5ej Content-Type: multipart/mixed; boundary="NhtYAlFwvx6IarH0OpVBAdhKK1CTcHOrZ"; protected-headers="v1" From: Thomas Zimmermann To: Laurent Pinchart Cc: alexandre.belloni@bootlin.com, linux-aspeed@lists.ozlabs.org, narmstrong@baylibre.com, airlied@linux.ie, liviu.dudau@arm.com, philippe.cornu@st.com, paul@crapouillou.net, mihail.atanassov@arm.com, sam@ravnborg.org, alexandre.torgue@st.com, marex@denx.de, abrodkin@synopsys.com, ludovic.desroches@microchip.com, xinliang.liu@linaro.org, kong.kongxinwei@hisilicon.com, tomi.valkeinen@ti.com, james.qian.wang@arm.com, joel@jms.id.au, linux-imx@nxp.com, puck.chen@hisilicon.com, s.hauer@pengutronix.de, alison.wang@nxp.com, jsarha@ti.com, wens@csie.org, vincent.abriou@st.com, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, mcoquelin.stm32@gmail.com, bbrezillon@kernel.org, andrew@aj.id.au, dri-devel@lists.freedesktop.org, nicolas.ferre@microchip.com, yannick.fertre@st.com, kieran.bingham+renesas@ideasonboard.com, khilman@baylibre.com, zourongrong@gmail.com, shawnguo@kernel.org Message-ID: <816a8a0e-bb98-ea6c-5016-94b18e045fb5@suse.de> Subject: Re: [PATCH 15/21] drm/rcar-du: Use GEM CMA object functions References: <20200522135246.10134-1-tzimmermann@suse.de> <20200522135246.10134-16-tzimmermann@suse.de> <20200522201240.GE5824@pendragon.ideasonboard.com> In-Reply-To: <20200522201240.GE5824@pendragon.ideasonboard.com> --NhtYAlFwvx6IarH0OpVBAdhKK1CTcHOrZ Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 22.05.20 um 22:12 schrieb Laurent Pinchart: > Hi Thomas, >=20 > Thank you for the patch. >=20 > On Fri, May 22, 2020 at 03:52:40PM +0200, Thomas Zimmermann wrote: >> The rcar-du driver uses the default implementation for CMA functions; >> except for the .dumb_create callback. The __DRM_GEM_CMA_DRIVER_OPS mac= ro >> now sets these defaults and .dumb_create in struct drm_driver. All >> remaining operations are provided by CMA GEM object functions. >> >> Signed-off-by: Thomas Zimmermann >> --- >> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 11 +---------- >> 1 file changed, 1 insertion(+), 10 deletions(-) >> >> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/r= car-du/rcar_du_drv.c >> index 3e67cf70f0402..3728038cec1d1 100644 >> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c >> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c >> @@ -476,16 +476,7 @@ DEFINE_DRM_GEM_CMA_FOPS(rcar_du_fops); >> =20 >> static struct drm_driver rcar_du_driver =3D { >> .driver_features =3D DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, >> - .gem_free_object_unlocked =3D drm_gem_cma_free_object, >> - .gem_vm_ops =3D &drm_gem_cma_vm_ops, >> - .prime_handle_to_fd =3D drm_gem_prime_handle_to_fd, >> - .prime_fd_to_handle =3D drm_gem_prime_fd_to_handle, >> - .gem_prime_get_sg_table =3D drm_gem_cma_prime_get_sg_table, >> - .gem_prime_import_sg_table =3D drm_gem_cma_prime_import_sg_table, >> - .gem_prime_vmap =3D drm_gem_cma_prime_vmap, >> - .gem_prime_vunmap =3D drm_gem_cma_prime_vunmap, >> - .gem_prime_mmap =3D drm_gem_cma_prime_mmap, >> - .dumb_create =3D rcar_du_dumb_create, >> + __DRM_GEM_CMA_DRIVER_OPS(rcar_du_dumb_create), >=20 > Your __DRM_GEM_CMA_DRIVER_OPS is defined as >=20 > #define __DRM_GEM_CMA_DRIVER_OPS(__dumb_create) \ > .gem_create_object =3D drm_cma_gem_create_object_default_f= uncs, \ > .dumb_create =3D (__dumb_create), \ > .prime_handle_to_fd =3D drm_gem_prime_handle_to_fd, \ > .prime_fd_to_handle =3D drm_gem_prime_fd_to_handle, \ > .gem_prime_import_sg_table =3D drm_gem_cma_prime_import_sg_tabl= e_vmap, \ > .gem_prime_mmap =3D drm_gem_prime_mmap >=20 > The patch thus introduces several changes: >=20 > - drm_gem_cma_prime_import_sg_table_vmap() is used instead of > drm_gem_cma_prime_import_sg_table() combined with .gem_prime_vmap() > and .gem_prime_vunmap(). I believe that's fine, but splitting that > change in a separate commit, or at the very least explaining it in > details in the commit message, would make review easier. >=20 > - .gem_create_object() is now set. That seems to be OK, but I'm not sur= e > to grasp all the implications. This should also be explained in the > commit message, and ideally split to a separate patch. That's relevant during object creation and sets the object functions. See one of my other replies for how this can go away after all CMA drivers have been updated to GEM object functions. >=20 > - drm_gem_cma_prime_mmap() is replaced with drm_gem_prime_mmap(). Same > comments :-) I relied on the aspeed driver to be correct. After Sam's comment on that, I read the code once again several times. The original implementation clears VM_PFNMAP. And I cannot find that code any longer. Going back to the original function might be better. >=20 > This patch hides way too many changes in what is documented as just > innocent refactoring. It seems other drivers are affected too. Could you test the patchset? I don't have the HW. Best regards Thomas >=20 >> .fops =3D &rcar_du_fops, >> .name =3D "rcar-du", >> .desc =3D "Renesas R-Car Display Unit", >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --NhtYAlFwvx6IarH0OpVBAdhKK1CTcHOrZ-- --zWmtLOD2c6I7VXia1IXBS6p6v0gzUt5ej Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEchf7rIzpz2NEoWjlaA3BHVMLeiMFAl7LvuoACgkQaA3BHVML eiOBxAgAtowKnLP+2yRiktf4G0120f45ByObXkHxpQXecWNIcEWvbk+OCuSpeotr ctg4ZnV7zFliLVPqI9YJkIpISOVgZYZ+4D/U81Hw5AQftBnjL0eZoz5qal5ST6ld gWLqU5Jx3fVnhcJcKacd/AP2zYe3fDecKR76rstq6AhC5T1TXKZ7U4CfGD6AvIGn tckUJaPWJwg5aJjYPMhCC+/WBLbXs6StqzxcGmwGy3J2pTI332OFsyIZHn31J52U O2ZPOJe/Eyp31mBHS6bM3JNf1Tjs+PBnF28XOynb4qq67tjD73b6DuSc2KWuqL+9 sNX1JHsIiFNYGx57vubv5h084LO53w== =5kJT -----END PGP SIGNATURE----- --zWmtLOD2c6I7VXia1IXBS6p6v0gzUt5ej-- --===============0303630793== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0303630793==--