From: Samuel Holland <samuel.holland@sifive.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Leo Li" <sunpeng.li@amd.com>, "Pan Xinhui" <Xinhui.Pan@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
"Palmer Dabbelt" <palmer@dabbelt.com>,
amd-gfx@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
linux-riscv@lists.infradead.org,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 1/3] riscv: Add support for kernel-mode FPU
Date: Thu, 7 Dec 2023 22:17:01 -0600 [thread overview]
Message-ID: <86d857bf-a833-4529-aba9-391c49a3550b@sifive.com> (raw)
In-Reply-To: <ZV283NfE/K5zLXDD@infradead.org>
Hi Christoph,
On 2023-11-22 2:33 AM, Christoph Hellwig wrote:
> On Tue, Nov 21, 2023 at 07:05:13PM -0800, Samuel Holland wrote:
>> +static inline void kernel_fpu_begin(void)
>> +{
>> + preempt_disable();
>> + fstate_save(current, task_pt_regs(current));
>> + csr_set(CSR_SSTATUS, SR_FS);
>> +}
>> +
>> +static inline void kernel_fpu_end(void)
>> +{
>> + csr_clear(CSR_SSTATUS, SR_FS);
>> + fstate_restore(current, task_pt_regs(current));
>> + preempt_enable();
>> +}
>
> Is there any critical reason to inline these two? I'd much rather see
> them out of line and exported instead of the low-level helpers.
No, I will define them out of line in v2.
Regards,
Samuel
next prev parent reply other threads:[~2023-12-08 8:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 3:05 [PATCH 0/3] riscv: Add kernel-mode FPU support for amdgpu Samuel Holland
2023-11-22 3:05 ` [PATCH 1/3] riscv: Add support for kernel-mode FPU Samuel Holland
2023-11-22 20:23 ` kernel test robot
2023-11-23 1:54 ` kernel test robot
[not found] ` <ZV283NfE/K5zLXDD@infradead.org>
2023-12-08 4:17 ` Samuel Holland [this message]
2023-11-22 3:05 ` [PATCH 2/3] riscv: Factor out riscv-march-y to a separate Makefile Samuel Holland
2023-11-22 3:05 ` [PATCH 3/3] drm/amd/display: Support DRM_AMD_DC_FP on RISC-V Samuel Holland
2023-11-23 14:23 ` Conor Dooley
2023-11-30 0:42 ` Nathan Chancellor
2023-11-30 8:27 ` Conor Dooley
2023-12-08 5:04 ` Samuel Holland
2023-12-09 20:38 ` Arnd Bergmann
2023-12-09 21:29 ` Samuel Holland
2023-12-09 21:42 ` Arnd Bergmann
2023-12-11 15:17 ` Alex Deucher
2023-12-11 15:40 ` Samuel Holland
[not found] ` <ZV2+f/yu3C6xTVqn@infradead.org>
2023-12-08 4:49 ` Samuel Holland
[not found] ` <ZXgH6un2uLdjQ48X@infradead.org>
2023-12-12 17:42 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86d857bf-a833-4529-aba9-391c49a3550b@sifive.com \
--to=samuel.holland@sifive.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).