From: Steven Price <steven.price@arm.com>
To: Lukasz Luba <lukasz.luba@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-imx@nxp.com" <linux-imx@nxp.com>
Cc: "nm@ti.com" <nm@ti.com>,
"juri.lelli@redhat.com" <juri.lelli@redhat.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
"Liviu Dudau" <Liviu.Dudau@arm.com>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"bsegall@google.com" <bsegall@google.com>,
"Morten Rasmussen" <Morten.Rasmussen@arm.com>,
"amit.kucheria@verdurent.com" <amit.kucheria@verdurent.com>,
"Lorenzo Pieralisi" <Lorenzo.Pieralisi@arm.com>,
"vincent.guittot@linaro.org" <vincent.guittot@linaro.org>,
"khilman@kernel.org" <khilman@kernel.org>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"Javi Merino Cacho" <Javi.MerinoCacho@arm.com>,
"cw00.choi@samsung.com" <cw00.choi@samsung.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"mgorman@suse.de" <mgorman@suse.de>,
"rui.zhang@intel.com" <rui.zhang@intel.com>,
"alyssa.rosenzweig@collabora.com"
<alyssa.rosenzweig@collabora.com>,
"Ørjan Eide" <Orjan.Eide@arm.com>,
"b.zolnierkie@samsung.com" <b.zolnierkie@samsung.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"Dietmar Eggemann" <Dietmar.Eggemann@arm.com>,
"airlied@linux.ie" <airlied@linux.ie>,
"tomeu.vizoso@collabora.com" <tomeu.vizoso@collabora.com>,
"qperret@google.com" <qperret@google.com>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"agross@kernel.org" <agross@kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"Sudeep Holla" <Sudeep.Holla@arm.com>,
"patrick.bellasi@matbug.net" <patrick.bellasi@matbug.net>,
"shawnguo@kernel.org" <shawnguo@kernel.org>
Subject: Re: [PATCH v4 4/4] drm/panfrost: Register devfreq cooling and attempt to add Energy Model
Date: Mon, 9 Mar 2020 14:15:20 +0000 [thread overview]
Message-ID: <9747ca5c-ba4c-521f-11c1-45ee6a5018e3@arm.com> (raw)
In-Reply-To: <20200309134117.2331-5-lukasz.luba@arm.com>
On 09/03/2020 13:41, Lukasz Luba wrote:
> Register devfreq cooling device and attempt to register Energy Model. This
> will add the devfreq device to the Energy Model framework. It will create
> a dedicated and unified data structures used i.e. in thermal framework.
> The last NULL parameter indicates that the power model is simplified and
> created based on DT 'dynamic-power-coefficient', voltage and frequency.
>
> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
LGTM!
Reviewed-by: Steven Price <steven.price@arm.com>
> ---
> drivers/gpu/drm/panfrost/panfrost_devfreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
> index 413987038fbf..8759a73db153 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
> @@ -105,7 +105,7 @@ int panfrost_devfreq_init(struct panfrost_device *pfdev)
> }
> pfdev->devfreq.devfreq = devfreq;
>
> - cooling = of_devfreq_cooling_register(dev->of_node, devfreq);
> + cooling = devfreq_cooling_em_register(devfreq, NULL);
> if (IS_ERR(cooling))
> DRM_DEV_INFO(dev, "Failed to register cooling device\n");
> else
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-09 14:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 13:41 [PATCH v4 0/4] Add support for devices in the Energy Model Lukasz Luba
2020-03-09 13:41 ` [PATCH v4 1/4] PM / EM: add devices to " Lukasz Luba
2020-03-13 10:04 ` Quentin Perret
2020-03-13 10:05 ` Quentin Perret
2020-03-13 16:49 ` Lukasz Luba
2020-03-13 17:15 ` Quentin Perret
2020-03-09 13:41 ` [PATCH v4 2/4] OPP: change parameter to device pointer in dev_pm_opp_of_register_em() Lukasz Luba
2020-03-13 10:15 ` Quentin Perret
2020-03-13 17:11 ` Lukasz Luba
2020-03-13 17:16 ` Quentin Perret
2020-03-09 13:41 ` [PATCH v4 3/4] thermal: devfreq_cooling: Refactor code and switch to use Energy Model Lukasz Luba
2020-03-09 13:41 ` [PATCH v4 4/4] drm/panfrost: Register devfreq cooling and attempt to add " Lukasz Luba
2020-03-09 14:15 ` Steven Price [this message]
2020-03-13 16:51 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9747ca5c-ba4c-521f-11c1-45ee6a5018e3@arm.com \
--to=steven.price@arm.com \
--cc=Dietmar.Eggemann@arm.com \
--cc=Javi.MerinoCacho@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=Morten.Rasmussen@arm.com \
--cc=Orjan.Eide@arm.com \
--cc=Sudeep.Holla@arm.com \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=alyssa.rosenzweig@collabora.com \
--cc=amit.kucheria@verdurent.com \
--cc=b.zolnierkie@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=bsegall@google.com \
--cc=cw00.choi@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=juri.lelli@redhat.com \
--cc=kernel@pengutronix.de \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=nm@ti.com \
--cc=patrick.bellasi@matbug.net \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=rdunlap@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=rostedt@goodmis.org \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tomeu.vizoso@collabora.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).