From: Kirti Wankhede <kwankhede@nvidia.com>
To: Christoph Hellwig <hch@lst.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jason Gunthorpe <jgg@nvidia.com>,
"Alex Williamson" <alex.williamson@redhat.com>
Cc: Tony Krowiak <akrowiak@linux.ibm.com>,
Jason Herne <jjherne@linux.ibm.com>,
kvm@vger.kernel.org, Vasily Gorbik <gor@linux.ibm.com>,
Jonathan Corbet <corbet@lwn.net>, David Airlie <airlied@linux.ie>,
linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 08/10] vfio/mtty: Convert to use vfio_register_group_dev()
Date: Thu, 17 Jun 2021 01:50:49 +0530 [thread overview]
Message-ID: <9e2d3a44-1371-d8c8-844f-69a29699a13d@nvidia.com> (raw)
In-Reply-To: <20210615133519.754763-9-hch@lst.de>
> -static int mtty_reset(struct mdev_device *mdev)
> +static int mtty_reset(struct mdev_state *mdev_stte)
Nit pick:
s/mdev_stte/mdev_state
>
> +static const struct vfio_device_ops mtty_dev_ops = {
> + .name = "vfio-mdev",
I think name should be different that 'vfio-mdev', probably
'vfio-mdev-mtty' or 'vfio-mtty'
Rest looks fine to me.
Reviewed-by: Kirti Wankhede <kwankhede@nvidia.com>
prev parent reply other threads:[~2021-06-16 20:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210615133519.754763-1-hch@lst.de>
[not found] ` <20210615133519.754763-5-hch@lst.de>
2021-06-15 14:03 ` [PATCH 04/10] driver core: Don't return EPROBE_DEFER to userspace during sysfs bind Cornelia Huck
2021-06-15 19:36 ` Alex Williamson
[not found] ` <20210615133519.754763-8-hch@lst.de>
2021-06-15 14:06 ` [PATCH 07/10] vfio/mdev: Allow the mdev_parent_ops to specify the device driver to bind Cornelia Huck
2021-06-15 14:11 ` Greg Kroah-Hartman
2021-06-16 0:00 ` Jason Gunthorpe
2021-06-16 6:39 ` Greg Kroah-Hartman
2021-06-16 20:20 ` Kirti Wankhede
[not found] ` <20210615133519.754763-6-hch@lst.de>
2021-06-15 14:10 ` [PATCH 05/10] driver core: Export device_driver_attach() Greg Kroah-Hartman
[not found] ` <20210615133519.754763-10-hch@lst.de>
2021-06-15 14:12 ` [PATCH 09/10] vfio/mdpy: Convert to use vfio_register_group_dev() Greg Kroah-Hartman
[not found] ` <20210615133519.754763-11-hch@lst.de>
2021-06-15 14:12 ` [PATCH 10/10] vfio/mbochs: " Greg Kroah-Hartman
2021-06-15 19:35 ` Allow mdev drivers to directly create the vfio_device (v3) Alex Williamson
2021-06-15 20:35 ` Jason Gunthorpe
[not found] ` <20210616031313.GA24992@lst.de>
2021-06-16 14:03 ` Jason Gunthorpe
[not found] ` <20210615133519.754763-3-hch@lst.de>
2021-06-15 13:53 ` [PATCH 02/10] driver core: Better distinguish probe errors in really_probe Cornelia Huck
2021-06-15 14:09 ` Greg Kroah-Hartman
2021-06-15 14:09 ` Greg Kroah-Hartman
2021-06-16 20:20 ` Kirti Wankhede
[not found] ` <20210615133519.754763-7-hch@lst.de>
2021-06-15 14:10 ` [PATCH 06/10] vfio/mdev: Remove CONFIG_VFIO_MDEV_DEVICE Greg Kroah-Hartman
2021-06-16 20:20 ` Kirti Wankhede
[not found] ` <20210615133519.754763-9-hch@lst.de>
2021-06-15 14:11 ` [PATCH 08/10] vfio/mtty: Convert to use vfio_register_group_dev() Greg Kroah-Hartman
2021-06-16 20:20 ` Kirti Wankhede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e2d3a44-1371-d8c8-844f-69a29699a13d@nvidia.com \
--to=kwankhede@nvidia.com \
--cc=airlied@linux.ie \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hca@linux.ibm.com \
--cc=hch@lst.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jgg@nvidia.com \
--cc=jjherne@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=rafael@kernel.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).