From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35A9AC433B4 for ; Thu, 13 May 2021 23:42:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D37AE6143C for ; Thu, 13 May 2021 23:42:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D37AE6143C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 03C696EDED; Thu, 13 May 2021 23:42:18 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 140AA6EDED for ; Thu, 13 May 2021 23:42:17 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id AA5AE6143C for ; Thu, 13 May 2021 23:42:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620949336; bh=Q+ZtNVyGmIl0eXIQdcuUrxm022erUcWDgP5SQNOKYQs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=iH49wNJ+6khauFhNYkW4TjYuSUoVNxpNAXZwdwX1vzihY0Q/34epUJFzJ1oKStd42 WZAsWkiNHkMrVshVnZyX9l06691jq9xHRcRuhboOHs0sSxTd743O2L9mnvP6Dy4//5 at++XhheqRV58LqTyVD2TYMsYsRfkrcCFQ4Y7kjh7wFUezH6ACP8dHk/Gd8gvKFVwv GB0WzLc0DZ0amS16V59vFKKOHpJlHASkBkV8HfFarusvPeESM1BwulNWbue2EKaaiJ mK6zQyBivpA0SCi03Jdeq707COQjTm9ON/Q/HYni9EDWx85PYqigEDbRFLdfUmfOLB KU5Dg6bY8VpgQ== Received: by mail-ej1-f53.google.com with SMTP id u21so42138849ejo.13 for ; Thu, 13 May 2021 16:42:16 -0700 (PDT) X-Gm-Message-State: AOAM532px94TTizNTj0HVvbQQ8awJz0zXsC6ZSp5Jzyow5WgdPj/AGE9 h38iUL/9Qcv8veCK+4tUMR4kk8MJpFywKjz+XQ== X-Google-Smtp-Source: ABdhPJwjsoRig7IOCycfYr7+vBwT5PLJsBVb7geAGrFTpeUYk95619iAQHs5U3NzTbepCRoakv8rIPSUJ04vCjqg1co= X-Received: by 2002:a17:906:3da9:: with SMTP id y9mr46028343ejh.303.1620949335233; Thu, 13 May 2021 16:42:15 -0700 (PDT) MIME-Version: 1.0 References: <20210410034841.16567-1-wangli74@huawei.com> In-Reply-To: From: Chun-Kuang Hu Date: Fri, 14 May 2021 07:42:04 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH -next] drm/mediatek: Fix PM reference leak in mtk_crtc_ddp_hw_init() To: Chun-Kuang Hu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , kernel-janitors@vger.kernel.org, linux-kernel , DRI Development , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Wang Li , Linux ARM Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, Wang: Chun-Kuang Hu =E6=96=BC 2021=E5=B9=B44=E6=9C=8812= =E6=97=A5 =E9=80=B1=E4=B8=80 =E4=B8=8B=E5=8D=8811:32=E5=AF=AB=E9=81=93=EF= =BC=9A > > Hi, Wang: > > Wang Li =E6=96=BC 2021=E5=B9=B44=E6=9C=8810=E6=97= =A5 =E9=80=B1=E5=85=AD =E4=B8=8A=E5=8D=8811:31=E5=AF=AB=E9=81=93=EF=BC=9A > > > > pm_runtime_get_sync will increment pm usage counter even it failed. > > Forgetting to putting operation will result in reference leak here. > > Fix it by replacing it with pm_runtime_resume_and_get to keep usage > > counter balanced. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/= log/?h=3Dmediatek-drm-next Regards, Chun-Kuang. > > Reviewed-by: Chun-Kuang Hu > > > > > Reported-by: Hulk Robot > > Signed-off-by: Wang Li > > --- > > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/= mediatek/mtk_drm_crtc.c > > index 54ab3a324752..f1954242d8f6 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > > @@ -259,7 +259,7 @@ static int mtk_crtc_ddp_hw_init(struct mtk_drm_crtc= *mtk_crtc) > > drm_connector_list_iter_end(&conn_iter); > > } > > > > - ret =3D pm_runtime_get_sync(crtc->dev->dev); > > + ret =3D pm_runtime_resume_and_get(crtc->dev->dev); > > if (ret < 0) { > > DRM_ERROR("Failed to enable power domain: %d\n", ret); > > return ret; > > -- > > 2.17.1 > >