From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 704F3C3F2D1 for ; Wed, 4 Mar 2020 14:01:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4252520838 for ; Wed, 4 Mar 2020 14:01:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fFZcE7Ng" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4252520838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 87B6B89F71; Wed, 4 Mar 2020 14:01:14 +0000 (UTC) Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2DB5D89F71 for ; Wed, 4 Mar 2020 14:01:13 +0000 (UTC) Received: by mail-lj1-x242.google.com with SMTP id u26so2128273ljd.8 for ; Wed, 04 Mar 2020 06:01:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GNeKC6MusMqKfuf28ds5x+mPTx64kf5JJ4+evgJaymk=; b=fFZcE7NgmAHr8Wb6FuscsVq92KPUCCoJZOnhygbqD2fB+Pj7Y1SFEg6gFsxKhrVTSU bVqUO2vvAi/OuLhCp78ZwRKDhwhWsXv2dMv8MO0zu/bjGudolZBi13UG+NuCIhw844vZ 3rHn4dSd6CdFKgDc8DzpC+NsUzyTYyFgxbDOiytKKgMe0kj7OIFI2RYxX3iJx3xbKYBW GQHMmGZEbfGLSDtpNK54Odg+0EDT9GP4aURHBWbmgy04esNK13bSmStp0lclUDt+0xhN 26+kGFe4tf/pi3484lUUT5SUfLCCi+hXlhAj/ffVEoEbCdb+sCmIHHxQ+8PXmvaIcO8V vr0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GNeKC6MusMqKfuf28ds5x+mPTx64kf5JJ4+evgJaymk=; b=Z3uO2zdoklV2QQvWDSQznWLyyvrrxgxAMkeY74MCtdIZ7CLVPnPGCtf3Vm1aVdKg1F yCoEfhGJOYLa6hLf8UoEniDhdgMx/rZ18ECW1Gwt6OQu+ghwscyU4DGh23oXTQZwYN5+ cGYRGUmafCIvPgSXeJhlDlfoDsBgYIGbJeK+PH5XF8WdmPTUkEfTjckXIqGx63ZcXG6R KZ0eSC2WzFw6CFHvVjpDXt2t5cHjigBQ/wwoDCcVXpFDre+K2c/6B89+q33WGbbF1thB N2zdbFkxVLBNoET+hdMwNmMdcaWSJ7lOFIUVxFMZY+5VRvKO5PlH/T+o3OvzCsCFvR8j wftw== X-Gm-Message-State: ANhLgQ2+auLzBLNuRqkVYu4uu0EDEjf9CswkDWkGajVdCxe66x9cZaDO rY3uoHbbT/EnlS/XQRrZY57c4FZOaJ9og30nuHZuug== X-Google-Smtp-Source: ADFU+vteBJ/sXT2MspwGyZlMPI7U0HD2WjxGSK7LJEN8aJDfs1TgvMZ/HJ7vXCwAASAk7rsAtmIEbVd7WJFkdTocF0E= X-Received: by 2002:a05:651c:44b:: with SMTP id g11mr2049399ljg.168.1583330471526; Wed, 04 Mar 2020 06:01:11 -0800 (PST) MIME-Version: 1.0 References: <20200302203452.17977-1-ville.syrjala@linux.intel.com> <20200302203452.17977-34-ville.syrjala@linux.intel.com> In-Reply-To: From: Linus Walleij Date: Wed, 4 Mar 2020 15:00:56 +0100 Message-ID: Subject: Re: [PATCH 33/33] drm/panel-simple: Fix dotclock for LG ACX467AKM-7 To: Jonathan Marek X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:DRM PANEL DRIVERS" , Brian Masney Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Mar 4, 2020 at 2:17 PM Jonathan Marek wrote: [hs_rate / lp_rate] > The msm DSI driver does predate the addition of those fields and doesn't > use them at all. I think it would be benficient to switch to these fields, because then the .clock field (dot/pixelclock) is not abused to contain what I guess is the desires hs_rate. > Seems like it would be a bit of a hack too, since the frequency we want > to use is not the "real limits of the hardware".. That just means "clock it as high as the panel can take". Normally that would come from the vendor datasheet of the panel. If you don't have the datasheet, whatever you use in the vendor tree is fine, I suppose what is currently in .clock is fine. Yours, Linus Walleij _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel