From: Doug Anderson <dianders@chromium.org>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
Jonas Karlman <jonas@kwiboo.se>,
Neil Armstrong <narmstrong@baylibre.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Stephen Boyd <swboyd@chromium.org>,
linux-renesas-soc@vger.kernel.org,
Andrzej Hajda <a.hajda@samsung.com>
Subject: Re: [RFC PATCH 03/11] drm/bridge: ti-sn65dsi86: Unregister AUX adapter in remove()
Date: Tue, 23 Mar 2021 14:08:42 -0700 [thread overview]
Message-ID: <CAD=FV=W-+aS25wtnSmF8tWSDHTdNCjbFj0x02-1iqZ2p5qYzyA@mail.gmail.com> (raw)
In-Reply-To: <20210322030128.2283-4-laurent.pinchart+renesas@ideasonboard.com>
Hi,
On Sun, Mar 21, 2021 at 8:02 PM Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
>
> The AUX adapter registered in probe() need to be unregistered in
> remove(). Do so.
>
> Fixes: b814ec6d4535 ("drm/bridge: ti-sn65dsi86: Implement AUX channel")
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> index da78a12e58b5..c45420a50e73 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> @@ -1307,6 +1307,9 @@ static int ti_sn_bridge_remove(struct i2c_client *client)
> return -EINVAL;
>
> kfree(pdata->edid);
> +
> + drm_dp_aux_unregister(&pdata->aux);
> +
> ti_sn_debugfs_remove(pdata);
>
> of_node_put(pdata->host_node);
Good catch. One question, though. I know DRM sometimes has different
conventions than the rest of the kernel, but I always look for the
"remove" to be backwards of probe. That means that your code (and
probably most of the remove function) should come _after_ the
drm_bridge_remove(), right? ...since drm_bridge_add() was the last
thing in probe then drm_bridge_remove() should be the first thing in
remove?
-Doug
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-03-23 21:08 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 3:01 [RFC PATCH 00/11] drm/bridge: ti-sn65dsi86: Support DisplayPort mode Laurent Pinchart
2021-03-22 3:01 ` [RFC PATCH 01/11] dt-bindings: drm/bridge: ti-sn65dsi8: Make enable GPIO optional Laurent Pinchart
2021-03-22 10:29 ` Jagan Teki
2021-03-23 7:10 ` Stephen Boyd
2021-03-23 21:08 ` Doug Anderson
2021-03-27 16:42 ` Rob Herring
2021-03-22 3:01 ` [RFC PATCH 02/11] drm/bridge: ti-sn65dsi86: " Laurent Pinchart
2021-03-22 10:29 ` Jagan Teki
2021-03-23 7:10 ` Stephen Boyd
2021-03-23 21:08 ` Doug Anderson
2021-03-22 3:01 ` [RFC PATCH 03/11] drm/bridge: ti-sn65dsi86: Unregister AUX adapter in remove() Laurent Pinchart
2021-03-23 7:10 ` Stephen Boyd
2021-03-23 21:08 ` Doug Anderson [this message]
2021-03-23 21:41 ` Laurent Pinchart
2021-03-23 22:55 ` Doug Anderson
2021-03-23 23:02 ` Laurent Pinchart
2021-03-26 0:43 ` Doug Anderson
2021-03-26 1:01 ` Laurent Pinchart
2021-03-22 3:01 ` [RFC PATCH 04/11] drm/bridge: ti-sn65dsi86: Use bitmask to store valid rates Laurent Pinchart
2021-03-23 7:11 ` Stephen Boyd
2021-03-23 21:08 ` Doug Anderson
2021-03-23 21:45 ` Laurent Pinchart
2021-03-23 22:45 ` Doug Anderson
2021-03-24 8:47 ` Geert Uytterhoeven
2021-03-22 3:01 ` [RFC PATCH 05/11] drm/bridge: ti-sn65dsi86: Wrap panel with panel-bridge Laurent Pinchart
2021-03-22 10:19 ` Jagan Teki
2021-03-23 7:14 ` Stephen Boyd
2021-03-23 21:50 ` Laurent Pinchart
2021-03-24 22:44 ` Doug Anderson
2021-03-26 1:06 ` Laurent Pinchart
2021-03-22 3:01 ` [RFC PATCH 06/11] drm/bridge: ti-sn65dsi86: Group code in sections Laurent Pinchart
2021-03-23 7:14 ` Stephen Boyd
2021-03-24 22:44 ` Doug Anderson
2021-03-22 3:01 ` [RFC PATCH 07/11] drm/bridge: ti-sn65dsi86: Split connector creation to a function Laurent Pinchart
2021-03-23 7:15 ` Stephen Boyd
2021-03-24 22:44 ` Doug Anderson
2021-03-22 3:01 ` [RFC PATCH 08/11] drm/bridge: ti-sn65dsi86: Implement bridge connector operations Laurent Pinchart
2021-03-23 7:15 ` Stephen Boyd
2021-03-24 22:46 ` Doug Anderson
2021-03-26 1:40 ` Laurent Pinchart
2021-03-22 3:01 ` [RFC PATCH 09/11] drm/bridge: ti-sn65dsi86: Make connector creation optional Laurent Pinchart
2021-03-22 3:01 ` [RFC PATCH 10/11] drm/bridge: ti-sn65dsi86: Support DisplayPort (non-eDP) mode Laurent Pinchart
2021-03-24 22:47 ` Doug Anderson
2021-06-23 13:59 ` Laurent Pinchart
2022-02-23 18:04 ` Kieran Bingham
2022-02-23 18:20 ` Doug Anderson
2022-03-04 15:49 ` Laurent Pinchart
2021-03-22 3:01 ` [RFC PATCH 11/11] drm/bridge: ti-sn65dsi86: Support hotplug detection Laurent Pinchart
2021-03-23 7:21 ` Stephen Boyd
2021-03-24 22:47 ` Doug Anderson
2021-06-23 23:25 ` Laurent Pinchart
2021-06-23 23:51 ` Doug Anderson
2022-02-23 17:43 ` Kieran Bingham
2022-02-23 18:25 ` Doug Anderson
2022-03-04 15:45 ` Kieran Bingham
2022-03-04 16:30 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=W-+aS25wtnSmF8tWSDHTdNCjbFj0x02-1iqZ2p5qYzyA@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=a.hajda@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).