From: Doug Anderson <dianders@chromium.org>
To: Harigovindan P <harigovi@codeaurora.org>
Cc: Sean Paul <sean@poorly.run>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Sean Paul <seanpaul@chromium.org>,
freedreno <freedreno@lists.freedesktop.org>
Subject: Re: [PATCH v2 2/2] drm/panel: add support for rm69299 visionox panel driver
Date: Thu, 9 Jan 2020 14:58:21 -0800 [thread overview]
Message-ID: <CAD=FV=XwkvGgJUeNs=aKoirSw_f47QoDTuvQF25VE7ychwdJTQ@mail.gmail.com> (raw)
In-Reply-To: <1578396597-18324-3-git-send-email-harigovi@codeaurora.org>
Hi,
On Tue, Jan 7, 2020 at 3:30 AM Harigovindan P <harigovi@codeaurora.org> wrote:
>
> + drm_panel_init(&ctx->panel);
> + ctx->panel.dev = device;
> + ctx->panel.funcs = &visionox_rm69299_drm_funcs;
I haven't reviewed your whole panel driver, but I did just try to
compile it and found that it won't compile against mainline. Namely
this needs to be changed to:
drm_panel_init(&ctx->panel, dev, &visionox_rm69299_drm_funcs,
DRM_MODE_CONNECTOR_DSI);
...because of commit 6dbe0c4b0fc0 ("drm/panel: Initialise panel dev
and funcs through drm_panel_init()") and commit 9a2654c0f62a
("drm/panel: Add and fill drm_panel type field")
-Doug
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-01-09 22:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 11:29 [PATCH v2 0/2] Add support for rm69299 Visionox panel driver and add devicetree bindings for visionox panel Harigovindan P
2020-01-07 11:29 ` [PATCH v2 1/2] dt-bindings: display: add sc7180 panel variant Harigovindan P
2020-01-08 21:01 ` Rob Herring
2020-01-13 21:59 ` Matthias Kaehlcke
2020-01-07 11:29 ` [PATCH v2 2/2] drm/panel: add support for rm69299 visionox panel driver Harigovindan P
2020-01-09 22:58 ` Doug Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=XwkvGgJUeNs=aKoirSw_f47QoDTuvQF25VE7ychwdJTQ@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=harigovi@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=sean@poorly.run \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).