From: Alex Deucher <alexdeucher@gmail.com>
To: Thomas Backlund <tmb@mageia.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Woody Suwalski" <terraluna977@gmail.com>,
"Christoph Hellwig" <hch@lst.de>,
"DRI mailing list" <dri-devel@lists.freedesktop.org>,
"Pavel Machek" <pavel@ucw.cz>,
"Deucher, Alexander" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: Regression in 5.4 kernel on 32-bit Radeon IBM T40
Date: Wed, 16 Sep 2020 18:15:21 -0400 [thread overview]
Message-ID: <CADnq5_PgQq4U86sSvpXSP6d9LUQHhohi4u2d6TjAPRA--1vM5A@mail.gmail.com> (raw)
In-Reply-To: <801e4196-5e22-e805-4d45-0245efdaa508@mageia.org>
On Mon, Feb 24, 2020 at 4:20 AM Thomas Backlund <tmb@mageia.org> wrote:
>
> Den 09-01-2020 kl. 17:12, skrev Christian König:
> > Hi Christoph,
> >
> > Am 09.01.20 um 15:14 schrieb Christoph Hellwig:
> >> Hi Woody,
> >>
> >> sorry for the late reply, I've been off to a vacation over the holidays.
> >>
> >> On Sat, Dec 14, 2019 at 10:17:15PM -0500, Woody Suwalski wrote:
> >>> Regression in 5.4 kernel on 32-bit Radeon IBM T40
> >>> triggered by
> >>> commit 33b3ad3788aba846fc8b9a065fe2685a0b64f713
> >>> Author: Christoph Hellwig <hch@lst.de>
> >>> Date: Thu Aug 15 09:27:00 2019 +0200
> >>>
> >>> Howdy,
> >>> The above patch has triggered a display problem on IBM Thinkpad T40,
> >>> where
> >>> the screen is covered with a lots of random short black horizontal
> >>> lines,
> >>> or distorted letters in X terms.
> >>>
> >>> The culprit seems to be that the dma_get_required_mask() is returning a
> >>> value 0x3fffffff
> >>> which is smaller than dma_get_mask()0xffffffff.That results in
> >>> dma_addressing_limited()==0 in ttm_bo_device(), and using 40-bits dma
> >>> instead of 32-bits.
> >> Which is the intended behavior assuming your system has 1GB of memory.
> >> Does it?
> >
> > Assuming the system doesn't have the 1GB split up somehow crazy over the
> > address space that should indeed work as intended.
> >
> >>
> >>> If I hardcode "1" as the last parameter to ttm_bo_device_init() in
> >>> place of
> >>> a call to dma_addressing_limited(),the problem goes away.
> >> I'll need some help from the drm / radeon / TTM maintainers if there are
> >> any other side effects from not passing the need_dma32 paramters.
> >> Obviously if the device doesn't have more than 32-bits worth of dram and
> >> no DMA offset we can't feed unaddressable memory to the device.
> >> Unfortunately I have a very hard time following the implementation of
> >> the TTM pool if it does anything else in this case.
> >
> > The only other thing which comes to mind is using huge pages. Can you
> > try a kernel with CONFIG_TRANSPARENT_HUGEPAGE disabled?
> >
>
>
> Any progress on this ?
>
> We have a bugreport in Mageia with the hw:
> Dell Inspiron 5100, 32-bit P4 processor, 2GB of RAM, Radeon Mobility
> 7500 (RV200) graphics
>
> that gets display issues too and reverting the offending commit restores
> normal behaviour.
>
> and the same issue is still there with 5.5 series kernels.
Does disabling HIMEM or setting radeon.agpmode=-1 on the kernel
command line in grub fix the issue?
Alex
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-09-16 22:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-15 3:17 Regression in 5.4 kernel on 32-bit Radeon IBM T40 Woody Suwalski
[not found] ` <20200109141436.GA22111@lst.de>
2020-01-09 15:12 ` Christian König
2020-01-09 22:40 ` Woody Suwalski
2020-01-10 2:40 ` Woody Suwalski
2020-03-14 22:06 ` Thomas Schwinge
2020-02-22 16:16 ` Thomas Backlund
2020-09-16 22:15 ` Alex Deucher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_PgQq4U86sSvpXSP6d9LUQHhohi4u2d6TjAPRA--1vM5A@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=terraluna977@gmail.com \
--cc=tmb@mageia.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).