From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B15A0C433DF for ; Mon, 25 May 2020 07:21:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7AA1A2065F for ; Mon, 25 May 2020 07:21:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZXyua9Pi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AA1A2065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B1A6489D3E; Mon, 25 May 2020 07:21:05 +0000 (UTC) Received: from mail-il1-x141.google.com (mail-il1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) by gabe.freedesktop.org (Postfix) with ESMTPS id A935A6EA45 for ; Sat, 23 May 2020 09:38:43 +0000 (UTC) Received: by mail-il1-x141.google.com with SMTP id c20so13250198ilk.6 for ; Sat, 23 May 2020 02:38:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ySOv5RFCOhNktqRnSUecG+h4XEMSSgtZIHTThacyrl4=; b=ZXyua9PiZh0B75CZ+wJJFbfRSHWNfEdmJG5gqb7VI4LU8BqFGnO8YgcvZZ0GAqcGjE KX+7b/V+awdlA48iOHjoSHYEiSgeqyhJVm9gaxlql1bRKv8Oz5DRsnTXZ43I65wYqPLK uWfkCx8oLLmUTWwYp6k8iCRtST2/u1tPVai3/4A1wyZBozQ0VNpEz99/9QjjcQVXM2QR P2+pYH4LqpepHkBrWOU+EzHTPfW42I+705YQv/OXS1POu52dVPCOQFN7btxk8VOkckse qCIXdqbsJuxDTw1PBbV6S3chJbH1DoEPjZGJzUkSr4As3rhhvWx+HcNkR6xmSO1tVCtq J8Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ySOv5RFCOhNktqRnSUecG+h4XEMSSgtZIHTThacyrl4=; b=ShTsYxBG3qMKysj+Ig6BCQSjSu9jEYXUWfWWnJDzqV39zqRQVwlUFZs1Ec5RHvKYFg 2HOu2y5pCo+rwYw4EUyKv91NUGNlaH402vDt9zsDjY1QjKhGlAH0pHREBB/z6mfSMy1n 9kfB3Jl4ZyFEtKjSlKPBmdNXpIIPKPmoLIGt6HwjIpUPlpRvXQQ8dUZtx/cE2tIC38UC vtaQEYft2c/VtAUtMXnfLOWiMDoTFpMsWgKLoZ6CM/ni3ib9hzFFN3BnW/2XgTRi4TVM gQ2Gd0HxtFGsC191oWKy2yCNQ9zb2LFH/Ksv1n/SoFTJ7lBt9Ad7c2xUfXFI3Gyt3N6H ymxA== X-Gm-Message-State: AOAM530vOMFmwFNBHjQzrFn5KeIKc8TqR8rif5cj4fEqwAKW71qDP0Oh 6yKgbcz97ICYG3I8PKfqTxOOrXkGWjzSGUlb9sc= X-Google-Smtp-Source: ABdhPJxgpTkyq+JCvO/9xevE2z4ZZX7u3mZjbSC4yXtpeOEmIaWlllSlL5fpKL/h6v2R/KBjV/68cLBWj/+cHclL77w= X-Received: by 2002:a92:5dd2:: with SMTP id e79mr15635058ilg.94.1590226723047; Sat, 23 May 2020 02:38:43 -0700 (PDT) MIME-Version: 1.0 References: <20200518201646.48312-1-dagmcr@gmail.com> <20200522202349.GF5824@pendragon.ideasonboard.com> In-Reply-To: <20200522202349.GF5824@pendragon.ideasonboard.com> From: Daniel G Date: Sat, 23 May 2020 11:38:32 +0200 Message-ID: Subject: Re: [PATCH] drm: rcar-du: Fix build error To: Laurent Pinchart X-Mailman-Approved-At: Mon, 25 May 2020 07:21:04 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, open list , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, kieran.bingham+renesas@ideasonboard.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Laurent, On Fri, 22 May 2020 at 22:24, Laurent Pinchart wrote: > > Hi Daniel, > > Thank you for the patch. > > On Mon, May 18, 2020 at 10:16:46PM +0200, Daniel Gomez wrote: > > Select DRM_KMS_HELPER dependency. > > > > Build error when DRM_KMS_HELPER is not selected: > > > > drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xd48): undefined reference to `drm_atomic_helper_bridge_duplicate_state' > > drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xd50): undefined reference to `drm_atomic_helper_bridge_destroy_state' > > drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xd70): undefined reference to `drm_atomic_helper_bridge_reset' > > drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xdc8): undefined reference to `drm_atomic_helper_connector_reset' > > drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xde0): undefined reference to `drm_helper_probe_single_connector_modes' > > drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xe08): undefined reference to `drm_atomic_helper_connector_duplicate_state' > > drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xe10): undefined reference to `drm_atomic_helper_connector_destroy_state' > > Fixes: c6a27fa41fab ("drm: rcar-du: Convert LVDS encoder code to bridge driver") > > Signed-off-by: Daniel Gomez > > Reviewed-by: Laurent Pinchart > > and taken in my tree for v5.9. If you think it should get in v5.8 as a > fix, I can do so as well, could you then provide a Fixes: tag ? That would be fine. You can find above the fixes tag. Thanks! > > > --- > > drivers/gpu/drm/rcar-du/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig > > index 0919f1f159a4..f65d1489dc50 100644 > > --- a/drivers/gpu/drm/rcar-du/Kconfig > > +++ b/drivers/gpu/drm/rcar-du/Kconfig > > @@ -31,6 +31,7 @@ config DRM_RCAR_DW_HDMI > > config DRM_RCAR_LVDS > > tristate "R-Car DU LVDS Encoder Support" > > depends on DRM && DRM_BRIDGE && OF > > + select DRM_KMS_HELPER > > select DRM_PANEL > > select OF_FLATTREE > > select OF_OVERLAY > > -- > Regards, > > Laurent Pinchart Daniel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel