From: Daniel Vetter <daniel@ffwll.ch>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>
Cc: daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/4] drm/nouveau: always wait for the exclusive fence
Date: Sat, 3 Jul 2021 01:00:38 +0200 [thread overview]
Message-ID: <YN+alm8BZtnvFC+Q@phenom.ffwll.local> (raw)
In-Reply-To: <20210702111642.17259-4-christian.koenig@amd.com>
On Fri, Jul 02, 2021 at 01:16:41PM +0200, Christian König wrote:
> Drivers also need to to sync to the exclusive fence when
> a shared one is present.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/nouveau/nouveau_fence.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b/drivers/gpu/drm/nouveau/nouveau_fence.c
> index 6b43918035df..05d0b3eb3690 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_fence.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_fence.c
> @@ -358,7 +358,7 @@ nouveau_fence_sync(struct nouveau_bo *nvbo, struct nouveau_channel *chan, bool e
> fobj = dma_resv_shared_list(resv);
> fence = dma_resv_excl_fence(resv);
>
> - if (fence && (!exclusive || !fobj || !fobj->shared_count)) {
> + if (fence) {
> struct nouveau_channel *prev = NULL;
> bool must_wait = true;
>
> --
> 2.25.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2021-07-02 23:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 11:16 Start fixing the shared to exclusive fence dependencies Christian König
2021-07-02 11:16 ` [PATCH 1/4] dma-buf: add some more kerneldoc to dma_resv_add_shared_fence Christian König
2021-07-02 22:16 ` Daniel Vetter
2021-07-02 11:16 ` [PATCH 2/4] dma-buf: fix dma_resv_test_signaled test_all handling v2 Christian König
2021-07-02 22:33 ` Daniel Vetter
2021-07-02 11:16 ` [PATCH 3/4] drm/nouveau: always wait for the exclusive fence Christian König
2021-07-02 23:00 ` Daniel Vetter [this message]
2021-07-02 11:16 ` [PATCH 4/4] drm/msm: " Christian König
2021-07-02 23:01 ` Daniel Vetter
2021-07-08 12:52 ` Christian König
2021-07-02 23:53 ` Start fixing the shared to exclusive fence dependencies Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YN+alm8BZtnvFC+Q@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).