From: Julia Lawall <julia.lawall@inria.fr>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
linux-omap@vger.kernel.org, Jingoo Han <jingoohan1@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Michal Simek <michal.simek@xilinx.com>,
Julia Lawall <Julia.Lawall@inria.fr>,
linux-fbdev@vger.kernel.org, Andy Gross <agross@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-arm-msm@vger.kernel.org, Shawn Guo <shawnguo@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] video: use getter/setter functions
Date: Wed, 10 Feb 2021 14:14:54 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2102101414100.2881@hadrien> (raw)
In-Reply-To: <YCPbxSHWMipTz+mB@phenom.ffwll.local>
[-- Attachment #1: Type: text/plain, Size: 2851 bytes --]
On Wed, 10 Feb 2021, Daniel Vetter wrote:
> On Wed, Feb 10, 2021 at 08:23:41AM +0000, Lee Jones wrote:
> > On Tue, 09 Feb 2021, Julia Lawall wrote:
> >
> > > Use getter and setter functions, for platform_device structures and a
> > > spi_device structure.
> > >
> > > Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
> > >
> > > ---
> > > drivers/video/backlight/qcom-wled.c | 2 +-
> >
> > This patch is fine.
> >
> > Could you please split it out and submit it separately though please.
>
> Or just apply the entire patch through backlight tree, there's nothing
> going on in fbdev anyway I think.
I was indeed not sure how much to split this up. If it is desired to
split it more, I can do that.
julia
>
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> >
> > > drivers/video/fbdev/amifb.c | 4 ++--
> > > drivers/video/fbdev/da8xx-fb.c | 4 ++--
> > > drivers/video/fbdev/imxfb.c | 2 +-
> > > drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c | 6 +++---
> > > drivers/video/fbdev/omap2/omapfb/dss/dpi.c | 4 ++--
> > > drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 4 ++--
> > > drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c | 2 +-
> > > drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c | 2 +-
> > > drivers/video/fbdev/xilinxfb.c | 2 +-
> > > 10 files changed, 16 insertions(+), 16 deletions(-)
> >
> > ...]
> >
> > > diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c
> > > index 3bc7800eb0a9..091f07e7c145 100644
> > > --- a/drivers/video/backlight/qcom-wled.c
> > > +++ b/drivers/video/backlight/qcom-wled.c
> > > @@ -1692,7 +1692,7 @@ static int wled_probe(struct platform_device *pdev)
> > >
> > > static int wled_remove(struct platform_device *pdev)
> > > {
> > > - struct wled *wled = dev_get_drvdata(&pdev->dev);
> > > + struct wled *wled = platform_get_drvdata(pdev);
> > >
> > > mutex_destroy(&wled->lock);
> > > cancel_delayed_work_sync(&wled->ovp_work);
> >
> > For my own reference (apply this as-is to your sign-off block):
> >
> > Acked-for-Backlight-by: Lee Jones <lee.jones@linaro.org>
> >
> > --
> > Lee Jones [李琼斯]
> > Senior Technical Lead - Developer Services
> > Linaro.org │ Open source software for Arm SoCs
> > Follow Linaro: Facebook | Twitter | Blog
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
>
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-02-10 13:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 21:13 [PATCH] video: use getter/setter functions Julia Lawall
2021-02-10 8:23 ` Lee Jones
2021-02-10 13:12 ` Daniel Vetter
2021-02-10 13:14 ` Julia Lawall [this message]
2021-02-10 16:12 ` Lee Jones
2021-02-11 15:40 ` Daniel Vetter
2021-02-12 10:02 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2102101414100.2881@hadrien \
--to=julia.lawall@inria.fr \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).